4169 Commits

Author	SHA1	Message	Date
Régis Hanol	3c0de22bf0	FIX: wasn't able to remove a user's primary group	2017-08-04 18:13:20 +02:00
Régis Hanol	519b70ea46	FIX: always trigger the ':user_updated' event ... We don't always use the UserUpdated class to update a user's record	2017-08-04 18:12:10 +02:00
Leo McArdle	99527af38a	FIX: show rejected emails with unrecognized errors (#5026) ... Although 407a23663d will send rejection messages for unrecognized errors, sometimes processing the email will raise an error which has a blank message. This commit: 1. Shows rejected emails which have already been processed and contain a blank error in /admin/email/rejected 2. Replaces new blank error messages with the error type	2017-08-04 16:20:44 +02:00
Guo Xiang Tan	40fc6c429a	Merge pull request #5018 from discourse/wekbit-embedded-referer ... FIX: First load of embed comments would always fail on WebKit	2017-08-04 14:12:26 +09:00
Guo Xiang Tan	8cc8010564	Maintain backwards compatibility before Jobs::MigrateUploadExtensions runs.	2017-08-03 11:56:55 +09:00
Guo Xiang Tan	a47e297508	Merge pull request #5019 from tgxworld/more_resiliency_to_readonly_redis ... Fix Redis command errors when trying to start app with a readonly Redis.	2017-08-03 06:34:36 +09:00
Sam	5942ad83c0	Skip inline onebox for domain only	2017-08-02 17:27:58 -04:00
Leo McArdle	65d5cd7239	FIX: generate valid markdown from <br></b> in an email (#5022) ... * FIX: generate valid markdown from <br></b> in an email * FIX: don't generate markdown for empty <strong> or <em> tags in emails	2017-08-02 23:02:59 +02:00
Rafael dos Santos Silva	57a214e920	FIX: First load of embed comments would always fail on WebKit	2017-08-02 17:43:31 -03:00
Sam	a4e1920604	FIX: inline oneboxer not applying to lists	2017-08-02 16:10:08 -04:00
Sam	f6bc572fb8	FEATURE: option to enable inline oneboxes for all domains ... Also, change to prefer title over open graph which is often way too sparse	2017-08-02 14:27:31 -04:00
Erick Guan	468a8fcd20	FEATURE: Site settings defaults per locale ... This change-set allows setting different defaults for different locales. It also: - Adds extensive testing around site setting validation - raises deprecation error if site setting has the default property based on env - relocated site settings for dev and tests in the initializer - deprecated client_setting in the site setting's loading process - ensure it raises when a enum site setting being set - default_locale is promoted to `required` category. - fixes incorrect default setting and validation - fixes ensure type check for site settings - creates a benchmark for site setting - sets reasonable defaults for Chinese	2017-08-02 12:24:19 -04:00
Neil Lalonde	3de45ce0cd	FIX: use case insensitive group name search when applying group rules from SSO	2017-08-02 11:30:37 -04:00
Guo Xiang Tan	9bc3038728	Fix Redis command errors when trying to start app with a readonly Redis.	2017-08-02 21:33:56 +09:00
Guo Xiang Tan	b6ce93a965	Add specs for 1c80c233cf	2017-08-02 20:58:35 +09:00
Régis Hanol	e43799134c	fix the regexp used to valide user's website	2017-08-02 10:19:24 +02:00
Sam	97fa64d846	FIX: non tag/category # searches should be passed through	2017-08-01 18:15:14 -04:00
Sam	71ad3a48c2	Correct flaky distributed cache test ... make distributed cache more testable	2017-08-01 16:11:48 -04:00
Guo Xiang Tan	5b76b9e888	Ensure that we cleanup after tests.	2017-08-01 23:42:26 +09:00
Guo Xiang Tan	7d5b6e2b3c	Disable MessageBus's keepalive when Redis is readonly.	2017-08-01 23:07:52 +09:00
Neil Lalonde	24edbbb89c	fix rubocop offenses	2017-07-31 20:34:02 -04:00
Neil Lalonde	fa3c240e8b	Merge pull request #4981 from dmacjam/fix_limited_search_results ... FIX: limited search results	2017-07-31 20:23:57 -04:00
Leo McArdle	836dee1120	FIX: add additional email to tests and clean up resulting mess	2017-07-31 22:27:29 +00:00
Régis Hanol	88ba052446	secure default for the 'find_related_post_with_key' site setting	2017-08-01 00:03:04 +02:00
Sam	cdf7a020c1	correct mistake in spec	2017-07-31 16:40:59 -04:00
Neil Lalonde	7c1d7fb423	Merge branch 'master' into fix_limited_search_results	2017-07-31 15:55:31 -04:00
Erick Guan	f1eccd113c	Replace rmmseg gem for cppjieba_rb since better dictionary (#5006) ... * Rename locale to ts config in search module to make it clear * Replace rmmese-cpp for cppjieba_rb	2017-07-31 15:28:48 -04:00
Arpit Jalan	6c997b65d9	optimize enqueuing activation email code	2017-07-31 22:57:39 +05:30
Arpit Jalan	0b01d0e95d	FIX: staff cannot manually activate accounts after 48 hours has elapsed ... https://meta.discourse.org/t/staff-cannot-manually-activate-invited-accounts-after-48-hours-has-elapsed/66292/14?u=techapj	2017-07-31 22:24:09 +05:30
Neil Lalonde	5d528f0d15	Merge pull request #4958 from dmacjam/search_posts_by_filetype ... FEATURE: Search posts by filetype	2017-07-31 11:55:34 -04:00
Neil Lalonde	4a5907b116	Merge branch 'master' into search_posts_with_images	2017-07-31 10:44:41 -04:00
Jakub Macina	f8edf2636c	Fix rspec tests for search pagination.	2017-07-31 12:16:23 +02:00
Régis Hanol	c7f76aa554	fix the receiver_spec	2017-07-31 11:29:39 +02:00
Guo Xiang Tan	305b9b2da0	Add spec to ensure that even staged users contain a primary email.	2017-07-31 12:16:08 +09:00
Guo Xiang Tan	24e0e000b9	FIX: Always validate presence of user's primary_email.	2017-07-31 11:47:29 +09:00
Arpit Jalan	b059a0f789	extract url escaping to a dedicated class method and improved tests	2017-07-29 22:16:51 +05:30
Arpit Jalan	1fe553873c	FIX: preserve fragment identifier when escaping url	2017-07-29 17:22:45 +05:30
Sam	56fd3e1cd4	attempt to stablise flaky spec	2017-07-28 16:59:37 -04:00
Robin Ward	9a76559345	FIX: Remove unused test	2017-07-28 11:59:12 -04:00
Guo Xiang Tan	4620dfe92d	FEATURE: Add group settngs to allow users to leave a group freely. ... https://meta.discourse.org/t/split-join-leave-freely-setting-on-groups/65565	2017-07-28 15:00:25 +09:00
Guo Xiang Tan	5012d46cbd	Add rubocop to our build. (#5004)	2017-07-28 10:20:09 +09:00
Sam	4f574e7c93	FEATURE: support inline bbcode blocks eg: [quote]test[/quote]	2017-07-27 17:55:17 -04:00
Neil Lalonde	68b3dd43ce	fix intermittent failing tests, some watched word refactoring	2017-07-27 12:27:01 -04:00
Guo Xiang Tan	75374c76b3	UX: Display button to message group on group page. ... https://meta.discourse.org/t/make-it-easier-to-send-a-message-to-groups/65065	2017-07-27 17:51:25 +09:00
Guo Xiang Tan	2442bba131	UX: Better group creation workflow. ... * Owners and users can now be added to a group during creation. https://meta.discourse.org/t/you-cannot-allow-membership-requests-without-any-owners/64760/3	2017-07-27 16:12:42 +09:00
Sam	dc42d4411d	correct flaky spec	2017-07-26 13:22:19 -04:00
Neil Lalonde	24cb950432	FEATURE: Watched Words: when posts contain words, do one of flag, require approval, censor, or block	2017-07-26 11:01:09 -04:00
David Taylor	27539e15e1	Allow whitespace around % scaler in markdown image syntax (#5000)	2017-07-26 10:54:20 -04:00
Neil Lalonde	ea0e90b2b0	Merge branch 'master' into search_posts_with_images	2017-07-26 10:15:55 -04:00
Guo Xiang Tan	b59dfb86f4	UX: Include group name in email when group is invited to a PM. ... https://meta.discourse.org/t/xyz-invited-you-to-a-message-but-really-invited-a-group-im-in/65996	2017-07-26 15:51:44 +09:00
Guo Xiang Tan	d3a975e99a	Improve specs to check top level stylesheets for SCSS compilation errors. ... https://meta.discourse.org/t/fwd-growth-institute-pm-error-in-css-on-embed/66824/4	2017-07-26 10:50:51 +09:00
Guo Xiang Tan	e3ac6585bd	FIX: Search by topic_id should not be restricted by SiteSetting.min_search_term_length.	2017-07-26 09:52:39 +09:00
Guo Xiang Tan	96267f0845	Merge pull request #4960 from discourse/category-description-error ... FIX: Explicit error when category description post is bad	2017-07-26 08:54:22 +09:00
Sam	658c2f52c0	add diagnostics for flaky test	2017-07-25 17:09:13 -04:00
Sam	ad8643bfe2	attempt to stablise spec in travis	2017-07-25 16:58:19 -04:00
Sam	ccbcbd0343	remove 2 failures that happen if discobot booted	2017-07-25 16:08:03 -04:00
Sam	a20bb931b1	FIX: specs failed if discourse-push-notifications booted	2017-07-25 15:52:53 -04:00
Neil Lalonde	d8c27e3871	Merge branch 'master' into search_posts_by_filetype	2017-07-25 14:41:20 -04:00
Régis Hanol	d67fe4c674	FIX: block all emails associated to a user when destroying their record	2017-07-25 17:44:46 +02:00
Sam	f2d5bcd439	Stop writing to STDOUT/ERR during tests	2017-07-25 11:37:25 -04:00
Sam	c5b5c861f6	extend wait_for in case redis chokes up in test	2017-07-25 11:29:12 -04:00
Guo Xiang Tan	4cd9822611	Remove warnings in ColumnDropper.mark_readonly test.	2017-07-25 09:38:55 +09:00
Guo Xiang Tan	be3c9bca0b	Remove comment that is no longer relevant.	2017-07-25 08:58:40 +09:00
Sam	4da98cdcfe	FIX: allow bbcode to be unquoted for default	2017-07-24 18:36:17 -04:00
Sam	04eac9f14a	lets attempt to get these specs working!	2017-07-24 18:35:20 -04:00
Sam	f67e715ef1	comment out specs that break others ... will check in a fixed spec tomorrow	2017-07-24 17:28:24 -04:00
Sam	c08a7aee8f	clean up skipped tests ... tighter connection handling in scheduler	2017-07-24 15:06:24 -04:00
Sam	80bb127cd3	use time zone for extra safety	2017-07-24 13:08:17 -04:00
Sam	7ebb9874a8	freeze time in spec	2017-07-24 13:00:15 -04:00
Sam	40abcfc2f5	FIX: smart quote edge case with quotes	2017-07-24 12:21:49 -04:00
Sam Saffron	045a2abcec	FEATURE: remove the timecop gem ... We should only have one way of mocking time, misuse of timecop was causing build stability issues	2017-07-24 12:11:10 -04:00
Guo Xiang Tan	d940166a89	Re-enable skipped Scheduler::ScheduleInfo test.	2017-07-25 00:03:03 +09:00
Guo Xiang Tan	8ee31d3c85	Re-enable skip tests for Email::Styles.	2017-07-24 23:16:54 +09:00
Guo Xiang Tan	e82efc7b03	Fix SiteSetingExtension specs to coerce int to string.	2017-07-24 22:54:42 +09:00
Guo Xiang Tan	0ab0c82f11	Reenable skipped Email::Receiver spec.	2017-07-24 22:27:24 +09:00
Guo Xiang Tan	6b17178533	Validate uniquness of api_key.	2017-07-24 21:46:08 +09:00
Guo Xiang Tan	54b508dda3	Add back test to ensure user can't edit name after SiteSetting.username_change_period.	2017-07-24 20:47:34 +09:00
Guo Xiang Tan	d9c3ebe299	Reintroduce specs that wasn't causing random failures.	2017-07-24 19:32:38 +09:00
Régis Hanol	640ced004d	FIX: wasn't unfreezing time in email processor spec	2017-07-24 11:01:53 +02:00
Guo Xiang Tan	1b0750d7ef	Merge pull request #4983 from tgxworld/group_owners_can_invite_users_to_groups ... Group owners can invite users to groups	2017-07-24 16:21:19 +09:00
Guo Xiang Tan	fa09a02201	Fix specs.	2017-07-24 15:56:08 +09:00
Guo Xiang Tan	25448b70e4	Fix specs.	2017-07-24 15:52:56 +09:00
Guo Xiang Tan	c12edda766	Use Timecop.freeze instead of Timecop.travel.	2017-07-24 15:40:57 +09:00
Guo Xiang Tan	86dbd76191	Fix random spec failure due to ordering.	2017-07-24 15:25:07 +09:00
Guo Xiang Tan	7f1e74a272	Not sure how this spec actually worked in the past.	2017-07-24 14:13:23 +09:00
Guo Xiang Tan	381a2a55be	Clear the cache after each test otherwise we are leaking state.	2017-07-24 11:41:37 +09:00
Sam Saffron	93f2c97266	simplify spec	2017-07-22 22:49:04 -04:00
Sam Saffron	687fbf5f09	simplify spec	2017-07-22 22:47:16 -04:00
Sam Saffron	b9757bd02e	remove readonly column specs for now	2017-07-22 22:20:57 -04:00
Sam Saffron	7caf82f03c	simplify spec	2017-07-22 22:01:11 -04:00
Sam	8ef4d6d812	this was failing erratically	2017-07-21 17:14:06 -04:00
Robin Ward	2f8f2aa1dd	FEATURE: Whitelists for inline oneboxing	2017-07-21 15:41:47 -04:00
Rafael dos Santos Silva	89ef5d36a9	FIX: Explicit error when category description post is bad	2017-07-21 16:07:29 -03:00
Régis Hanol	fff5e2c3a5	Merge pull request #4984 from LeoMcA/unrecognized-error-email ... FEATURE: send rejection email for unrecognized errors	2017-07-21 20:40:18 +02:00
Robin Ward	574681dc47	FIX: Show emoji in inline oneboxes	2017-07-21 14:24:48 -04:00
Leo McArdle	407a23663d	FEATURE: send rejection email for unrecognized errors	2017-07-21 18:26:52 +01:00
Sam	e1ce47a901	Pass the full CommonMark spec	2017-07-21 13:20:52 -04:00
Leo McArdle	ddc0134b48	add DiscourseEvent triggers necessary to update a user's permissions before they're notified	2017-07-21 11:03:54 -04:00
Guo Xiang Tan	2a17f1ccd7	FIX: Group owners should be able to invite users to their groups. ... https://meta.discourse.org/t/group-owner-cannot-send-an-invite-to-a-group/60617/12	2017-07-21 23:48:25 +09:00
Jakub Macina	4eb7f7cd10	Add rspec tests for search pagination.	2017-07-21 10:43:02 +02:00