Commit Graph

16173 Commits

Author SHA1 Message Date
Kris
257950e8bd UX: Replace composer cancel and upload with icons 2018-03-09 22:29:42 -05:00
Jeff Atwood
9522469f6a
Merge pull request #5664 from dbnicholson/robots-no-uploads
Prevent robots from indexing uploads
2018-03-09 13:33:34 -08:00
Michael Brown
3c3d205180 FIX: sso_overrides_username may inappropriately change the username if the case changed 2018-03-09 16:06:55 -05:00
Kris
0f07999c11 FIX: Safari flexbox bug in header dropdowns 2018-03-09 15:58:53 -05:00
Arpit Jalan
aac7796124 FIX: do not show tags with 0 count on /tags page 2018-03-09 20:57:31 +05:30
Dan Nicholson
0fd622e5d1 Prevent robots from indexing uploads
Although most user uploads are probably harmless, it's possible someone
has (either maliciously or not) uploaded sensitive information. Prevent
robots from indexing the uploads route.
2018-03-09 05:51:55 -06:00
Gerhard Schlager
dc77cce8d9 FIX: Create notifications for mentions in PMs 2018-03-09 11:04:29 +01:00
Guo Xiang Tan
0e1b896821 Explicitly assign primary_email record when creating a user
* This looks like we're doing the same thing but
  we're debugging a race condition where a user
  can be created without an email record. Therefore,
  we prefer the more obvious method of assigning an
  association.
2018-03-09 15:59:46 +08:00
Sam
7c0e6b820e move key so it does not interfere with other errors 2018-03-09 16:42:11 +11:00
Sam
39e679d3cb FEATURE: allow themes to live in private git repos
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
Neil Lalonde
34a0e79bec FIX: use digest_min_excerpt_length site setting in summary emails 2018-03-08 23:35:10 -05:00
Guo Xiang Tan
a89f3160a5 Add new config to ensure backup/restore connects to PG directly.
* In `pg_dump` 10.3+ and 9.5.12+, in
  it does a `SELECT pg_catalog.set_config('search_path', '', false)`
  which changes the state of the current connection. This is known
  to be problematic with Pgbouncer which reuses connections. As such,
  we'll always try to connect directly to PG directly during
  the backup/restore process.
2018-03-09 10:28:03 +08:00
Sam
9a4a7422f5 FIX: not loading more messages when username has a . 2018-03-09 11:01:46 +11:00
Sam
5ff857d770 remove theme yaml from UI, it only causes troubles 2018-03-09 11:01:46 +11:00
Robin Ward
6385c7fcb3 UX: Don't let topic progress widget dangle when preview is disabled 2018-03-08 16:34:19 -05:00
Arpit Jalan
4ad3a258d1 FIX: tag filter was not selected on page load 2018-03-08 20:09:31 +05:30
Arpit Jalan
4b23634092 FIX: converting topic to message for a second time was broken 2018-03-08 17:59:04 +05:30
Arpit Jalan
0c2be8b775
Merge pull request #5655 from techAPJ/pm-tags-dropdown
FEATURE: filter personal messages by tags
2018-03-08 16:30:38 +05:30
Arpit Jalan
a8149f8969 FIX: user should not be able to invite to PM if trust level requirment not met
FIX: when personal messages are disabled let user invite to a public topic
2018-03-08 14:59:04 +05:30
Arpit Jalan
c29660c8f1 FEATURE: filter personal messages by tags 2018-03-08 14:42:07 +05:30
Sam
86c00ac6ad stop using deprecated size() 2018-03-08 15:26:29 +11:00
Simon Cossar
88fdc926d1 Move external_id from UserSerializer to CurrentUserSerializer (#5658) 2018-03-07 22:54:31 -05:00
Sam
7a831857fc remove deprecated method 2018-03-08 14:53:09 +11:00
Neil Lalonde
873feb7b7c
Merge pull request #5654 from tshenry/user-profile-avatar-flair-plugin-outlet
FEATURE: Add user-profile-avatar-flair plugin outlet
2018-03-07 17:04:20 -05:00
Régis Hanol
b5b5b68972 Add proper error message when SCSS variable name is invalid when uploading a theme file 2018-03-07 21:37:22 +01:00
Neil Lalonde
1093dacc03 FIX: bulk importers need to create category description topics 2018-03-07 12:10:22 -05:00
Joffrey JAFFEUX
90a1b48503
FIX: correctly allow tag creation if this.site.get("can_create_tag") 2018-03-07 16:06:56 +01:00
Taylor Henry
8c0369e86f FEATURE: Add user-profile-avatar-flair plugin outlet
Adds a plugin outlet in the user profile for avatar flair.
2018-03-07 02:38:08 -08:00
Guo Xiang Tan
e7cc2e6d33 FIX: loadBefore should include current params as well. 2018-03-07 16:57:06 +08:00
Guo Xiang Tan
c6cb7f6693 UX: Add title to user messages page. 2018-03-07 15:24:11 +08:00
Guo Xiang Tan
3045c589f6 FIX: Publish live messages to both team inbox and archive on update. 2018-03-07 14:01:20 +08:00
Guo Xiang Tan
5169be6080 FIX: User archiving message should also publish to sent section. 2018-03-07 11:39:23 +08:00
Guo Xiang Tan
bef35f7be5 FIX: User archive messages should only publish to the user. 2018-03-07 11:28:29 +08:00
Guo Xiang Tan
82619c2445 FIX: Missing messages incoming indicator for mobile. 2018-03-07 10:27:18 +08:00
Neil Lalonde
2e5c18d130
Merge pull request #5652 from majakomel/add-slovenian-locale
Add Slovenian locale files
2018-03-06 15:59:01 -05:00
Joffrey JAFFEUX
187fdb9799
FIX: do not show read-only cursor on mini-tag-chooser (#5653) 2018-03-06 21:21:24 +01:00
Maja Komel
e2a441ade9 Add Slovenian translations 2018-03-06 20:51:41 +01:00
Robin Ward
81780d8607 Merge remote-tracking branch 'origin/analyze-code-fix' 2018-03-06 13:16:37 -05:00
Gerhard Schlager
07649cd42d FIX: email_domains_whitelist prevented creation of anonymous users 2018-03-06 18:14:53 +01:00
Robin Ward
c74d10cf34 FIX: Consider live links in <code> as links when counting 2018-03-06 11:46:12 -05:00
Guo Xiang Tan
8f5349eaa1 FIX: Only unsubscribe channel if it was subscribed. 2018-03-06 21:39:30 +08:00
Guo Xiang Tan
e09a4a353e FIX: Incorrectly deleting channel preventing us from unsubscribing MB. 2018-03-06 19:52:00 +08:00
Guo Xiang Tan
1365bab0d7 FEATURE: Live updates for user's messages page.
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
2018-03-06 18:15:21 +08:00
Guo Xiang Tan
13764b31ec Remove unnecessary attribute in topic tracking payload. 2018-03-06 17:37:53 +08:00
Guo Xiang Tan
d576056cff REFACTOR: Add basic tests for TopicTrackingState#publish_*.
* Ensure we don't publish events for PMs.
2018-03-06 17:37:53 +08:00
Guo Xiang Tan
821f3d0c15 REFACTOR: Remove code duplication. 2018-03-06 17:37:53 +08:00
Sam
0134e41286 FEATURE: detect when client thinks user is logged on but is not
This cleans up an error condition where UI thinks a user is logged on
but the user is not. If this happens user will be prompted to refresh.
2018-03-06 16:49:31 +11:00
Sam
f0d5f83424 FEATURE: limit assets less that non asset paths
By default assets can be requested up to 200 times per 10 seconds
from the app, this includes CSS and avatars
2018-03-06 15:20:39 +11:00
Gerhard Schlager
8e48b339fa Drop unused tables (#5630) 2018-03-05 17:27:30 -05:00
OsamaSayegh
adc46ac56c UX: Improvements for theme UI (#5650)
* Don't display "Settings: YAML" in Custom CSS/HTML section

* Don't show the settings tab for remote/imported themes
2018-03-05 17:26:50 -05:00
Robin Ward
0f66a99eb2 Setting to prevent logging details when anonymizing 2018-03-05 14:38:18 -05:00
Arpit Jalan
003b03d939 allow staff to delete user if posts are 5 or less irrespective of delete_user_max_post_age 2018-03-05 23:31:29 +05:30
Kris
62d1ba4fdb Menu fix for iOS 2018-03-05 11:32:43 -05:00
Joffrey JAFFEUX
057fa049e6
FIX: display keyboard on mobile when focusing mini-tag-chooser 2018-03-05 10:55:20 +01:00
Guo Xiang Tan
2f65393706 REFACTOR: Use Topic#private_message? to reduce duplication. 2018-03-05 15:39:22 +08:00
Guo Xiang Tan
07f1d90b88 FIX: Inviting a group that I am part of creates a notification.
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld
2018-03-05 13:51:32 +08:00
Guo Xiang Tan
42e0aaed61 FIX: Set first visit PM notification level to group default notification level.
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld
2018-03-05 13:39:00 +08:00
Sam
9331b4849d FEATURE: we need access to settings in theme js 2018-03-05 15:35:41 +11:00
Sam
95555b5ec8 If there are no settings do now show section 2018-03-05 11:11:21 +11:00
Sam
2c25b9ae12 annotate 2018-03-05 11:06:45 +11:00
OsamaSayegh
282f53f0cd FEATURE: Theme settings (2) (#5611)
Allows theme authors to specify custom theme settings for the theme. 

Centralizes the theme/site settings into a single construct
2018-03-04 19:04:23 -05:00
Arpit Jalan
322618fc34 FIX: capital bbcode tags were broken 2018-03-04 22:10:54 +05:30
Joffrey JAFFEUX
a15b2fdeca
FIX: make it possible to edit tags on topics on mobile 2018-03-04 13:47:25 +01:00
Robin Ward
13eda41ff5 Fix lint errors 2018-03-03 14:34:19 -05:00
Robin Ward
31e3bf6d8d FEATURE: New "Categories and Top" homepage style
Select this option if you want to show top topics on the homepage
instead of latest topics.
2018-03-03 14:26:57 -05:00
Joffrey JAFFEUX
5e323139ae
FIX: makes sure we recompute shouldDisplayCreateRow after request 2018-03-03 11:42:44 +01:00
Kris
6d359ca823 Z-index fix for hidden posts 2018-03-02 22:41:10 -05:00
Robin Ward
b11dd21356 FIX: Translate the hover text or emoji categories 2018-03-02 18:28:06 -05:00
Kris
c684843c53 Improving title selection on badge pages 2018-03-02 16:15:58 -05:00
Neil Lalonde
dda248f5df FIX: tag input in composer was not respecting tag group rules 2018-03-02 15:56:24 -05:00
Kris
efb0bf6b16 Categories in hamburger menu were misaligned in Firefox 2018-03-02 15:04:55 -05:00
Kris
5e11bc79ff Fixing some regressions for profile badges 2018-03-02 14:43:54 -05:00
Kris
70acfa47d7 FIX: In some instances expanding hamburger menu broke layout in iOS 2018-03-02 14:13:43 -05:00
Kris
0783f8b9e6 Fixing badge detail positioning 2018-03-02 13:21:36 -05:00
Robin Ward
730201d423 New interface to upsert custom fields 2018-03-02 12:45:52 -05:00
Kris
0ec1dc9237 UX: Improving badge page layout 2018-03-02 12:43:01 -05:00
Neil Lalonde
5833d00739 SECURITY: sanitize topic title when staff is viewing a user's past flagged posts and deleted topics 2018-03-02 11:58:11 -05:00
Arpit Jalan
334ed74346
Merge pull request #5635 from techAPJ/invite-muted
FIX: do not allow invite notifications from muted user/topic
2018-03-02 18:10:17 +04:00
Guo Xiang Tan
6b59a2827d Add more information to SSO user creation logging. 2018-03-02 18:27:15 +08:00
Joffrey JAFFEUX
6d4ff05cf0
FIX: makes sure [999500..999999] is correctly shown as 999k 2018-03-02 11:00:48 +01:00
Guo Xiang Tan
642c60c310 Rename variable so that it is clearer which variable is being referred. 2018-03-02 16:41:02 +08:00
Arpit Jalan
2e202495a3 FIX: do not allow invite notifications from muted user/topic 2018-03-02 12:24:51 +05:30
Guo Xiang Tan
d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Guo Xiang Tan
50eb582fb2 Remove cas oauth login method that is no longer used. 2018-03-02 14:22:52 +08:00
Sam
d39d2b9352 FEATURE: whitelist data for themes 2018-03-02 14:52:09 +11:00
Guo Xiang Tan
939180efa8 FIX: Missing 2FA guards when sso is enabled or when local login is disabled. 2018-03-02 10:39:10 +08:00
Sam
e19ae6c55e FEATURE: disallow groups from being indexed 2018-03-02 13:38:30 +11:00
Sam
185507d072 UX: remove fast scroll which is leading to bugs 2018-03-02 12:58:38 +11:00
Sam
75172024ca SECURITY: ensure users have permission when moving categories 2018-03-02 12:13:27 +11:00
Régis Hanol
25d80aabce remove 'puts' 2018-03-02 01:50:24 +01:00
Gerhard Schlager
80e85e0d8f FIX: Sidekiq job has wrong data when post owner changes within transaction 2018-03-01 18:00:18 +01:00
Gerhard Schlager
79590e4bec FIX: Merging users shouldn't add more than 1 secondary email 2018-03-01 17:50:13 +01:00
Gerhard Schlager
a7c50039de FIX: Allow changing post owner even when topic validations fail 2018-03-01 17:31:58 +01:00
Gerhard Schlager
7a2183e8ab FEATURE: rake task for merging users 2018-03-01 12:28:12 +01:00
Gerhard Schlager
fffd1a6602 FIX: Associated Instagram account was missing at some places 2018-03-01 12:26:40 +01:00
Joffrey JAFFEUX
7ae1c5a663
FIX: emoji search was not finding aliases 2018-03-01 12:11:52 +01:00
Joffrey JAFFEUX
c9cb6920dc
FIX: category drop header padding when using category box style 2018-03-01 11:59:13 +01:00
Joffrey JAFFEUX
460c905dc6
FIX: improves positioning of select-kit body 2018-03-01 11:53:14 +01:00
Guo Xiang Tan
674239718c UX: Hide social login buttons when requesting for 2FA token. 2018-03-01 15:52:09 +08:00
Guo Xiang Tan
fb75f188ba FEATURE: Disallow login via omniauth when user has 2FA enabled. 2018-03-01 15:47:07 +08:00
Guo Xiang Tan
947b6fdf46 FIX: Incorrect rate limit applied to topics invitation flow. 2018-03-01 12:50:00 +08:00
Guo Xiang Tan
5a462b930d REFACTOR: Prefer exists? over present. 2018-03-01 10:22:41 +08:00
Kris
4b17b39e73 Remove unnedded padding 2018-02-28 15:07:08 -05:00
Kris
f375731278 About page layout improvements 2018-02-28 15:03:12 -05:00
Robin Ward
b283bb2ba7 FIX: Don't include unlisted topic in groups/posts 2018-02-28 14:40:18 -05:00
Kris
6c50ef9b5d font-sizes on body-pages were too large due to nesting 2018-02-28 13:23:43 -05:00
Guo Xiang Tan
e7a7356986 Remove ancient votes code that is no longer used. 2018-02-28 14:37:22 +08:00
Neil Lalonde
764b6c005c FIX: don't show Other Tags on /tags if there aren't any to show 2018-02-27 22:30:46 -05:00
Guo Xiang Tan
902c5d11cf FIX: Don't allow other flag actions after notify_moderator has happened.
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
2018-02-28 11:27:56 +08:00
scossar
51544047dc Add external_id to User Serializer 2018-02-28 10:13:27 +08:00
Kris
b832c3d885 Glyph wasn't wrapping properly with long categories 2018-02-27 17:10:02 -05:00
Kris
be63b08c36 Truncate long category names in subcategory boxes 2018-02-27 16:48:20 -05:00
Joffrey JAFFEUX
8ca1b1ab0b
FIX: load tag_groups and not tags 2018-02-27 21:10:57 +01:00
Kris
e32691a3e9 Simplifying category overflow on category pages 2018-02-27 13:11:22 -05:00
Joffrey JAFFEUX
9b680fc45c
FIX: prevents create row to be displayed if term is in displayed list 2018-02-27 18:31:58 +01:00
Joffrey JAFFEUX
ba2f01c0bd
FIX: prevents selected value from hiding one item of the list 2018-02-27 18:31:51 +01:00
Kris
96b4617094 Fixing category title with logo image layout 2018-02-27 10:47:05 -05:00
Gerhard Schlager
c22e56499a FIX: Allow changing post owner even when validations fail 2018-02-27 15:46:20 +01:00
Arpit Jalan
4010d8d9f9 FEATURE: show "edit message" button on message footer for staff
Show "Edit Message" button on personal message footer for staff if PM tagging is enabled.
2018-02-27 14:22:03 +05:30
Joffrey JAFFEUX
410b90dde0
FIX: mini-tag-chooser was not returning a correct list of tags
Should also fix an issue where it validates the creation of an existing tag.
2018-02-27 08:47:44 +01:00
Guo Xiang Tan
486bbe9cc2 FIX: Auto re-opened topics should restore category auto close settings.
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
2018-02-27 15:33:31 +08:00
Joffrey JAFFEUX
83e8ab5274
FIX: header icon out of bounds in tag-drop on some browsers 2018-02-27 08:33:06 +01:00
Guo Xiang Tan
519026a31f Trim attributes that are not useful from WebHookTopicViewSerializer. 2018-02-27 11:28:31 +08:00
Guo Xiang Tan
66d620f7b1 FEATURE: Trigger topic webhook when topic status is updated. 2018-02-27 11:07:37 +08:00
Guo Xiang Tan
104df3126b UX: Incorrect width for webhook events. Take 2. 2018-02-27 10:34:46 +08:00
Guo Xiang Tan
8d16ca2af2 UX: Incorrect width for webhook events. 2018-02-27 10:32:11 +08:00
Guo Xiang Tan
24f3b78548 Fix incorrect ids for 2FA inputs. 2018-02-27 10:12:22 +08:00
Guo Xiang Tan
70f14da732 UX: Use 'tel' input type for 2FA token inputs. 2018-02-27 09:30:44 +08:00
Robin Ward
8296f493ed add class to easier targetting 2018-02-26 19:03:21 -05:00
Robin Ward
c7a37f391a New event when a flag is handled 2018-02-26 18:51:51 -05:00
Kris
382dbfbb8a Fix for categories with icons not wrapping properly 2018-02-26 17:00:03 -05:00
Neil Lalonde
8f27456acb UX: Move 'show words' checkbox close to the words in the Watched Words UI 2018-02-26 16:35:52 -05:00
Kris
436d2b57c9 Fixing categories not wrapping properly 2018-02-26 16:33:24 -05:00
Neil Lalonde
3313072957 Remove censored_pattern site setting, which is replaced by watched words 2018-02-26 16:29:27 -05:00
Gerhard Schlager
5ca5817902 FIX: Only likes should change the given daily likes 2018-02-26 22:27:18 +01:00
Kris
e2a524550c Prevent long category names from breaking topic/category list layouts 2018-02-26 14:21:28 -05:00
Robin Ward
f8856f3d7a FIX: Anonymous users shouldn't see the link to new in the footer 2018-02-26 13:46:50 -05:00
Joffrey JAFFEUX
ac701696b3
FEATURE: replaces tag-chooser/tag-group-chooser with select-kit component
These component were also the last using select2. As a consequence select2 is removed from Discourse in this commit.
2018-02-26 11:42:57 +01:00
Guo Xiang Tan
a9699da672 UX: Specify pattern and maxlength for 2FA input fields. 2018-02-26 18:29:46 +08:00
Guo Xiang Tan
c1f53e1ece UX: Invited users should watch PM topic once topic has been visited.
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11
2018-02-26 17:58:58 +08:00
Guo Xiang Tan
982e5bae3a Update annotations. 2018-02-26 15:32:04 +08:00
Guo Xiang Tan
6a88f7db61 Notification created for wrong user after invite.
Introduced in c64f09b6b7
2018-02-26 13:21:19 +08:00
Guo Xiang Tan
31242335a6 Revert "Fix the build."
This reverts commit 07f928e05e.
2018-02-26 13:08:10 +08:00
Guo Xiang Tan
07f928e05e Fix the build. 2018-02-26 12:42:55 +08:00
Guo Xiang Tan
c64f09b6b7 REFACTOR: Simplify and DRY Group#invite. 2018-02-26 11:59:07 +08:00
Guo Xiang Tan
3e1afbedc5 FIX: Missing translation for non-admin when editing a group.
https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303
2018-02-26 10:11:18 +08:00
Guo Xiang Tan
616d210911
Merge pull request #5614 from nbianca/fix_period
Try extracting time period only when the filter is 'top'.
2018-02-26 09:38:33 +08:00
Régis Hanol
0559a4736a FIX: don't double request when downloading a file 2018-02-24 12:35:57 +01:00
Kris
b731d5d9b5 Removing unneeded and duplicate styles 2018-02-23 21:43:05 -05:00
Kris
bd892199e7 Increasing topic-admin menu width to prevent wrapping on mobile 2018-02-23 13:51:06 -05:00