IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-01 21:19:41 -06:00
Code Issues Packages Projects Releases Wiki Activity
33,977 Commits 221 Branches 500 Tags 911 MiB
67650328b4
Commit Graph

13546 Commits

Author SHA1 Message Date
Joffrey JAFFEUX
240b61e844
fix tests, crsf token meta is not present on tests (#7733) 2019-06-07 17:11:16 +02:00
Joffrey JAFFEUX
dfb66334c1
DEV: prevents global-notice events to leak (#7732) 2019-06-07 16:49:59 +02:00
Joffrey JAFFEUX
55325679ac
DEV: prevents share-popup to leak events (#7731) 2019-06-07 16:48:45 +02:00
Joffrey JAFFEUX
da5255e560
DEV: prevents csrf-token initializer to leak session object (#7730) 2019-06-07 16:46:55 +02:00
Joffrey JAFFEUX
df01249db4
FIX: removes leaking handler in select-kit (#7729) 2019-06-07 16:12:22 +02:00
Joffrey JAFFEUX
fca90106b9
FIX: select-kit events were sometimes not cleaned up (#7728) 2019-06-07 15:20:01 +02:00
Gerhard Schlager
d1228f47bb FIX: Handle missing plural keys on client 2019-06-07 10:24:17 +02:00
Joffrey JAFFEUX
a652d620f6 FIX: safari desktop doesnt support input[time] (#7719) 
This commit attempts to improve the experience by:
- showing time input as disabled on any platform if date hasn't been set
- showing a placeholder --:-- to emphasize the expected format
 2019-06-07 15:50:43 +10:00
Maja Komel
9db1fef4e3 FIX: add support for custom/plugin notification title attribute 2019-06-07 09:09:16 +08:00
Bianca Nenciu
35da531f1d FIX: Do not resize images in Onebox while lazy loading. 
Follow-up to 35d0fd0.
 2019-06-06 18:36:18 +03:00
Joffrey JAFFEUX
48b6391777
FIX: s/thumb-tack/thumbtack (#7718) 2019-06-06 14:43:16 +02:00
Joffrey JAFFEUX
c462c2f271
FIX: prevents appEvents to leak (#7714) 2019-06-06 12:33:52 +02:00
Guo Xiang Tan
782da448a2 FIX: Missing title attribute when quoting an image. 2019-06-06 16:45:12 +08:00
Guo Xiang Tan
2265c5102f DEV: Remove unnecessary condition. 
Follow up to 21876d46d6.
 2019-06-06 15:55:49 +08:00
Guo Xiang Tan
21876d46d6 DEV: Missing loading spinner for staff action logs. 
Follow up to e0c821ebb0.
 2019-06-06 15:41:55 +08:00
Bianca Nenciu
e0c821ebb0 FEATURE: Make staff action logs page support infinite loading 2019-06-06 13:02:53 +10:00
Roman Rizzi
c3a38d2304 DEV: Make groups/new extensible by plugins (#7642) 
* Expose a new plugin outlet. Pass group model to the group-member-dropdown so it can be accessed by plugins

* Added controller tests for group custom fields. update custom fields when updating a group
 2019-06-06 12:05:33 +10:00
Guo Xiang Tan
7bd8f715bc DEV: Prefer this.site.notification_types. 2019-06-06 09:39:59 +08:00
Guo Xiang Tan
d9d36f241d DEV: Use this.site.get("notification_types") instead. 
Follow up to fcb7422213.
 2019-06-06 08:18:25 +08:00
Kris
54db23e4ff UX: Make input caret color match text color 2019-06-05 14:27:27 -04:00
Robin Ward
58ff7216ca UX: Display "Queued Topic" if a Queued Post will create a topic 2019-06-05 14:11:28 -04:00
Robin Ward
d902c4eb9f FEATURE: Can sort reviewable queue 
Choices are Priority / Created At (and desc versions.)
 2019-06-05 13:21:05 -04:00
Bianca Nenciu
35d0fd038e FIX: Add unit to width and height CSS properties. 2019-06-05 19:51:31 +03:00
Kris
c0e8950fdb UX: Shrink oneboxes and other wide content in custom post messages 2019-06-05 12:48:06 -04:00
Robin Ward
f1d547c301 FEATURE: Show "in reply to" on the review queue 
We now show if a queued or flagged post is a reply to another when in
the review queue. It's especially helpful for queued posts where
normally they are linked to the topic where they are created, and you
have no context about the reply.

Note that this will only apply to new queued posts going forward.
Previously queued posts will not show the "in reply to"
 2019-06-05 12:34:41 -04:00
Kris
be464f753c UX: Lighten OS icons in recently used devices 2019-06-05 10:56:25 -04:00
Robin Ward
ad876880e1 FIX: Ember was raising an error without a .set here 2019-06-05 10:23:39 -04:00
Joffrey JAFFEUX
0082a57718
REFACTOR: computed lib (#7702) 2019-06-05 15:50:22 +02:00
Joffrey JAFFEUX
f506843074
REFACTOR: user route (#7704) 2019-06-05 13:05:27 +02:00
Joffrey JAFFEUX
1178f4865b
REFACTOR: login-method model (#7703) 2019-06-05 12:35:41 +02:00
Joffrey JAFFEUX
80459d83a4
REFACTOR: discourse-location lib (#7700) 2019-06-05 11:46:36 +02:00
Joffrey JAFFEUX
faef660631
REFACTOR: invite model (#7699) 2019-06-05 11:24:06 +02:00
Joffrey JAFFEUX
df6d46b235
FIX: regression and attempts to have clearer naming (#7701) 2019-06-05 11:23:30 +02:00
Joffrey JAFFEUX
0fd7f74664
REFACTOR: post model (#7659) 2019-06-05 11:04:35 +02:00
Joffrey JAFFEUX
69f75b2a81
REFACTOR: preferences/account controller (#7698) 2019-06-05 10:37:51 +02:00
Bianca Nenciu
b2b66d645b UX: Move archive button in topic controls dropdown (mobile view). (#7681) 2019-06-05 11:30:06 +10:00
Joffrey JAFFEUX
f03a547a89
REFACTOR: topic-entrance component (#7694) 2019-06-04 17:50:02 +02:00
Joffrey JAFFEUX
6de3824b46
REFACTOR: group model (#7692) 2019-06-04 17:41:46 +02:00
Joffrey JAFFEUX
68147cedd1
REFACTOR: username-validation mixin (#7693) 2019-06-04 17:41:33 +02:00
Joffrey JAFFEUX
7b19e63ce7
REFACTOR: badge model (#7690) 2019-06-04 17:12:02 +02:00
Kris
1bca6fdf51 UX: Z-index fix for preview on iOS 2019-06-04 11:08:49 -04:00
Penar Musaraj
e66024bd3b Update theme component URL 2019-06-04 10:04:27 -04:00
Joffrey JAFFEUX
4201329f1e
REFACTOR: topic-from-params route (#7689) 2019-06-04 15:51:22 +02:00
Maja Komel
87bf0ec7ae
FIX: fix locale key 2019-06-04 13:35:17 +02:00
Guo Xiang Tan
fcb7422213 DEV: Avoid hard-coding notification types integer in client side code. 
Co-authored-by: Bianca Nenciu <nenciu.bianca@gmail.com>
 2019-06-04 17:30:46 +08:00
Joffrey JAFFEUX
9585a16264
FIX: ensures correct i18n key is used (#7686) 2019-06-04 11:22:44 +02:00
Joffrey JAFFEUX
4283281397
FIX: ensures we have data to compute average (#7685) 2019-06-04 11:21:55 +02:00
Joffrey JAFFEUX
b79d02ff48
FEATURE: displays average for 2 columns tables which support average 2019-06-04 11:08:26 +02:00
Maja Komel
c9a34aa10c FIX: add title attribute for notifications 2019-06-04 17:02:12 +08:00
Joffrey JAFFEUX
497a1d2d9f
FEATURE: uses native date picker on mobile (#7541) 2019-06-04 10:44:55 +02:00
Joffrey JAFFEUX
c4419b7369
REFACTOR: badge-selector component (#7683) 2019-06-04 10:30:56 +02:00
Maja Komel
2863e7c181 FIX: fix select badge as user title on badge page (#7682) 2019-06-04 18:19:30 +10:00
Guo Xiang Tan
1991af2abb DEV: Switch InlineUploads to a regexp based implementation. 2019-06-04 15:54:25 +08:00
Joffrey JAFFEUX
0c5498c9a4
REFACTOR: exception controller (#7675) 2019-06-03 23:34:23 +02:00
Régis Hanol
b792db9d92 FIX: redirect to top was always redirecting to 'All' 2019-06-03 20:18:14 +02:00
Kris
9a3dd6b59a UX: Add missing classes to user preferences 2019-06-03 13:35:40 -04:00
Kris
d4f6b9e827 FIX: Crawler footer style needed to be more specific 2019-06-03 11:52:20 -04:00
Penar Musaraj
6834b0a4ba Fix Prettier 2019-06-03 10:54:24 -04:00
Penar Musaraj
16982d2a69
Update UI for wizard themes further reading step (#7669) 2019-06-03 10:47:17 -04:00
Dan Ungureanu
c1e7a1b292 UX: Merge settings related to muted tags. (#7656) 2019-06-03 12:23:23 +10:00
Dan Ungureanu
28dcf445b7 DEV: Pass editor to plugin hook handling composer uploads. (#7673) 2019-06-03 12:07:25 +10:00
Kris
98336de266 UX: Cleanup crawler styles, improve schema.org markup (#7668) 
* Cleaning up crawler styles, improving some schema.org markup

* Cleaning up crawler styles, improving some schema.org markup

* additional styling

* add space for pagination
 2019-06-03 12:03:16 +10:00
romanrizzi
a0a2823536 DEV: Fix indentation 2019-05-31 10:19:19 -03:00
Joffrey JAFFEUX
1db7fd6f9b
REFACTOR: topic-list model (#7658) 2019-05-31 13:15:45 +02:00
Joffrey JAFFEUX
63264158cf
REFACTOR: user-posts-stream model (#7657) 2019-05-31 13:02:15 +02:00
Sam Saffron
3b8819f0ab FEATURE: add support for defer topic functionality 
This feature allows end users to "defer" topics by marking them unread

The functionality is default disabled. This also introduces the new site
setting default_other_enable_defer: to enable this by default on new user
accounts.
 2019-05-31 15:44:35 +10:00
Sam Saffron
077dcc0642 FEATURE: add autocomplete discourse on full page search 
This teaches chrome not to try autocompleting it.
 2019-05-31 10:27:44 +10:00
Roman Rizzi
c169456ee5
DEV: Create new component to reify the user fields (#7655) 2019-05-30 16:17:16 -03:00
Robin Ward
c4fa20d644 FIX: Broken test, also typoed property 2019-05-30 14:27:28 -04:00
Robin Ward
5e89714f77 FIX: Linting via prettier 2019-05-30 13:58:06 -04:00
Robin Ward
7a9e85b1d7 FIX: Don't show the "Flag to delete" message to staff 
If they can't delete, flagging should not either.
 2019-05-30 13:31:40 -04:00
Joffrey JAFFEUX
7a21f78f8c
prettier (#7653) 2019-05-30 17:28:07 +02:00
Joffrey JAFFEUX
0fbbff86ab
REFACTOR: rest model (#7652) 2019-05-30 17:11:17 +02:00
Daniel Waterworth
bfb26b720b FIX: the en_US locale depends on en 2019-05-30 08:46:43 +08:00
romanrizzi
e7ee556e87 Support multi-group user search 2019-05-30 08:45:20 +08:00
Kris
b24938b5ff UX: Minor composer button alignment adjustments, simplification 2019-05-29 14:37:32 -04:00
Joffrey JAFFEUX
c77bc525cb
REFACTOR: new-topic route (#7639) 2019-05-29 16:46:58 +02:00
Joffrey JAFFEUX
ba66d6fd82
FIX: icon deprecation s/group/users (#7638) 2019-05-29 16:29:01 +02:00
Joffrey JAFFEUX
034502af21
FIX: incorrectly removed moveTypes array (#7637) 2019-05-29 16:23:32 +02:00
Joffrey JAFFEUX
bb6337d6c6
REFACTOR: choose-topic component (#7636) 2019-05-29 16:21:13 +02:00
Joffrey JAFFEUX
b2fc80e4b7
REFACTOR: build-topic-selection mixin (#7635) 2019-05-29 16:09:19 +02:00
Joffrey JAFFEUX
468cfa39f7
REFACTOR: rename-tag controller (#7634) 2019-05-29 15:58:12 +02:00
Joffrey JAFFEUX
f2858e03c8
REFACTOR: preferences/email controller (#7633) 2019-05-29 15:53:42 +02:00
Joffrey JAFFEUX
5e7e32510a
FIX: lookup should be done against locale of reference (#7632) 2019-05-29 15:45:44 +02:00
Joffrey JAFFEUX
05206a61ab
FIX: displays text of asset-version changed modal (#7631) 2019-05-29 15:38:14 +02:00
Guo Xiang Tan
f0620e7118 FEATURE: Support [description|attachment](upload://<short-sha>) in MD take 2. 
Previous attempt was missing `post_uploads` records.
 2019-05-29 09:26:32 +08:00
Joffrey JAFFEUX
76569b2018 FIX: ensures post-small-action is using timezone to display dates 2019-05-29 08:45:28 +08:00
Penar Musaraj
a93aa5bbce Add "further reading for themes" step to wizard 2019-05-29 08:28:03 +08:00
Bianca Nenciu
43e33302e1 FIX: Position emoji-picker around d-editor. 2019-05-29 08:27:14 +08:00
Penar Musaraj
7c9fb95c15 Temporarily revert "FEATURE: Support [description|attachment](upload://<short-sha>) in MD. (#7603)" 
This reverts commit b1d3c678ca.

We need to make sure post_upload records are correctly stored.
 2019-05-28 16:37:01 -04:00
Osama Sayegh
f3c07e27d9
FIX: correct translations for logs error rate notice (#7622) 
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.

I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
 2019-05-28 22:10:51 +03:00
Bianca Nenciu
91ff8684fd FIX: Use the right property for post ID. 2019-05-28 22:00:58 +03:00
Kris
67d8ceedf1 Remove unused variable 2019-05-28 14:31:52 -04:00
Kris
c57ab12238 UX: Move preview button to bottom right of mobile composer 2019-05-28 14:19:33 -04:00
Joffrey JAFFEUX
bc14452585
FIX: ensures events have access to correct context (#7621) 2019-05-28 19:40:28 +02:00
Guo Xiang Tan
b1d3c678ca FEATURE: Support [description|attachment](upload://<short-sha>) in MD. (#7603) 2019-05-28 11:18:21 -04:00
Robin Ward
9bdfaa195e FIX: We shouldn't memoize the last time something is read 2019-05-28 10:51:18 -04:00
Joffrey JAFFEUX
6decdfce5c
DEV: reduces memory footprint of tests - step 1 (#7591) 2019-05-28 12:15:12 +02:00
Penar Musaraj
dfcc2e7ad8 Revert "FEATURE: Send notification when member was accepted to group. (#7503)" 
This reverts commit 42c82d544e.
 2019-05-27 15:19:59 -04:00
Penar Musaraj
c108131ad4 Revert "Fix JS error in group summary notification message" 
This reverts commit b1268e00b8.
 2019-05-27 15:19:38 -04:00
Penar Musaraj
b1268e00b8 Fix JS error in group summary notification message 2019-05-27 14:54:51 -04:00
Robin Ward
d95a68b837 FEATURE: When suspending a user, allow the Delete + Replies action 
Previously you could only delete the post
 2019-05-27 12:27:16 -04:00
Joffrey JAFFEUX
192562745f
DEV: uses focus helper for d-editor tests (#7610) 2019-05-27 17:31:11 +02:00
Bianca Nenciu
42c82d544e
FEATURE: Send notification when member was accepted to group. (#7503) 2019-05-27 17:28:41 +03:00
Joffrey JAFFEUX
395f0ca126
FIX: attempts to prevent stacked-chart from being cut off (#7608) 2019-05-27 15:43:27 +02:00
Bianca Nenciu
e284b6e075
FIX: Update tags on change. (#7581) 2019-05-27 16:04:26 +03:00
Joffrey JAFFEUX
d93f753b17
apply prettier on gigantic find and replace (#7604) 2019-05-27 10:42:53 +02:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 (#7592) 2019-05-27 10:15:39 +02:00
Dan Ungureanu
da39d66e83
DEV: Improve support for plugins. (#7332) 
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
 2019-05-25 16:53:03 +03:00
Joffrey JAFFEUX
6398ded798 Revert "FIX: ensures selection is lookedup into async content (#7586)" 
This reverts commit c238f0d223.
 2019-05-25 15:50:41 +02:00
Robin Ward
4b796eebe0 UX: Try tweaking how soon images are lazily loaded 2019-05-24 15:52:48 -04:00
Kris
dbd14a805c UX: Wrap long names on user admin page 2019-05-24 13:39:16 -04:00
Penar Musaraj
963f6fbd40 Add icon for "Move to Inbox" footer button 2019-05-24 11:53:14 -04:00
Osama Sayegh
e20c30987c
FEATURE: detect theme errors and catch them (#7589) 
* FEATURE: detect theme errors and catch them

* Bump COMPILER_VERSION

* Feedback

* Override eslint no console for one line

* Can't use our ajax method

* remove emoji from translation file
 2019-05-24 17:25:55 +03:00
Joffrey JAFFEUX
049561ac49
FIX: introduces onSelectAny (regroup onSelect and onSelectNone) (#7594) 2019-05-24 13:11:33 +02:00
Gerhard Schlager
c1e9a70d59 FIX: Fallback locale was not available for extra translations 
Translations from fallback locales were not sent to the client
for admin_js and wizard_js.
 2019-05-24 11:38:26 +02:00
Guo Xiang Tan
1babc3bec6 Follow up to 3388872991. 2019-05-24 09:02:39 +08:00
Kris
3388872991 UX: Separate section for 2FA settings, more consistent layout 2019-05-24 08:58:12 +08:00
Robin Ward
648af78298 FIX: Linting 2019-05-23 12:16:45 -04:00
Robin Ward
f73988acd2 Remove unused computed property. 2019-05-23 12:06:18 -04:00
Robin Ward
e74cd54fc6 REFACTOR: Replace score bonuses with low/med/high priorities 
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
 2019-05-23 11:54:45 -04:00
Joffrey JAFFEUX
30961dd875 Revert "UX: Prevent long names from overflowing on user admin" 
This reverts commit 6207b71c36.
 2019-05-23 16:56:30 +02:00
Régis Hanol
943fdc1762 make eslint happy 2019-05-23 12:51:40 +02:00
Régis Hanol
0cc81f95a5 FIX: popover should use target when no data attributes 2019-05-23 12:41:36 +02:00
Joffrey JAFFEUX
f0a776f05d
FIX: allows scrolling when a lot of categories are used (#7590) 2019-05-23 10:04:53 +02:00
Kris
6207b71c36 UX: Prevent long names from overflowing on user admin 2019-05-22 15:10:09 -04:00
Kris
9f6af5f8a7 UX: Prevent long names from overflowing on user profiles 2019-05-22 15:03:50 -04:00
Kris
881c832a2f UX: Remove padding from empty row 2019-05-22 14:27:17 -04:00
Robin Ward
ca03baf2b2 UX: Hide pending score statuses 2019-05-22 11:26:17 -04:00
Joffrey JAFFEUX
cf63a9bb53
FIX: exception when pressing backspace on empty selection (#7587) 2019-05-22 17:18:46 +02:00
Joffrey JAFFEUX
c238f0d223
FIX: ensures selection is lookedup into async content (#7586) 2019-05-22 17:11:19 +02:00
Joffrey JAFFEUX
40c903ec23
FIX: ie11 exception on new category popup (#7585) 2019-05-22 15:17:28 +02:00
Gerhard Schlager
e224100023 FIX: Don't convert :) into Emoji when emojis or emoji shurtcuts are disabled 2019-05-22 11:44:39 +02:00
Joffrey JAFFEUX
0ed1cfd8d9
FIX: ensures we have an elementFromPoint before using it (#7583) 2019-05-21 21:26:54 +02:00
Joffrey JAFFEUX
236adc9ccb
FIX: shows parent category name in title anchor (#7576) 2019-05-21 08:33:22 +02:00
Osama Sayegh
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales (#7545) 
* Refactor keyboard shortcuts modal to fix RTL locales

* Feedback

* Remove lowercase modifier keys
 2019-05-21 06:39:32 +03:00
Joffrey JAFFEUX
bc8c77723e
FIX: puts focus-event at application level (#7568) 
Also attempts to use simpler and newer APIs
 2019-05-20 13:48:03 +02:00
Gerhard Schlager
b788948985 FEATURE: English locale with international date formats 
Makes en_US the new default locale
 2019-05-20 13:47:20 +02:00
Joffrey JAFFEUX
9bbf421125
FIX: better node check for clickoutside in widgets (#7573) 2019-05-20 12:45:33 +02:00
Joffrey JAFFEUX
0ddfeb9c64
FIX: ensures mousetrap is reset with the application (#7569) 2019-05-20 10:45:31 +02:00
Kris
7eea2e35e4 Upload image preview needs width on desktop 2019-05-17 11:25:35 -04:00
Joffrey JAFFEUX
b05d7042ae
FIX: prevents events on toolbar when in form (#7567) 
If a button is not of type button, pressing enter inside an `<input>` inside a `<form>` without the action attribute will trigger the first available `<button>` as most browsers default the type of an unspecified button to submit.

This commit also prevents d-editor-modal to be filled when it's hidden.
 2019-05-17 11:14:09 +02:00
Guo Xiang Tan
148bfc9be5 DEV: Simplify client and server side code to support removing tags. 
Follow up to 834c86678f.
 2019-05-17 16:39:20 +08:00
David Taylor
5666316285 FEATURE: Display 'last updated' on dashboard, improve release notes link (#7560) 2019-05-17 15:42:45 +10:00
Sam Saffron
25137554ed FIX: _.include is no longer imported from lodash 
Instead use toArray and indexOf which is also clearer
 2019-05-17 08:58:39 +10:00
Kris
80b3560050 IE11: Login form needs full flex shorthand 2019-05-16 14:07:49 -04:00
Joffrey JAFFEUX
ad4d01233b
DEV: attempts to make d-editor tests more resilient (#7556) 2019-05-16 14:42:01 +02:00
Joffrey JAFFEUX
244c03573a
FIX: btn class was duplicated on admin-menu-buttons (#7555) 2019-05-16 14:37:53 +02:00
Joffrey JAFFEUX
0c6ebe66ce
EXPERIMENTAL: clicks outside seem unreliable with absolute nodes (#7557) 2019-05-16 14:37:37 +02:00
Joffrey JAFFEUX
1afe6d0aee
FIX: share-and-invite modal was too narrow (#7559) 2019-05-16 14:37:19 +02:00
Régis Hanol
a5a4f9dc1a
DEV: make prettier happy 
(cc @jjaffeux)
 2019-05-16 11:38:47 +02:00
Joffrey JAFFEUX
d47bf8b6c4
SECURITY: updates lodash from 1.3.0 to 4.17.5 (#7546) 2019-05-16 10:34:19 +02:00
Kris
7cd1067f3d FIX: Select-kit too narrow in topic timer 2019-05-15 17:58:40 -04:00
Régis Hanol
501bee56b7 Make prettier happy 2019-05-15 23:46:50 +02:00
Régis Hanol
db89722a98 UX: ignore leading/trailing whitespaces in site settings search 2019-05-15 22:22:20 +02:00
Bianca Nenciu
b9fcb2bcdf
DEV: Add before button hook in post-menu. (#7550) 2019-05-15 22:48:23 +03:00
Kris
0ef25f7a66 prettier 2019-05-15 13:35:58 -04:00
Kris
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles (#7549) 2019-05-15 13:26:25 -04:00
Maja Komel
9a17b19636 FIX: don't hide back button at the bottom of timeline (#7544) 2019-05-15 19:02:48 +02:00
Joffrey JAFFEUX
d127119549
REFACTOR: user-selector take 2 (#7540) 2019-05-14 09:43:29 +02:00
Régis Hanol
7707d5db2d Revert "REFACTOR: user-selector (#7529)" 
This reverts commit 9a56df89f0.
 2019-05-13 19:39:30 +02:00
Robin Ward
fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts 
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
 2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX
7326ddea6d
REFACTOR: tags mixin (#7533) 2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX
b8db702a02
REFACTOR: admin-user-index route (#7534) 2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX
717aa764b6
FIX: more efficient topic-footer-button-api (#7535) 2019-05-13 17:04:24 +02:00
Penar Musaraj
f1b0782624 UI: Adjust footer nav bar size in iOS app 2019-05-13 10:25:51 -04:00
Joffrey JAFFEUX
df18243827
FIX: prevents exception if report doest define filters (#7532) 2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX
9a56df89f0
REFACTOR: user-selector (#7529) 2019-05-13 13:03:12 +02:00
Joffrey JAFFEUX
e64ed9dbc1
REFACTOR: edit-category controller (#7527) 2019-05-13 11:30:32 +02:00
Joffrey JAFFEUX
9b75320d63
FIX: track mutations on topic edit category-chooser only on select (#7528) 2019-05-13 10:22:28 +02:00
Penar Musaraj
a859ddc77e Improve theme/component delete modal warning 2019-05-10 14:14:12 -04:00
Joffrey JAFFEUX
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases (#7525) 2019-05-10 17:12:10 +02:00
David Taylor
abbe812a0d FIX: Correct CSS for instagram video play icon 2019-05-10 10:46:07 +01:00
Joffrey JAFFEUX
4096d559b5
REFACTOR: user-stream model (#7515) 2019-05-10 10:05:43 +02:00
Joffrey JAFFEUX
a85b7feef4
REFACTOR: composer controller (#7516) 2019-05-10 10:05:29 +02:00
Joffrey JAFFEUX
7aedc92a35
REFACTOR: login-controller (#7514) 2019-05-10 10:05:11 +02:00
Gerhard Schlager
34684af195 FIX: Show error message if message exists 2019-05-09 22:12:51 +02:00
Robin Ward
b380ed5282 FEATURE: Claim Reviewables by Topic 
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
 2019-05-09 13:40:36 -04:00
Bianca Nenciu
ea3004ef11
UX: Save scroll position in tags topic list. (#7511) 2019-05-09 20:39:03 +03:00
Penar Musaraj
2a45933ff2 FIX: reduce iPad app nav padding 2019-05-09 10:25:22 -04:00
Dan Ungureanu
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. (#7509) 2019-05-09 14:08:10 +03:00
Joffrey JAFFEUX
977ffa20f4
FIX: variable is different from key (#7512) 2019-05-09 10:03:33 +02:00
Arpit Jalan
427979e7e5
FEATURE: use full screen login by default for social login methods (#7481) 2019-05-09 10:03:01 +05:30
Guo Xiang Tan
8ec1f8cf07 DEV: Correct naming convention for JS file. 2019-05-09 10:18:29 +08:00
Maja Komel
24ca074f3f FIX: short description title on client side when empty description 
follow-up 77af097c
 2019-05-08 17:07:12 +02:00
Joffrey JAFFEUX
54c2f24ee9
REFACTOR: composer model (#7499) 2019-05-08 16:53:12 +02:00
Joffrey JAFFEUX
4aaee7ee35
REFACTOR: change-timestamp controller (#7498) 2019-05-08 16:26:51 +02:00
Robin Ward
b409dab77f Rename flags_default_topics to reviewable_default_topics 
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
 2019-05-08 10:07:10 -04:00
Maja Komel
77af097ce0 FIX: add short description to title on client side 2019-05-08 15:03:33 +02:00
David Taylor
b717e23ceb FIX: Dynamically adjust scale when rendering wizard canvases 
This was a typo in fd0de64
 2019-05-08 13:14:28 +01:00
Bianca Nenciu
861023f0d6 FIX: Skip attachments in click track. 2019-05-08 11:55:31 +03:00
Guo Xiang Tan
46ea69a73c UX: Initialize client side category model with right search_priority. 
This is strictly a UX change since the default value of the column is 0.
 2019-05-08 14:16:20 +08:00
Robin Ward
5af7c90bab FEATURE: Hide Reviewable scores, change score filter to Priority 
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.

You can now filter by minimum priority (low, med, high) instead of
score.
 2019-05-07 14:05:23 -04:00
Roman Rizzi
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign (#7497) 2019-05-07 12:25:10 -03:00
Penar Musaraj
446ec1b44a
Set input and textarea font size to 16px on iOS (#7480) 2019-05-07 10:44:43 -04:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. (#7430) 2019-05-07 16:25:52 +03:00
Arpit Jalan
ed70595314 UX: add information about the use of permalinks 2019-05-07 17:13:26 +05:30
Bianca Nenciu
71fb8a4195 DEV: Fix failing click-track tests. 2019-05-07 13:54:12 +03:00
Joffrey JAFFEUX
4bbb34f7cb
REFACTOR: admin-user (#7475) 2019-05-07 10:53:21 +02:00
Joffrey JAFFEUX
f73ed45429
REFACTOR: color-scheme model (#7477) 2019-05-07 10:51:52 +02:00
Joffrey JAFFEUX
9507eff927
REFACTOR: resumable-upload (#7474) 2019-05-07 10:51:11 +02:00
Bianca Nenciu
4ff1195537 FEATURE: Use Beacon API for tracking clicks. (#7483) 2019-05-07 16:37:43 +10:00
Joe
cf99431c18 Fix like and flag button count alignment (#7487) 2019-05-07 16:34:29 +10:00
Guo Xiang Tan
abbc639e0d FIX: Only unregister service workers that belongs to Discourse. 2019-05-07 13:08:06 +08:00
Arpit Jalan
03169401ff UX: correct order of site statistics on /about page 2019-05-07 09:50:41 +05:30
Robin Ward
47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Robin Ward
31e100530f FEATURE: Flag count in post menu 
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
 2019-05-06 16:13:31 -04:00
Dan Ungureanu
33e06dd796
FIX: Make select all and below skip small actions. (#7425) 2019-05-06 16:22:11 +03:00
Guo Xiang Tan
8217d5be78 UX: Switch mobile header back for 5s when notification comes in. 2019-05-06 16:58:25 +08:00
Guo Xiang Tan
ba3cf7109c DEV: Remove unused lines of code. 2019-05-06 13:48:51 +08:00
Sam Saffron
267d129f38 FEATURE: only scroll to bottom for discobot 
Non discobot replies on PMs triggering scroll cause confusion.
 2019-05-06 10:55:58 +10:00
Robin Ward
99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Robin Ward
15c9b00307 FEATURE: Show edit indicator on review queue 
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
 2019-05-03 11:21:33 -04:00
Joffrey JAFFEUX
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more (#7473) 
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
 2019-05-03 16:11:03 +02:00
Penar Musaraj
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme (#7443) 2019-05-02 21:43:54 -04:00
Robin Ward
3cb0d27d38 DEV: Upgrade our widget handlebars compiler 
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
 2019-05-02 15:47:57 -04:00
Joffrey JAFFEUX
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn (#7472) 2019-05-02 20:56:27 +02:00
Joffrey JAFFEUX
35212036f2
FIX: ensures click on topic link has link for target and not children (#7471) 2019-05-02 13:43:02 +02:00
Joffrey JAFFEUX
75591664e7
FIX: better handling of category filter deselection (#7468) 2019-05-02 10:03:12 +02:00
Guo Xiang Tan
d5c9ac7196 PERF: Use cdn when serving site settings upload. 2019-05-02 15:35:07 +08:00
Guo Xiang Tan
24347ace10 FIX: Properly associate user_profiles background urls via upload id. 
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
 2019-05-02 14:58:24 +08:00
Joe
5a834a05ea
FIX: crawler layout CSS adjustments (#7469) 
* Fix header size to fit the viewport

Setting the header to border-box means that the padding is factored in when calculating its width. If this is not done, the header width would be 100% of the viewport width + any padding when set on it. That causes some parts of the header to be rendered off-screen and causes horizontal scrolling.

* prevent code in posts from causing horizontal overflow

We are currently not wrapping code in posts in the crawler view. This affects both unformatted code and inline code blocks. This commit forces such code to wrap in order to prevent horizontal overflow which the Google bot complains about since it causes some content to be rendered outside of the viewport for the mobile crawler.
 2019-05-02 13:00:29 +08:00
Sam Saffron
157dc5e298 FEATURE: disable native share API on non tablets/phones 
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
 2019-05-02 13:18:29 +10:00
Arpit Jalan
b5ea50a154
FIX: use full screen login for new-topic route (#7467) 
DEV: add javascript tests for new-topic and new-message routes

DEV: fix an existing test that was being skipped
 2019-05-01 22:54:29 +05:30
Vinoth Kannan
7869a10d18 Revert "FEATURE: Added unlisted topics option to advanced search (#7447)" 
This reverts commit 539723f8ff since it is failing the build.
 2019-05-01 21:06:20 +05:30
Joffrey JAFFEUX
ae493f4722
UX: fills picker with emoji autocomplete state on more click (#7466) 2019-05-01 16:19:45 +02:00
David Taylor
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons (#7372) 
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.

## Core

- Adds an SiteIconManager module which manages automatic resizing and fallback

- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon). 

- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.

- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations

## Wizard

- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload

- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"

- Various copy updates to support the changes

- Remove the "upload-time" resizing for `large_icon`. This is no longer required.

## Site Settings UX

- Move logo/icon settings under a new "Branding" tab

- Various copy changes to support the changes

- Adds placeholder support to the `image-uploader` component

- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings

- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name

## Dashboard Warnings

- Remove PWA icon and PWA title warnings. Both are now handled automatically.

## Bonus

- Updated the sketch logos to use @awesomerobot's new high-res designs
 2019-05-01 14:44:45 +01:00
Arpit Jalan
c6409fd2cc FIX: pass correct date arguments to server when exporting CSV 2019-05-01 10:46:30 +05:30
Arpit Jalan
002e1f560a FIX: initialize empty object if no custom filters are present 2019-05-01 10:27:19 +05:30
Tim Lange
539723f8ff FEATURE: Added unlisted topics option to advanced search (#7447) 2019-05-01 12:31:13 +10:00
Robin Ward
404b35bd04 FEATURE: Category Reviewable by Group 
Allow a group to review content in a particular category.
 2019-04-30 15:23:06 -04:00
Robin Ward
dd29af4475 REFACTOR: {{avatar}} and {{date}} helpers in vdom templates 
This is a step towards a nicer flag display under posts.
 2019-04-30 15:22:38 -04:00
Roman Rizzi
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin (#7433) 2019-04-30 15:36:54 -03:00
David Taylor
583226d295 FIX: Linking to /new-topic from /latest 
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.

This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.

Unfortunately I have not been able to reproduce the issue in a QUnit test.
 2019-04-30 16:25:25 +01:00
Joffrey JAFFEUX
8e68244eea
FIX: prevents google to track certain pages (#7463) 2019-04-30 15:57:51 +02:00
Joffrey JAFFEUX
726dd0fe37 Revert "FIX: prevents google to track certain pages (#7455)" 
This reverts commit c863e62998.
 2019-04-30 10:17:12 +02:00
Joffrey JAFFEUX
c863e62998 FIX: prevents google to track certain pages (#7455) 2019-04-30 13:59:55 +08:00
Guo Xiang Tan
dca7f8ecf2 FIX: Loading more broken on groups page. 
Regressed in 1f17d52f55.
 2019-04-30 10:35:17 +08:00
Neil Lalonde
a00354f11f Prettier site-settings/group-list.js.es6 2019-04-29 16:26:13 -04:00
Neil Lalonde
1ba72ccab8 DEV: add site setting type group_list for a list of groups 
Add a js test
 2019-04-29 16:15:22 -04:00
Penar Musaraj
bfadb1fabc FIX: use more specific target for ".tag-box" 
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
 2019-04-29 13:55:40 -04:00
Penar Musaraj
b75720d911 FIX: skip click-tracking for mentions 2019-04-29 12:05:47 -04:00
Joffrey JAFFEUX
5768011cad
FIX: prevents exception in the composer with regexp flags 2019-04-29 16:58:17 +02:00
Penar Musaraj
629ae7a5b7 FIX: Revert tracking links in quotes 2019-04-29 10:30:04 -04:00
Bianca Nenciu
aef35faefc FIX: Open links in external tabs. (#7444) 2019-04-29 10:27:29 -04:00
Penar Musaraj
ca9fd95a08 FIX: Respect "open external links in new window" in quotes and edit history 2019-04-29 10:13:53 -04:00
Joffrey JAFFEUX
286f2abc65
FIX: prevents exception when clicking directly on site text 2019-04-29 12:07:30 +02:00
Tim Lange
574f39f9d0 FIX: Fixed uploadPlaceholder regex failing on not escaped characters (#7442) 2019-04-29 12:32:48 +10:00
Joffrey JAFFEUX
6952510fc4
FIX: restores skipHeader computed property 2019-04-26 23:43:49 +02:00
Tim Lange
1486328756 UX: Changed post stream placeholder to animation (#7434) 2019-04-26 17:29:48 +01:00