Jeff Atwood
03e98164cb
copyedit, remove needless colons
2019-05-28 00:15:47 -07:00
Sam Saffron
3d2c3bd478
FIX: username suggester incorrectly skipping over whitelisted username
...
SSO uses a special param to username suggester that whitelists a username
due to previous work we amended our lookup logic and started ignoring this
whitelist.
The fix ensures we always respect it, and also improves on the original
implementation that forgot to normalize the username.
2019-05-28 16:48:46 +10:00
Ralph Rooding
0d9fdbf8fe
FEATURE: Allow import of hidden site settings ( #7601 )
...
* Allow optional import of hidden site settings
* Always import hidden settings
2019-05-28 16:20:18 +10:00
Rafael dos Santos Silva
315a38e0e3
FEATURE: Allow running message_bus in a different redis instance ( #7616 )
...
Adds `DISCOURSE_MESSAGE_BUS_REDIS_ENABLED` env var, that when set
to true, will allow Discourse to connect to a different redis
instance for MessageBus needs.
When enabled you can configure the same env vars user for redis,
but prefixed by `MESSAGE_BUS`, eg:
`DISCOURSE_MESSAGE_BUS_REDIS_HOST`
2019-05-28 15:52:43 +10:00
Sam Saffron
9a232e1a0a
FEATURE: use GIVE_UP=1 to inform rake posts:missing_uploads you are done
...
We need this give up for cases where uploads can not be recovered
This also improves the recovery routines
2019-05-28 14:44:59 +10:00
Guo Xiang Tan
909ec47ada
DEV: Close modal so other JS tests don't randomly failed.
2019-05-28 11:40:21 +08:00
Guo Xiang Tan
c80ab08e48
DEV: Fix pretenders leaking across acceptance test.
2019-05-28 10:41:22 +08:00
Sam Saffron
c780d36ddc
DEV: Correct posts:recover_uploads_from_index
...
Was creating a blank index file by mistake
2019-05-28 12:39:39 +10:00
Sam Saffron
3de8c58134
DEV: clean up backup maxmind path
...
This follows up on 6580025a
reuses a list and removes a map that was erronuously there.
2019-05-28 11:47:58 +10:00
Sam Saffron
769501c63a
FIX: exception which was meant to be ignored and logged was failing
...
Thanks to Darix!
2019-05-28 11:45:12 +10:00
Sam Saffron
a02a7d66a9
DEV: properly clean up temp files in FileHelper spec
...
Followup to 74297003
, also noticed other specs were not properly cleaning
up so fixed that as well.
2019-05-28 11:33:08 +10:00
Sam Saffron
7429700389
FIX: ensure we can download maxmind without redis or db config
...
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
Sam Saffron
e4e2acf148
FIX: rake maxminddb:get broke cause it required environment
2019-05-28 08:59:28 +10:00
Joffrey JAFFEUX
ec02696fa2
DEV: introduces coding style spec ( #7615 )
2019-05-27 23:38:17 +02:00
Robin Ward
b85fa62882
FIX: Don't send replies to flags that are ignored by expiry
...
The `AutoQueueHandler` will ignore really old flags. In that case, don't
notify the user that the moderator is looking into it. They probably
never saw it because it didn't meet the reviewable minimum priority.
2019-05-27 17:24:36 -04:00
Régis Hanol
9568f25882
TYPO: punctiation -> punctuation
...
Thanks to @yarons.
2019-05-27 22:57:23 +02:00
Robin Ward
03b4131933
FIX: When deleting a user via queued posts, block urls, ip and email
2019-05-27 15:54:01 -04:00
Robin Ward
d26c4509ea
FIX: Adding a user to a group twice under concurrency
...
This prevents an error from being raised / logged.
2019-05-27 15:42:40 -04:00
Penar Musaraj
dfcc2e7ad8
Revert "FEATURE: Send notification when member was accepted to group. ( #7503 )"
...
This reverts commit 42c82d544e
.
2019-05-27 15:19:59 -04:00
Penar Musaraj
c108131ad4
Revert "Fix JS error in group summary notification message"
...
This reverts commit b1268e00b8
.
2019-05-27 15:19:38 -04:00
Penar Musaraj
b1268e00b8
Fix JS error in group summary notification message
2019-05-27 14:54:51 -04:00
Robin Ward
d95a68b837
FEATURE: When suspending a user, allow the Delete + Replies action
...
Previously you could only delete the post
2019-05-27 12:27:16 -04:00
Joffrey JAFFEUX
192562745f
DEV: uses focus helper for d-editor tests ( #7610 )
2019-05-27 17:31:11 +02:00
Joffrey JAFFEUX
669bfaba30
DEV: setTextareaSelection helper ( #7609 )
2019-05-27 16:33:27 +02:00
Bianca Nenciu
42c82d544e
FEATURE: Send notification when member was accepted to group. ( #7503 )
2019-05-27 17:28:41 +03:00
Dan Ungureanu
6bd082feab
FIX: Update mapping between locales and Postgres dictionaries. ( #7606 )
2019-05-27 16:52:09 +03:00
Joffrey JAFFEUX
395f0ca126
FIX: attempts to prevent stacked-chart from being cut off ( #7608 )
2019-05-27 15:43:27 +02:00
Joffrey JAFFEUX
a2d7eab31d
DEV: more reliable d-editor test ( #7607 )
2019-05-27 15:41:55 +02:00
Robin Ward
912f1d83ac
UX: Adjust text a little more
2019-05-27 09:06:46 -04:00
Bianca Nenciu
e284b6e075
FIX: Update tags on change. ( #7581 )
2019-05-27 16:04:26 +03:00
Joffrey JAFFEUX
b98b994fe7
apply prettier on plugins ( #7605 )
2019-05-27 11:06:11 +02:00
Joffrey JAFFEUX
d93f753b17
apply prettier on gigantic find and replace ( #7604 )
2019-05-27 10:42:53 +02:00
Blake Erickson
373b8a2139
FIX: Consistently handle category param
...
See https://meta.discourse.org/t/api-post-to-posts-json-inconsistent-between-users/118571
for more info.
This commit removes a 5 year old temporary fix that is no longer needed.
bc1824a6ed (diff-d8c648926664f849aec050757bfcb6f9R72)
The web interface uses category_id when creating a topic so I think we
should unify on category_id when using the api.
2019-05-27 16:39:56 +08:00
Joffrey JAFFEUX
bfea922167
DEV: global s/this.get\("(\w+)"\)/this.$1 ( #7592 )
2019-05-27 10:15:39 +02:00
Sam Saffron
170c66c190
DEV: correct flaky test, insufficient timeout
...
In some cases with all the new mitigations the 10ms delay is no longer
enough. Wait up to 1 second here instead.
2019-05-27 17:08:35 +10:00
Sam Saffron
6580025af9
FEATURE: add backup directory for mmdb files
...
This new `DISCOURSE_MAXMIND_BACKUP_PATH` can be used a secondary location
for maxmind db. That way a build machine, for example can cache it on the
host and reuse between builds.
Also per 5bfeef77
added proper error raising for download fails from
dedicated rake task
This also moves "refresh_maxmind_db_during_precompile_days" to a global
setting, it did not make sense in a site setting
2019-05-27 16:51:24 +10:00
Osama Sayegh
169cc56bed
Copyedit for broken theme alert
2019-05-27 07:25:39 +03:00
Guo Xiang Tan
f54e4b71b1
DEV: Make CookedPostProcessor#post_process_images
method private.
2019-05-27 11:28:37 +08:00
Jeff Atwood
baf7eac704
make privacy/terms on signup form open in new tab
2019-05-26 00:46:37 -07:00
Dan Ungureanu
da39d66e83
DEV: Improve support for plugins. ( #7332 )
...
* DEV: Allow NewPostManager handlers handle PMs.
* DEV: Add custom fields topic option to PostCreator.
* DEV: Add topic_id to serializer data.
* DEV: Wrap topic title from notification item in a span.
2019-05-25 16:53:03 +03:00
Joffrey JAFFEUX
6398ded798
Revert "FIX: ensures selection is lookedup into async content ( #7586 )"
...
This reverts commit c238f0d223
.
2019-05-25 15:50:41 +02:00
Régis Hanol
d6aacadc4e
make 🤖 happy
2019-05-25 00:32:29 +02:00
Régis Hanol
4e5305cb67
FIX: catch proper exception
2019-05-25 00:14:54 +02:00
Michael Brown
5bfeef7705
FIX: warn instead of excepting if MaxMind DBs can't be downloaded ( #7600 )
2019-05-25 00:08:00 +02:00
Régis Hanol
3bc99e5372
FIX: gunzip the downloaded file
2019-05-25 00:02:23 +02:00
Michael Brown
14c7aa8829
FIX: gz_file might be nil here
2019-05-24 16:11:10 -04:00
Robin Ward
0725b614c9
UX: Better language about sensitivity
2019-05-24 16:02:00 -04:00
Robin Ward
4b796eebe0
UX: Try tweaking how soon images are lazily loaded
2019-05-24 15:52:48 -04:00
Robin Ward
1e72f44c01
Tweak the default sensitivities
2019-05-24 15:49:29 -04:00
Robin Ward
89b84651c3
Migrate score settings to use sensitivities
...
We hide scores so these settings no longer made sense.
2019-05-24 15:44:24 -04:00