We can't enable `Rails/WhereNot` lint/autofix, because it would break
code that uses mini_sql instead of AR (which rubocop, and tbh also we,
can't easily differentiate)
Those are safe because they either:
* are executed in AR model scope definitions
* are clearly chained starting from a AR model
* are less-clearly chained, but still can be traced to a AR model/scope
---------
Co-authored-by: Loïc Guitaut <loic@discourse.org>
Zeitwerk simplifies working with dependencies in dev and makes it easier reloading class chains.
We no longer need to use Rails "require_dependency" anywhere and instead can just use standard
Ruby patterns to require files.
This is a far reaching change and we expect some followups here.
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
in the past new topics were not prioritizing current category and
new topics in a category were not being inserted before other unread topics
in other categories
Jarek RadoszandLoïc Guitaut
Mark VanLandingham
David Taylor
Krzysztof Kotlarek
Sam Saffron
Guo Xiang Tan
Guo Xiang Tan
Arpit Jalan
Robin Ward
Neil Lalonde
Stephan Kaag