IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity
38,086 Commits 186 Branches 505 Tags
b28d97b64a2dbe8c923acf1d3df5d277d1d136c5
Commit Graph

7844 Commits

Author SHA1 Message Date
Régis Hanol
91c89df68a FIX: onebox local topic when using slug-less URL 
When linking to a topic in the same Discourse, we try to onebox the link to show the title
and other various information depending on whether it's a "standard" or "inline" onebox.

However, we were not properly detecting links to topics that had no slugs (eg. https://meta.discourse.org/t/1234).
 2020-06-23 17:18:38 +02:00
David Taylor
c5078e5dc1 DEV: Remove accidentally committed puts statements 2020-06-23 12:41:47 +01:00
Martin Brennan
e92909aa77 FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition (#10108) 
See https://meta.discourse.org/t/broken-pipe-error-when-uploading-to-a-s3-clone-a-pdf-with-a-name-containing-e-i-etc/155414

When setting content-disposition for attachment, use the ContentDisposition class to format it. This handles filenames with weird characters and localization (accented characters) correctly.
 2020-06-23 17:10:56 +10:00
Guo Xiang Tan
add2a9411e DEV: Remove specs that are no longer relevant. 2020-06-23 12:09:04 +08:00
Guo Xiang Tan
25db91e351 Revert "FIX: These tests are broken" 
This reverts commit b1114b9a20.
 2020-06-23 08:41:10 +08:00
Robin Ward
b1114b9a20 FIX: These tests are broken 2020-06-22 16:30:46 -04:00
Robin Ward
ac9577bcc7 FIX: Don't raise an exception if we can't update the user on demotion 
This is causing issues when purging old users, if they are set up in the
exact condition where they will be demoted into another group, but also
do not have a primary email.
 2020-06-22 15:43:59 -04:00
Bianca Nenciu
68f767a557 FEATURE: Check if selectable avatars exist before enabling them (#10032) 2020-06-22 16:58:26 +03:00
Bianca Nenciu
685646540a FIX: Hide PM tags if the site setting is disabled (#10089) 
* FIX: Hide PM tags if the site setting is disabled

* Apply code suggestions
 2020-06-22 16:48:24 +03:00
Guo Xiang Tan
8cc8e80d7a Fix the build. 2020-06-22 14:50:17 +08:00
Guo Xiang Tan
3370ef188e FEATURE: Remove deprecated uploads url site settings. 
The site settings have been replaced with direct image upload since
Discourse 2.3.
 2020-06-22 14:32:29 +08:00
David Taylor
17c4f76eac FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled (#10091) 2020-06-19 20:21:05 +01:00
Jarek Radosz
58a5293d9b FIX: Delete PostUploads on Post deletion (#10090) 
Related uploads will then be removed by Jobs::CleanUpUploads
 2020-06-19 17:45:08 +02:00
Robin Ward
4a2871f7f6 FEATURE: Don't display muted/ignored users under "who liked" (#10084) 
* FEATURE: Don't display muted/ignored users under "who liked"

Previously, if you clicked on the heart icon below a post
it would show you the avatar for a user even if you ignored or muted
them.

This commit will instead display a (?) icon. The count of likes will
remain correct, but you needn't be reminded of the person you
preferred not to see.

* Use a circle instead of (?) for unknown user
 2020-06-19 10:44:21 -04:00
David Taylor
a99bb0ded4 Revert "FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled" 
This changed cause plugin spec failures and needs further investigation

This reverts commit 78626d2832.
 2020-06-19 14:39:16 +01:00
David Taylor
9f2e7e4651 FIX: Handle invalid URLs gracefully when pulling hotlinked images 2020-06-19 12:52:51 +01:00
David Taylor
78626d2832 FIX: Do not attempt to pull_hotlinked on emoji images when CDN enabled 2020-06-19 12:45:06 +01:00
Daniel Waterworth
9cf77372a2 FIX: Guardian#can_remove_allowed_users? shouldn't break for ownerless topics 
A topic can outlive its original author. TopicGuardian should still work
in this situation.
 2020-06-19 10:35:52 +01:00
Vinoth Kannan
ae47bcb269 DEV: move user references deletion code to before_destroy. (#10085) 
Moving the `delete_source_user_references` method code from user merger service to user model.
 2020-06-18 17:42:39 -04:00
Bianca Nenciu
a1df68d4c4 FIX: Do not change tracked categories for staged users (#10076) 2020-06-18 21:09:54 +03:00
Cassius
d13d5e2b99 FIX: Allow multiple hyphens in host (#10078) 
* FIX: Allow multiple hyphens in host

* FIX: added spec for multiple hyphens
 2020-06-18 13:58:47 -04:00
Robin Ward
494a27dc27 FIX: A much nicer error message if you can't ignore/mute a user 2020-06-18 13:41:27 -04:00
Bernhard Suttner
e31471585a DEV: allow to have duplicate topic titles if categegory is different (#10034) 
Co-authored-by: Robin Ward <robin.ward@gmail.com>

Co-authored-by: Robin Ward <robin.ward@gmail.com>
 2020-06-18 11:19:47 -04:00
Bianca Nenciu
db1bebddce FIX: Hide the post history for TL4 (#10065) 2020-06-18 13:27:51 +03:00
Dan Ungureanu
d21a08c284 DEV: Deprecate Category#url_with_id in favor of Category#url (#9972) 2020-06-18 11:32:14 +03:00
Joffrey JAFFEUX
75991a249e fix spec (#10069) 2020-06-18 09:02:08 +02:00
Dan Ungureanu
79ab1493c8 DEV: Add test (#10066) 
Follow-up-to f1b97202d4
 2020-06-17 21:41:29 +03:00
Dan Ungureanu
7ed7b1ef64 DEV: Add test (#10064) 
Follow-up-to 84dfaad137
 2020-06-17 21:41:16 +03:00
Dan Ungureanu
a60a67c431 FIX: Show unconfirmed emails too when checking emails (#10062) 
When checking emails through user preferences, it did not display the
unconfirmed emails.
 2020-06-17 21:41:01 +03:00
Robin Ward
e8756e1a95 FIX: Muted/Ignore should prevent PMs regardless of case sensitivity 2020-06-17 14:26:14 -04:00
Joffrey JAFFEUX
9518d6b587 fix spec (#10061) 2020-06-17 15:10:07 +02:00
David Taylor
6caad5c083 FIX: Do not send staff welcome message if user already has role 2020-06-17 12:12:55 +01:00
Joffrey JAFFEUX
9da3a7f436 FEATURE: allows published pages to be public (#10053) 2020-06-17 12:42:20 +02:00
Martin Brennan
e5da2d24e5 FIX: Add attachment content-disposition for all non-image files (#10058) 
This will make it so the original filename is used when downloading all non-image files, bringing S3Store into line with the to_s3 migration and local storage. Video and audio files will still stream correctly in HTML players as well.

See https://meta.discourse.org/t/cannot-download-non-image-media-files-original-filenames-lost-when-uploaded-to-s3/152797 for a lot of extra context.
 2020-06-17 11:16:37 +10:00
Martin Brennan
b62ad003ce Always require pry gems in rails_helper 
* remove IMPROVED_SPEC_DEBUGGING env var guard
 2020-06-17 10:08:53 +10:00
Jarek Radosz
669c940ec3 Revert "DEV: Remove the remaining ENV["TRAVIS"] usage (#10041)" 
This reverts commit 78aff841e3.

See https://review.discourse.org/t/dev-remove-the-remaining-env-travis-usage-10041/12737/4?u=cvx
 2020-06-16 19:42:00 +02:00
Jarek Radosz
78aff841e3 DEV: Remove the remaining ENV["TRAVIS"] usage (#10041) 2020-06-16 17:41:15 +02:00
Gerhard Schlager
859d9b75a7 FIX: Restoring backup from PG12 could fail on PG10 
The `EXECUTE FUNCTION` syntax for `CREATE TRIGGER` statements was introduced in PostgreSQL 11. We need to replace `EXECUTE FUNCTION` with `EXECUTE PROCEDURE` in order to be able to restore backups created with PG12 on PG10.
 2020-06-16 16:04:14 +02:00
Krzysztof Kotlarek
6258406419 FIX: secondary_emails, unconfirmed_emails, group_users are private fields 
Those fields should be only visible to the user.
 2020-06-16 12:46:27 +03:00
Arpit Jalan
a94387c088 FIX: check for inviter group permissions at the time of redeeming invite 2020-06-15 14:44:35 +05:30
Guo Xiang Tan
58e52c0e4f DEV: Use rails_failover gem for ActiveRecord and Redis failover handling 2020-06-15 15:47:07 +08:00
Guo Xiang Tan
0ff86b00cb DEV: Upgrade Redis to 4.2.1. 2020-06-15 10:05:22 +08:00
Joffrey JAFFEUX
4b793a1072 FIX: allows PM owner to remove any user if >= TL2 (#10036) 2020-06-12 12:54:28 +02:00
Guo Xiang Tan
3aab98781a Fix tests. 2020-06-12 10:22:22 +08:00
Jarek Radosz
3d55f2e3b7 FIX: Improvements and fixes to the image downsizing script (#9950) 
Fixed bugs, added specs, extracted the upload downsizing code to a class, added support for non-S3 setups, changed it so that images aren't downloaded twice.

This code has been tested on production and successfully resized ~180k uploads.

Includes:

* DEV: Extract upload downsizing logic
* DEV: Add support for non-S3 uploads
* DEV: Process only images uploaded by users
* FIX: Incorrect usage of `count` and `exist?` typo
* DEV: Spec S3 image downsizing
* DEV: Avoid downloading images twice
* DEV: Update filesizes earlier in the process
* DEV: Return false on invalid upload
* FIX: Download images that currently above the limit (If the image size limit is decreased, then there was no way to resize those images that now fall outside the allowed size range)
* Update script/downsize_uploads.rb (Co-authored-by: Régis Hanol <regis@hanol.fr>)
 2020-06-11 14:47:59 +02:00
Dan Ungureanu
b7e70850e4 FIX: Allow users to add emails which were deleted before 2020-06-11 14:54:11 +03:00
Sam Saffron
a26b490047 FIX: present correct new/unread counts when filtered by tag 
Previously we would incorrectly ignore tags.

This ensures tracking state is properly shipped to client if
show_filter_by_tag is enabled.
 2020-06-11 16:47:57 +10:00
Blake Erickson
1ce6ff0a55 DEV: Include raw in post webhook serializer 
This came in as a request on meta to include the raw field in the post
webhook serializer.

 https://meta.discourse.org/t/-/49045/55?u=blake

 Including this field can prevent needing to make a 2nd API request to
 get the raw field of a post.

 It would be handy down the road if we updated the webhook ui to specify
 fields or arguments that you wanted to be included in the serialized
 data, but most requests I've seen to update the serializers have been
 valid requests that are good to add anyways, so I don't think we have
 reached that point yet.
 2020-06-10 11:56:39 -06:00
Dan Ungureanu
5bfe1ee4f1 FEATURE: Improve UX support for multiple email addresses (#9691) 2020-06-10 19:11:49 +03:00
Dan Ungureanu
3a7ca97c36 FIX: Use include-subcategories filter in report export (#10007) 
Some filters were renamed and the conversion of the filter names and arguments
was removed.
 2020-06-10 18:57:39 +03:00