Osama Sayegh
bd709c89a7
FIX: Unsubscribe from topic presence when navigating between topics ( #12198 )
...
This PR fixes a bug where if you navigate from topic to another one (via suggested topics, notifications etc.), the previous topic is not unsubscribed from presence manager, which means if you visit lots of topics all the subscriptions will accumulate and can cause rate limit errors.
This bug is exposed by the loading slider we're currently experimenting with on Meta because we no longer have an intermediate state when navigating between topics which means the `willDestroyElement` hook that's responsible for unsubscribing is not called.
2021-02-24 23:14:38 +03:00
Discourse Translator Bot
2757003ef1
Update translations ( #12186 )
2021-02-23 15:10:04 +01:00
Discourse Translator Bot
f283bde25a
Update translations ( #12097 )
2021-02-16 15:24:37 +01:00
Discourse Translator Bot
b3fa521bf4
Update translations ( #12019 )
2021-02-09 14:56:15 +01:00
Discourse Translator Bot
3c028cb67f
Update translations ( #11848 )
2021-01-26 14:52:35 +01:00
Discourse Translator Bot
0e8c155b70
Update translations ( #11779 )
2021-01-20 22:58:26 +01:00
Discourse Translator Bot
0e8e3f4813
Update translations ( #11689 )
2021-01-12 14:29:05 +01:00
Discourse Translator Bot
09f9d4b281
Update translations ( #11601 )
2020-12-29 19:44:53 +01:00
Discourse Translator Bot
e113ddc73c
Update translations ( #11557 )
2020-12-22 14:49:40 +01:00
Discourse Translator Bot
47fa3cf864
Update translations ( #11492 )
2020-12-15 15:25:10 +01:00
Roman Rizzi
bbe5d8d5cf
DEV: Sort imports alphabetically ( #11382 )
2020-12-01 15:31:26 -03:00
Discourse Translator Bot
d7bd9aa3d0
Update translations ( #11385 )
2020-12-01 14:34:25 +01:00
Discourse Translator Bot
7fecad41db
Update translations ( #11264 )
2020-11-17 14:49:58 +01:00
Discourse Translator Bot
9904a007c5
Update translations ( #11182 )
2020-11-10 15:23:06 +01:00
Discourse Translator Bot
886d619d3f
Update translations ( #11108 )
2020-11-03 18:08:07 +01:00
Discourse Translator Bot
9648122b51
Update translations ( #11042 )
2020-10-27 15:36:21 +01:00
Discourse Translator Bot
b5933e2b49
Update translations ( #10970 )
2020-10-20 15:34:57 +02:00
Discourse Translator Bot
7eef10c6d7
Update translations ( #10944 )
2020-10-17 00:07:21 +02:00
Gerhard Schlager
7adf71a203
Fix i18n issues reported on Crowdin ( #10925 )
...
* Pluralize `discourse_narrative_bot.dice.not_enough_dice`
The number of dice requires a pluralized string.
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/278/en-ar#51346
* Always use "two-factor" instead of "second factor" or "two factor"
Using different terms for the same thing is quite confusing.
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-nl#40096
* Remove whitespace before ellipsis for consistency
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-nl#53978
* Remove unused strings from locale file
* Correct grammar in `site_settings.review_media_unless_trust_level`
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#54018
* Correct grammar in `reviewables.reasons.contains_media`
Fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#54020
* Correct grammar in user notifications
It also adds a link to the /about page in order to give the user a clue who the site admins are.
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#54084
* Use "log in" instead of "login" when it's a verb
This fixes multiple issues:
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-nl#40940
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#47858
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-nl#49458
* Replace "Github" with "GitHub"
* Remove "discourse.org" from title of 503 error page
* Replace weirdly formatted multi line string
* Pluralize `js.composer.group_mentioned_limit`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41158
* Remove unused string and pluralize `js.topic.feature_topic.confirm_pin_globally`
This kinda fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42114 as `js.topic.feature_topic.confirm_pin` wasn't used anymore.
* Pluralize `js.user.second_factor_backup.remaining_codes`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#40054
* Pluralize `js.composer.error.tags_missing`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41184
* Pluralize `js.post.errors.too_many_dragged_and_dropped_files`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42408
* Remove unused `js.posts_long` and `js.likes_long`
This fixes the following issues in an unexpected way:
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42974
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#42994
* Pluralize `js.bootstrap_mode_enabled`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#38726
* Remove unused `long_form` from `post_action_types`
This more or less fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/248/en-ar#47158
* Pluralize `js.presence.replying` and `js.presence.replying`
This fixes the following issues:
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/282/en-ar#51588
* https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/282/en-ar#51590
* Pluralize `js.user.second_factor_backup.manage`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#40044
* Stop using concatenated strings for "Recently Used Devices"
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#40308
* Pluralize `js.category_row.topic_count`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41056
* Pluralize `js.select_kit.invalid_selection_length`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41072
* Pluralize `js.notifications.membership_request_consolidated`
This fixes https://discourse.crowdin.com/translate/f3230e7607a36bb0a2f97fd90605a44e/246/en-ar#41416
2020-10-16 15:24:58 +02:00
Discourse Translator Bot
85894537b1
Update translations
2020-10-13 15:40:37 +02:00
jbrw
ac31fe8321
FEATURE - SiteSetting to disable user option to hide their profiles and presences ( #10885 )
...
* FEATURE - SiteSetting to disable user option to hide their profiles and presences
2020-10-09 17:18:44 -04:00
Discourse Translator Bot
29a9ae1b50
Update translations
2020-10-06 15:43:13 +02:00
Joffrey JAFFEUX
e6821fbaae
DEV: fixes linting of hbs files in core plugins ( #10820 )
2020-10-05 14:42:36 +02:00
Joffrey JAFFEUX
4b94af077d
DEV: linting of discourse-presence ( #10722 )
2020-09-22 17:20:00 +02:00
Discourse Translator Bot
6734a82260
Update translations
2020-09-16 10:17:56 +00:00
Discourse Translator Bot
5990c71c29
Update translations
2020-09-15 13:04:17 +00:00
David Taylor
d84dee4519
FIX: Account for different composer 'edit' states in discourse-presence ( #10631 )
...
Previously we were manually comparing the composer 'action' to the REPLY and EDIT constants. This meant that other forms of editing (e.g. shared drafts) were not included. This commit changes the presence logic to use the existing composer computed variables.
2020-09-10 10:52:51 +01:00
Discourse Translator Bot
1c71f81144
Update translations
2020-09-09 14:59:40 +00:00
Joffrey JAFFEUX
bf88410126
DEV: apply coding standards to plugins ( #10594 )
2020-09-04 13:51:53 +02:00
Discourse Translator Bot
d0faee3bd8
Update translations
2020-08-18 13:02:44 +00:00
Discourse Translator Bot
1a78a429b5
Update translations
2020-08-11 13:04:00 +00:00
Penar Musaraj
89209985c8
FIX: Update colors for presence plugin
2020-08-07 15:02:36 -04:00
Discourse Translator Bot
a68533b394
Update translations
2020-08-05 13:55:12 +00:00
Gerhard Schlager
390dc5c7a9
Update translations
2020-06-21 11:58:21 +02:00
Gerhard Schlager
36a3675e0a
Update translations
2020-06-14 23:39:33 +02:00
Neil Lalonde
72c09ab4ae
Update translations
2020-06-01 13:58:51 -04:00
Guo Xiang Tan
a849bdf0c9
FIX: Don't publish typing presence if composer isn't opened.
...
Hitting cancel on composer will set composer's reply and title to null
causing our observer to fire.
2020-05-14 12:52:10 +08:00
Guo Xiang Tan
3d5589e026
DEV: Remove assertions that are not required.
2020-05-14 10:07:55 +08:00
Guo Xiang Tan
c5ef465179
DEV: Avoid relative paths when importing in plugins.
2020-05-14 10:05:16 +08:00
Guo Xiang Tan
623920f13d
FEATURE: Introduce a staff only override key for discourse-presence.
...
Merge remote-tracking branch 'origin/coding-standards'
This uses the composer as a bridge for other plugins.
2020-05-13 14:13:31 +08:00
Guo Xiang Tan
ca8d11635c
Add missing export in 15e32dc1af.
2020-05-13 13:57:12 +08:00
Guo Xiang Tan
15e32dc1af
FIX: Composer presence shows user as editing when replying.
2020-05-13 13:41:03 +08:00
Guo Xiang Tan
aa40a07d73
FIX: Throttle typing function in discourse-presence.
2020-05-13 13:31:06 +08:00
Guo Xiang Tan
b299f5f491
DEV: Use Ember.Service over manually registering a factory.
...
Follow up to 9e827eb420
2020-05-06 09:24:49 +08:00
tshenry
b8b1cbbfb9
UX: Improve second factor UI ( #9526 )
...
This will make a few minor improvements to the second factor user interface. Highlights include:
- Using the site's title to prefix the backup code filename. If non-ascii characters are detected, then prefix "discourse" instead.
- Add icons and change the text on some of the buttons for better clarity and consistency
- Add an education link to the security key modal
2020-05-05 11:05:25 +10:00
Guo Xiang Tan
9e827eb420
DEV: Refactor presence manager to deal with multiple composer states.
...
This change amends it so we use a static service to keep track of
the typing presence.
It correct various edge cases the initial implementation had
- Faster close messages
- When composing on topic 1 and viewing topic 2 we had incorrect
presence
- Changing a running composer to reply as new topic or reply to a
differet topic would not correctly shift presence
Authored by tgxworld, with contributions by sam
2020-05-01 11:37:03 +10:00
Guo Xiang Tan
ae54a33719
FIX: discourse-presence breaks composer for users.
2020-04-29 15:29:29 +08:00
Guo Xiang Tan
197d0332e6
DEV: Missing import.
2020-04-29 13:48:31 +08:00
Guo Xiang Tan
8b3b5d1474
DEV: Disable discourse-presence in Ember test env.
2020-04-29 13:39:19 +08:00
Sam Saffron
2045f51312
FIX: correctly account for direct replies with presence
...
followup to 301a0fa5
2020-04-29 15:23:17 +10:00
