8 Commits

Author	SHA1	Message	Date
Robin Ward	78ddc82952	FIX: Respect min_flags_staff_visibility for new flags too ... There was a situation where if: * There were new flags to review that met the visibility threshold AND * There were old flags that *didn't* meet the threshold THEN a pending flags notification would be sent out. This fixes that case. Staff should not be notified of flags if they do not meet the threshold and are old.	2019-01-25 11:27:43 -05:00
Robin Ward	96b2585a91	REFACTOR: Remove unncessary stubs from pending flags reminder ... They seem to be calculated fine by the application, and stubbing makes the tests more brittle and prone to regression.	2019-01-24 13:45:58 -05:00
Robin Ward	f32de88dfc	FIX: Don't notify of pending flags if min_flags_staff_visibility not met	2019-01-22 11:01:18 -05:00
Guo Xiang Tan	13f3de4bf6	Nuke all SiteSetting.stubs from our codebase.	2017-07-07 15:09:14 +09:00
Neil Lalonde	3835e16cf7	FIX: New implementation of the "notify about flag after" setting. Only notify about new flags since the last notification. Send a private message to staff. Mention the 3 most active moderators in the message so they get notification emails.	2017-04-19 16:17:45 -04:00
Neil Lalonde	e8d837269b	FEATURE: pending flags reminder is sent as a group message to staff instead of sending an email to the contact email site setting.	2016-02-19 15:21:18 -05:00
Andy Waite	3e50313fdc	Prepare for separation of RSpec helper files ... Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.	2015-12-01 20:39:42 +00:00
Neil Lalonde	ecf211aa3f	Send email to contact_email if there are flags submitted more than 48 hours ago. Configurable with the notify_about_flags_after site setting.	2014-04-03 14:34:40 -04:00