2 Commits

Author	SHA1	Message	Date
Krzysztof Kotlarek	4ad83a98a1	FIX: migrations must be finished to reset flags cache (#29693) ... Bug introduced here: https://github.com/discourse/discourse/pull/29609 It was checking if `flags` table existed before resetting the cache. However, `require_message` flag was added in further migration: https://github.com/discourse/discourse/blob/main/db/migrate/20240714231226_duplicate_flags_custom_type_to_require_message.rb#L5 When the admin tried to update Discourse which already has `flags` table but no `require_message` column, it was causing the error. Therefore, we should ensure that all migrations are finished before resetting flags cache. Meta: https://meta.discourse.org/t/update-failing-column-require-message-does-not-exist/335030	2024-11-11 12:14:14 +11:00
Krzysztof Kotlarek	d57b7abe67	FIX: setup with db:create db:migrate (#29609) ... After data seed, we should reset Redis cache to ensure that the correct flags are cached. However, `db:create` is skipping Redis https://github.com/discourse/discourse/blob/main/lib/tasks/db.rake#L39 And uses `ActiveSupport::Cache::MemoryStore.new` e2292d4c59/lib/discourse.rb (L523) Therefore, the reset flags cache was moved to initializers and evaluated only when the cache is Redis and Flags table already exists. Meta: https://meta.discourse.org/t/development-install-fails-when-running-bin-rails-db-migrate/332754	2024-11-06 15:06:17 +11:00