mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 12:13:58 -06:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
22 lines
623 B
Ruby
22 lines
623 B
Ruby
require 'rails_helper'
|
|
|
|
describe UsernameSettingValidator do
|
|
describe '#valid_value?' do
|
|
subject(:validator) { described_class.new }
|
|
|
|
it "returns true for blank values" do
|
|
expect(validator.valid_value?('')).to eq(true)
|
|
expect(validator.valid_value?(nil)).to eq(true)
|
|
end
|
|
|
|
it "returns true if value matches an existing user's username" do
|
|
Fabricate(:user, username: 'vader')
|
|
expect(validator.valid_value?('vader')).to eq(true)
|
|
end
|
|
|
|
it "returns false if value does not match a user's username" do
|
|
expect(validator.valid_value?('no way')).to eq(false)
|
|
end
|
|
end
|
|
end
|