mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
082cd13909
Deleting a message with a mention doesn't clear the associated notification, confusing the mentioned user. There are different chat notification types, but we only care about `chat_mentioned` since `chat_quoted` is associated with a post, and `chat_message` is only for push notifications. Unfortunately, this change doesn't fix the chat bubble getting out of sync when a message gets deleted since we track unread/mentions count with an integer, making it a bit hard to manipulate. We can follow up later if we consider it necessary.
38 lines
1.0 KiB
Ruby
38 lines
1.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class ChatMessageDestroyer
|
|
def destroy_in_batches(chat_messages_query, batch_size: 200)
|
|
chat_messages_query
|
|
.in_batches(of: batch_size)
|
|
.each do |relation|
|
|
destroyed_ids = relation.destroy_all.pluck(:id)
|
|
reset_last_read(destroyed_ids)
|
|
delete_flags(destroyed_ids)
|
|
end
|
|
end
|
|
|
|
def trash_message(message, actor)
|
|
ChatMessage.transaction do
|
|
message.trash!(actor)
|
|
ChatMention.where(chat_message: message).destroy_all
|
|
|
|
# FIXME: We should do something to prevent the blue/green bubble
|
|
# of other channel members from getting out of sync when a message
|
|
# gets deleted.
|
|
ChatPublisher.publish_delete!(message.chat_channel, message)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def reset_last_read(message_ids)
|
|
UserChatChannelMembership.where(last_read_message_id: message_ids).update_all(
|
|
last_read_message_id: nil,
|
|
)
|
|
end
|
|
|
|
def delete_flags(message_ids)
|
|
ReviewableChatMessage.where(target_id: message_ids).destroy_all
|
|
end
|
|
end
|