mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 10:50:26 -06:00
64b0b50ac0
Our Email::Sender class accepts an optional user argument, which is used to create a PostReplyKey record when present. This record is used to sub out the %{reply_key} placeholder in the Reply-To mail header, so if we do not pass in the user we get a broken Reply-To header.
This is especially problematic in the IMAP group SMTP situation, because these emails go to customers that we are replying to, and when they reply to us the email bounces! This fixes the issue by passing user to the Email::Sender when sending a group_smtp email but there is still more to do in another PR.
This Email::Sender optional user is a bit of a footgun IMO, especially because most of the time we use it there is a user we can source. I would like to do another PR for this after this one to make the parameter not optional, so we don't end up with these reply issues down the line again.
25 lines
527 B
Ruby
25 lines
527 B
Ruby
# frozen_string_literal: true
|
|
|
|
Fabricator(:group) do
|
|
name { sequence(:name) { |n| "my_group_#{n}" } }
|
|
end
|
|
|
|
Fabricator(:public_group, from: :group) do
|
|
public_admission true
|
|
public_exit true
|
|
end
|
|
|
|
Fabricator(:imap_group, from: :group) do
|
|
smtp_server "smtp.ponyexpress.com"
|
|
smtp_port 587
|
|
smtp_ssl true
|
|
imap_server "imap.ponyexpress.com"
|
|
imap_port 993
|
|
imap_ssl true
|
|
imap_mailbox_name "All Mail"
|
|
imap_uid_validity 0
|
|
imap_last_uid 0
|
|
email_username "discourseteam@ponyexpress.com"
|
|
email_password "test"
|
|
end
|