discourse/spec
Isaac Janzen e5349e43af
DEV: Update group moderator behavior to better mimic staff (#19618)
# Context
When a topic is reviewable by a group we give those group moderators some admin abilities including the ability to delete a topic.

# Problem
There are two main problems:

1. Currently when a group moderator deletes a topic they are redirected to root (not the same for staff)
2. Viewing the categories deleted topics (`c/foo/1/?status=deleted`) does not display the deleted topic to the group moderator (not the same for staff).

# Fix
If the `deleted_by` user is part a group that matches the `reviewable_by_group` on a topic then don't redirect. This is the default interaction for staff to give them the ability to do things like restore the topic in case it was accidentally deleted.

To render the deleted topics as expected for the group moderator I am utilizing [the guardian scope of `guardian.can_see_deleted_topics?` for said category](https://github.com/discourse/discourse/pull/19618/files#diff-288e61b8bacdb29d9c2e05b42da6837b0036dcf1867332d977ca7c5e74a44297R802-R803)
2022-12-29 10:07:03 -06:00
..
fabricators DEV: permission type for private category fabricator (#19601) 2022-12-23 11:18:29 +08:00
fixtures DEV: Fix png optimization test flakyness (#19535) 2022-12-20 16:05:14 -03:00
helpers FEATURE: Optionally allow a separate s3_asset_cdn_url to be specified (#19284) 2022-12-08 10:36:20 +00:00
import_export DEV: Add a rake task to export/import translation overrides (#18487) 2022-10-05 15:22:16 -04:00
initializers Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
integration FEATURE: Track API and user API requests (#19186) 2022-11-29 13:07:42 +02:00
integrity DEV: Compatibility with Ruby 3.2 (#19303) 2022-12-13 16:03:53 -03:00
jobs DEV: Stop leaking state in dashboard controller specs (#19608) 2022-12-23 15:41:30 +03:00
lib DEV: Update group moderator behavior to better mimic staff (#19618) 2022-12-29 10:07:03 -06:00
mailers SECURITY: Filter tags in user notifications for visibility (#19239) 2022-11-29 10:35:41 -06:00
models FIX: Don't assume a clean slate in tests (#19499) 2022-12-19 12:12:03 -06:00
multisite DEV: Change HashtagAutocompleteService to use DiscoursePluginRegistry (#19491) 2022-12-19 13:46:17 +10:00
requests FIX: show status on mentions on just posted posts (#19639) 2022-12-29 14:34:59 +04:00
script/import_scripts DEV: Remove remaining hardcoded ids (#18735) 2022-10-25 15:29:09 +08:00
serializers FIX: Show topic titles in deleted-posts (#19610) 2022-12-28 16:07:06 +08:00
services FIX: Add missing email template for user_watching_category_or_tag (#19653) 2022-12-29 15:36:53 +01:00
support FIX: Admin can't see user sidebar preferences of other users (#19570) 2022-12-23 11:45:29 +08:00
system FIX: Admin can't see user sidebar preferences of other users (#19570) 2022-12-23 11:45:29 +08:00
tasks FIX: Allow attr updates of over-size-limit uploads (#18986) 2022-11-11 17:56:11 +01:00
views DEV: use structured data in topic-list for referencing only (#16235) 2022-12-05 18:00:32 +02:00
rails_helper.rb DEV: Print system test logs with other test metadata (#19637) 2022-12-28 10:47:57 +00:00
regenerate_swagger_docs DEV: Add API docs for uploads and API doc watcher (#15387) 2021-12-23 08:40:15 +10:00
swagger_helper.rb DEV: Update rubocop (#18754) 2022-10-26 09:05:15 +08:00