mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 18:30:26 -06:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
77 lines
2.3 KiB
Ruby
77 lines
2.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe Jobs::TruncateUserFlagStats do
|
|
let(:user) { Fabricate(:user) }
|
|
let(:other_user) { Fabricate(:user) }
|
|
|
|
before do
|
|
# We might make this a site setting eventually
|
|
Jobs::TruncateUserFlagStats.stubs(:truncate_to).returns(2)
|
|
end
|
|
|
|
def perform(*users)
|
|
described_class.new.execute(user_ids: users.map(&:id))
|
|
users.each { |u| u.reload }
|
|
end
|
|
|
|
it "raises an error without user ids" do
|
|
expect {
|
|
described_class.new.execute({})
|
|
}.to raise_error(Discourse::InvalidParameters)
|
|
end
|
|
|
|
it "does nothing if the user doesn't have enough flags" do
|
|
user.user_stat.update_columns(flags_agreed: 1)
|
|
perform(user)
|
|
|
|
expect(user.user_stat.flags_agreed).to eq(1)
|
|
expect(user.user_stat.flags_disagreed).to eq(0)
|
|
expect(user.user_stat.flags_ignored).to eq(0)
|
|
end
|
|
|
|
it "removes the statuses of old flags (integration test)" do
|
|
p0 = Fabricate(:post)
|
|
p1 = Fabricate(:post)
|
|
p2 = Fabricate(:post, user: user)
|
|
p3 = Fabricate(:post)
|
|
|
|
r0 = PostActionCreator.spam(user, p0).reviewable
|
|
r1 = PostActionCreator.spam(user, p1).reviewable
|
|
r2 = PostActionCreator.spam(user, p2).reviewable
|
|
r3 = PostActionCreator.spam(user, p3).reviewable
|
|
|
|
PostActionCreator.spam(other_user, p3).reviewable
|
|
PostActionCreator.spam(other_user, p2).reviewable
|
|
PostActionCreator.spam(other_user, p1).reviewable
|
|
|
|
r0.perform(Discourse.system_user, :agree_and_keep)
|
|
r1.perform(Discourse.system_user, :disagree)
|
|
r2.perform(Discourse.system_user, :ignore)
|
|
r3.perform(Discourse.system_user, :agree_and_keep)
|
|
|
|
user.user_stat.reload
|
|
other_user.user_stat.reload
|
|
|
|
expect(user.user_stat.flags_agreed).to eq(2)
|
|
expect(user.user_stat.flags_disagreed).to eq(1)
|
|
expect(user.user_stat.flags_ignored).to eq(0)
|
|
|
|
expect(other_user.user_stat.flags_agreed).to eq(1)
|
|
expect(other_user.user_stat.flags_disagreed).to eq(1)
|
|
expect(other_user.user_stat.flags_ignored).to eq(1)
|
|
|
|
perform(user, other_user)
|
|
|
|
expect(user.user_stat.flags_agreed).to eq(1)
|
|
expect(user.user_stat.flags_disagreed).to eq(1)
|
|
expect(user.user_stat.flags_ignored).to eq(0)
|
|
|
|
expect(other_user.user_stat.flags_agreed).to eq(0)
|
|
expect(other_user.user_stat.flags_disagreed).to eq(1)
|
|
expect(other_user.user_stat.flags_ignored).to eq(1)
|
|
end
|
|
|
|
end
|