Martin Brennan 1ba5ccd8af FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658) ...

We introduced a cap on the number of bookmarks the user can add in https://github.com/discourse/discourse/commit/be145ccf2fe117d97b36aa1e2fc500e44319d58c. However this has caused unintended side effects; when the `jobs/scheduled/bookmark_reminder_notifications.rb` runs we get this error for users who already had more bookmarks than the limit:

> Job exception: Validation failed: Sorry, you have too many bookmarks, visit #{url}/my/activity/bookmarks to remove some.

This is because the `clear_reminder!` call was triggering a bookmark validation, which raised an error because the user already had to many, holding up other reminders.

This PR also adds `max_bookmarks_per_user` hidden site setting (default 2000). This replaces the BOOKMARK_LIMIT const so we can raise it for certain sites.

2021-04-09 13:06:35 +10:00

..

components

DEV: stub youtube embed requests (#12637)

2021-04-07 13:32:27 -04:00

fabricators

FEATURE: trigger webhook when a user added/removed in a group. (#12653)

2021-04-08 21:16:34 +05:30

fixtures

FEATURE: Allow admins to pre-populate user fields (#12361)

2021-03-29 14:03:19 +03:00

helpers

A11Y: sets the html lang to user's locale when possible (#12007)

2021-02-10 16:12:09 +01:00

import_export

FEATURE: Rake task to export groups (#9450)

2020-04-17 14:59:54 -07:00

initializers

FIX: We need to skip users with associated reviewables when auto-approving (#9080)

2020-03-02 14:33:52 -05:00

integration

DEV: Retry-after header values should be strings (#12475)

2021-03-23 20:32:36 +01:00

integrity

FEATURE: Add anchor links to headings (#12379)

2021-03-23 10:45:06 +02:00

jobs

FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658)

2021-04-09 13:06:35 +10:00

lib

Revert "FEATURE: Introduce theme/component QUnit tests (#12517)" (#12632)

2021-04-07 17:45:49 +03:00

mailers

FIX: Correctly use invite to topic email templates (#12411)

2021-03-16 17:08:54 +02:00

models

FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658)

2021-04-09 13:06:35 +10:00

multisite

DEV: Prevents rate limits for new feature checks on multisite (#12053)

2021-02-12 08:52:59 -05:00

requests

FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658)

2021-04-09 13:06:35 +10:00

script/import_scripts

DEV: If disabled do not change setting after import (#12142)

2021-02-19 09:33:35 -07:00

serializers

FIX: Only refresh the review count when the user can see the review queue. (#12453)

2021-03-19 16:20:41 -03:00

services

FIX: Make HTML scrubber work with deep HTML (#12619)

2021-04-07 17:02:00 +10:00

support

FEATURE: Allow using invites when DiscourseConnect SSO is enabled (#12419)

2021-03-19 10:20:10 +10:00

tasks

FIX: remove migrate_from_s3 task that silently corrupts data (#11703)

2021-01-17 22:33:29 +01:00

views/omniauth_callbacks

FEATURE: Use full page redirection for all external auth methods (#8092)

2019-10-08 12:10:43 +01:00

rails_helper.rb

DEV: Better SimpleCov configuration (#12544)

2021-03-29 21:01:35 +03:00

swagger_helper.rb

api docs example (#11997)

2021-02-08 10:09:44 -07:00