mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 09:26:54 -06:00
fc1c5f6a8d
Currently in services, the `contract` step is only used to define where the contract will be called in the execution flow. Then, a `Contract` class has to be defined with validations in it. This patch allows the `contract` step to take a block containing validations, attributes, etc. directly. No need to then open a `Contract` class later in the service. It also has a nice side effect, as it’s now easy to define multiples contracts inside the same service. Before, we had the `class_name:` option, but it wasn’t really useful as you had to redefine a complete new contract class. Now, when using a name for the contract other than `default`, a new contract will be created automatically using the provided name. Example: ```ruby contract(:user) do attribute :user_id, :integer validates :user_id, presence: true end ``` This will create a `UserContract` class and use it, also putting the resulting contract in `context[:user_contract]`.
65 lines
1.5 KiB
Ruby
65 lines
1.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Flags::CreateFlag
|
|
include Service::Base
|
|
|
|
contract do
|
|
attribute :name, :string
|
|
attribute :description, :string
|
|
attribute :require_message, :boolean
|
|
attribute :enabled, :boolean
|
|
attribute :applies_to
|
|
|
|
validates :name, presence: true
|
|
validates :description, presence: true
|
|
validates :name, length: { maximum: Flag::MAX_NAME_LENGTH }
|
|
validates :description, length: { maximum: Flag::MAX_DESCRIPTION_LENGTH }
|
|
validates :applies_to, inclusion: { in: -> { Flag.valid_applies_to_types } }, allow_nil: false
|
|
end
|
|
policy :invalid_access
|
|
policy :unique_name
|
|
model :flag, :instantiate_flag
|
|
transaction do
|
|
step :create
|
|
step :log
|
|
end
|
|
|
|
private
|
|
|
|
def unique_name(name:)
|
|
!Flag.custom.where(name: name).exists?
|
|
end
|
|
|
|
def instantiate_flag(name:, description:, applies_to:, require_message:, enabled:)
|
|
Flag.new(
|
|
name: name,
|
|
description: description,
|
|
applies_to: applies_to,
|
|
require_message: require_message,
|
|
enabled: enabled,
|
|
notify_type: true,
|
|
)
|
|
end
|
|
|
|
def invalid_access(guardian:)
|
|
guardian.can_create_flag?
|
|
end
|
|
|
|
def create(flag:)
|
|
flag.save!
|
|
end
|
|
|
|
def log(guardian:, flag:)
|
|
StaffActionLogger.new(guardian.user).log_custom(
|
|
"create_flag",
|
|
{
|
|
name: flag.name,
|
|
description: flag.description,
|
|
applies_to: flag.applies_to,
|
|
require_message: flag.require_message,
|
|
enabled: flag.enabled,
|
|
},
|
|
)
|
|
end
|
|
end
|