mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 12:43:54 -06:00
0cbdf6f5bb
* Editing a badge's title would show it as changed in the side even if you didn't hit save * Clicking a badge would not scroll to the top * If there was an error saving a badge there was a missing i18n key * URLs were using queryParams instead of paths * User `label` tags for checkboxes for larger click targets * Saved! text would persist when viewing another badge * After creating a new badge it would show nothing * Validation errors were not being properly released to the client * Query errors were surrounded by an extra array
121 lines
3.1 KiB
Ruby
121 lines
3.1 KiB
Ruby
class Admin::BadgesController < Admin::AdminController
|
|
|
|
def index
|
|
data = {
|
|
badge_types: BadgeType.all.order(:id).to_a,
|
|
badge_groupings: BadgeGrouping.all.order(:position).to_a,
|
|
badges: Badge.includes(:badge_grouping)
|
|
.references(:badge_grouping)
|
|
.order('badge_groupings.position, badge_type_id, badges.name').to_a,
|
|
protected_system_fields: Badge.protected_system_fields,
|
|
triggers: Badge.trigger_hash
|
|
}
|
|
render_serialized(OpenStruct.new(data), AdminBadgesSerializer)
|
|
end
|
|
|
|
def preview
|
|
render json: BadgeGranter.preview(params[:sql],
|
|
target_posts: params[:target_posts] == "true",
|
|
explain: params[:explain] == "true",
|
|
trigger: params[:trigger].to_i)
|
|
end
|
|
|
|
def new
|
|
end
|
|
|
|
def show
|
|
end
|
|
|
|
def badge_types
|
|
badge_types = BadgeType.all.to_a
|
|
render_serialized(badge_types, BadgeTypeSerializer, root: "badge_types")
|
|
end
|
|
|
|
def save_badge_groupings
|
|
|
|
badge_groupings = BadgeGrouping.all.order(:position).to_a
|
|
ids = params[:ids].map(&:to_i)
|
|
|
|
params[:names].each_with_index do |name,index|
|
|
id = ids[index].to_i
|
|
group = badge_groupings.find{|b| b.id == id} || BadgeGrouping.new()
|
|
group.name = name
|
|
group.position = index
|
|
group.save
|
|
end
|
|
|
|
badge_groupings.each do |g|
|
|
g.destroy unless g.system? || ids.include?(g.id)
|
|
end
|
|
|
|
badge_groupings = BadgeGrouping.all.order(:position).to_a
|
|
render_serialized(badge_groupings, BadgeGroupingSerializer, root: "badge_groupings")
|
|
end
|
|
|
|
def create
|
|
badge = Badge.new
|
|
errors = update_badge_from_params(badge, new: true)
|
|
|
|
if errors.present?
|
|
render_json_error errors
|
|
else
|
|
render_serialized(badge, BadgeSerializer, root: "badge")
|
|
end
|
|
end
|
|
|
|
def update
|
|
badge = find_badge
|
|
|
|
errors = update_badge_from_params(badge)
|
|
|
|
if errors.present?
|
|
render_json_error errors
|
|
else
|
|
render_serialized(badge, BadgeSerializer, root: "badge")
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
find_badge.destroy
|
|
render nothing: true
|
|
end
|
|
|
|
private
|
|
def find_badge
|
|
params.require(:id)
|
|
Badge.find(params[:id])
|
|
end
|
|
|
|
# Options:
|
|
# :new - reset the badge id to nil before saving
|
|
def update_badge_from_params(badge, opts={})
|
|
errors = []
|
|
Badge.transaction do
|
|
allowed = Badge.column_names.map(&:to_sym)
|
|
allowed -= [:id, :created_at, :updated_at, :grant_count]
|
|
allowed -= Badge.protected_system_fields if badge.system?
|
|
params.permit(*allowed)
|
|
|
|
allowed.each do |key|
|
|
badge.send("#{key}=" , params[key]) if params[key]
|
|
end
|
|
|
|
# Badge query contract checks
|
|
begin
|
|
BadgeGranter.contract_checks!(badge.query, { target_posts: badge.target_posts, trigger: badge.trigger })
|
|
rescue => e
|
|
errors << e.message
|
|
raise ActiveRecord::Rollback
|
|
end
|
|
|
|
badge.id = nil if opts[:new]
|
|
badge.save!
|
|
end
|
|
|
|
errors
|
|
rescue ActiveRecord::RecordInvalid
|
|
errors.push(*badge.errors.full_messages)
|
|
errors
|
|
end
|
|
end
|