mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 21:19:41 -06:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
79 lines
2.2 KiB
Ruby
79 lines
2.2 KiB
Ruby
# encoding: UTF-8
|
|
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'validators/quality_title_validator'
|
|
require 'ostruct'
|
|
|
|
module QualityTitleValidatorSpec
|
|
class Validatable < OpenStruct
|
|
include ActiveModel::Validations
|
|
validates :title, quality_title: { unless: :private_message? }
|
|
end
|
|
end
|
|
|
|
describe "A record validated with QualityTitleValidator" do
|
|
let(:valid_title) { "hello this is my cool topic! welcome: all;" }
|
|
let(:short_title) { valid_title.slice(0, SiteSetting.min_topic_title_length - 1) }
|
|
let(:long_title) { valid_title.center(SiteSetting.max_topic_title_length + 1, 'x') }
|
|
let(:xxxxx_title) { valid_title.gsub(/./, 'x') }
|
|
|
|
subject(:topic) { QualityTitleValidatorSpec::Validatable.new }
|
|
|
|
before(:each) do
|
|
topic.stubs(private_message?: false)
|
|
end
|
|
|
|
it "allows a regular title with a few ascii characters" do
|
|
topic.title = valid_title
|
|
expect(topic).to be_valid
|
|
end
|
|
|
|
it "allows non ascii" do
|
|
topic.title = "Iñtërnâtiônàlizætiøn"
|
|
expect(topic).to be_valid
|
|
end
|
|
|
|
it 'allows Chinese characters' do
|
|
topic.title = '现在发现使用中文标题没法发帖子了'
|
|
expect(topic).to be_valid
|
|
end
|
|
|
|
it "allows anything in a private message" do
|
|
topic.stubs(private_message?: true)
|
|
[short_title, long_title, xxxxx_title].each do |bad_title|
|
|
topic.title = bad_title
|
|
expect(topic).to be_valid
|
|
end
|
|
end
|
|
|
|
it "strips a title when identifying length" do
|
|
topic.title = short_title.center(SiteSetting.min_topic_title_length + 1, ' ')
|
|
expect(topic).not_to be_valid
|
|
end
|
|
|
|
it "doesn't allow a long title" do
|
|
topic.title = long_title
|
|
expect(topic).not_to be_valid
|
|
end
|
|
|
|
it "doesn't allow a short title" do
|
|
topic.title = short_title
|
|
expect(topic).not_to be_valid
|
|
end
|
|
|
|
it "doesn't allow a title of one repeated character" do
|
|
topic.title = xxxxx_title
|
|
expect(topic).not_to be_valid
|
|
end
|
|
|
|
# describe "with a name" do
|
|
# it "is not valid without a name" do
|
|
# subject.stub(:name => nil)
|
|
# subject.should_not be_valid
|
|
# subject.should have(1).error_on(:name)
|
|
# subject.errors[:name].first.should == "can't be blank"
|
|
# end
|
|
# end
|
|
end
|