mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 10:20:58 -06:00
bf3e121323
Why this change? When running system tests on our CI, we have been occasionally seeing server errors like: ``` Error encountered while proccessing /stylesheets/desktop_e58cf7f686aab173f9b778797f241913c2833c39.css NoMethodError: undefined method `+' for nil:NilClass /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/path/pattern.rb:139:in `[]' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:127:in `block (2 levels) in find_routes' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:126:in `each' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:126:in `each_with_index' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:126:in `block in find_routes' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:123:in `map!' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:123:in `find_routes' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/journey/router.rb:32:in `serve' /__w/discourse/discourse/vendor/bundle/ruby/3.2.0/gems/actionpack-7.0.7/lib/action_dispatch/routing/route_set.rb:852:in `call' ``` While looking through various Rails issues related to the error above, I came across https://github.com/rails/rails/pull/27647 which is a fix to fully initialize routes before the first request is handled. However, the routes are only fully initialize only if `config.eager_load` is set to `true`. There is no reason why `config.eager_load` shouldn't be `true` in the CI environment and this is what a new Rails 7.1 app is generated with. What does this change do? Enable `config.eager_load` when `env["CI"]` is present
89 lines
3.3 KiB
Ruby
89 lines
3.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
Discourse::Application.configure do
|
|
# Settings specified here will take precedence over those in config/application.rb
|
|
|
|
# The test environment is used exclusively to run your application's
|
|
# test suite. You never need to work with it otherwise. Remember that
|
|
# your test database is "scratch space" for the test suite and is wiped
|
|
# and recreated between test runs. Don't rely on the data there!
|
|
config.cache_classes = true
|
|
|
|
# Eager loading loads your entire application. When running a single test locally,
|
|
# this is usually not necessary, and can slow down your test suite. However, it's
|
|
# recommended that you enable it in continuous integration systems to ensure eager
|
|
# loading is working properly before deploying your code.
|
|
config.eager_load = ENV["CI"].present?
|
|
|
|
# Configure static asset server for tests with Cache-Control for performance
|
|
config.public_file_server.enabled = true
|
|
|
|
# don't consider reqs local so we can properly handle exceptions like we do in prod
|
|
config.consider_all_requests_local = false
|
|
|
|
# disable caching
|
|
config.action_controller.perform_caching = false
|
|
|
|
# production has "show exceptions" on so we better have it
|
|
# in test as well
|
|
config.action_dispatch.show_exceptions = true
|
|
|
|
# Disable request forgery protection in test environment
|
|
config.action_controller.allow_forgery_protection = false
|
|
|
|
# Tell Action Mailer not to deliver emails to the real world.
|
|
# The :test delivery method accumulates sent emails in the
|
|
# ActionMailer::Base.deliveries array.
|
|
config.action_mailer.delivery_method = :test
|
|
|
|
# Use SQL instead of Active Record's schema dumper when creating the test database.
|
|
# This is necessary if your schema can't be completely dumped by the schema dumper,
|
|
# like if you have constraints or database-specific column types
|
|
# config.active_record.schema_format = :sql
|
|
|
|
# Print deprecation notices to the stderr
|
|
config.active_support.deprecation = :stderr
|
|
|
|
# lower iteration count for test
|
|
config.pbkdf2_iterations = 10
|
|
|
|
config.assets.compile = true
|
|
config.assets.digest = false
|
|
|
|
if ENV["RAILS_ENABLE_TEST_LOG"]
|
|
config.logger = Logger.new(STDOUT)
|
|
config.log_level =
|
|
ENV["RAILS_TEST_LOG_LEVEL"].present? ? ENV["RAILS_TEST_LOG_LEVEL"].to_sym : :info
|
|
else
|
|
config.logger = Logger.new(nil)
|
|
config.log_level = :fatal
|
|
end
|
|
|
|
if defined?(RspecErrorTracker)
|
|
config.middleware.insert_after ActionDispatch::Flash, RspecErrorTracker
|
|
end
|
|
|
|
config.after_initialize do
|
|
SiteSetting.defaults.tap do |s|
|
|
s.set_regardless_of_locale(:s3_upload_bucket, "bucket")
|
|
s.set_regardless_of_locale(:min_post_length, 5)
|
|
s.set_regardless_of_locale(:min_first_post_length, 5)
|
|
s.set_regardless_of_locale(:min_personal_message_post_length, 10)
|
|
s.set_regardless_of_locale(:download_remote_images_to_local, false)
|
|
s.set_regardless_of_locale(:unique_posts_mins, 0)
|
|
s.set_regardless_of_locale(:max_consecutive_replies, 0)
|
|
|
|
# Most existing tests were written assuming allow_uncategorized_topics
|
|
# was enabled, so we should set it to true.
|
|
s.set_regardless_of_locale(:allow_uncategorized_topics, true)
|
|
|
|
# disable plugins
|
|
if ENV["LOAD_PLUGINS"] == "1"
|
|
s.set_regardless_of_locale(:discourse_narrative_bot_enabled, false)
|
|
end
|
|
end
|
|
|
|
SiteSetting.refresh!
|
|
end
|
|
end
|