mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 02:11:08 -06:00
32e261ef73
* Add migrations to ensure password hash is synced across users & user_passwords * Persist password-related data in user_passwords instead of users * Merge User#expire_old_email_tokens with User#expire_tokens_if_password_changed * Add post deploy migration to mark password-related columns from users table as read-only * Refactored UserPassword#confirm_password? and changes required to accommodate hashing the password after validations
72 lines
2.4 KiB
Ruby
72 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe UserPassword do
|
|
describe "#confirm_password?" do
|
|
context "when input password is same as saved password" do
|
|
let(:pw) { SecureRandom.hex }
|
|
|
|
it "returns true after saving password for the first time" do
|
|
u = Fabricate(:user, password: nil)
|
|
u.password = pw
|
|
u.save!
|
|
expect(u.confirm_password?(pw)).to eq true
|
|
end
|
|
|
|
it "returns true after updating existing password" do
|
|
pw = SecureRandom.hex
|
|
u = Fabricate(:user, password: "initial_password_123")
|
|
u.update!(password: pw)
|
|
expect(u.confirm_password?(pw)).to eq true
|
|
end
|
|
|
|
it "updates the algorithm if it's outdated and password_hash, and returns true" do
|
|
user_password = Fabricate(:user, password: pw).user_password
|
|
old_algorithm = "$pbkdf2-sha256$i=5,l=32$"
|
|
old_hash =
|
|
described_class.new.send(:hash_password, pw, user_password.password_salt, old_algorithm)
|
|
user_password.update_columns(password_algorithm: old_algorithm, password_hash: old_hash)
|
|
|
|
result = nil
|
|
expect { result = user_password.confirm_password?(pw) }.to change {
|
|
user_password.password_algorithm
|
|
}.from(old_algorithm).to(described_class::TARGET_PASSWORD_ALGORITHM)
|
|
expect(result).to eq true
|
|
|
|
new_hash =
|
|
described_class.new.send(
|
|
:hash_password,
|
|
pw,
|
|
user_password.password_salt,
|
|
user_password.password_algorithm,
|
|
)
|
|
expect(user_password.password_hash).to eq(new_hash)
|
|
end
|
|
end
|
|
|
|
context "when input password is not the same as saved password" do
|
|
let(:actual_pw) { SecureRandom.hex }
|
|
|
|
it "returns false" do
|
|
u = Fabricate(:user, password: actual_pw)
|
|
expect(u.confirm_password?(SecureRandom.hex)).to eq false
|
|
end
|
|
end
|
|
|
|
context "when used on an unpersisted record" do
|
|
it "returns false" do
|
|
user_password = Fabricate.build(:user_password, user: nil)
|
|
expect(user_password.confirm_password?(user_password.password)).to eq false
|
|
end
|
|
end
|
|
end
|
|
|
|
context "for validations" do
|
|
it "should validate presence of user_id" do
|
|
user_password = Fabricate.build(:user_password, user: nil)
|
|
|
|
expect(user_password).not_to be_valid
|
|
expect(user_password.errors[:user]).to include("must exist")
|
|
end
|
|
end
|
|
end
|