mirror of
https://github.com/discourse/discourse.git
synced 2024-11-30 04:34:13 -06:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
73 lines
2.1 KiB
Ruby
73 lines
2.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe SimilarTopicsController do
|
|
context 'similar_to' do
|
|
|
|
let(:title) { 'this title is long enough to search for' }
|
|
let(:raw) { 'this body is long enough to search for' }
|
|
|
|
it "requires a title" do
|
|
expect { xhr :get, :index, raw: raw }.to raise_error(ActionController::ParameterMissing)
|
|
end
|
|
|
|
it "requires a raw body" do
|
|
expect { xhr :get, :index, title: title }.to raise_error(ActionController::ParameterMissing)
|
|
end
|
|
|
|
it "returns no results if the title length is below the minimum" do
|
|
Topic.expects(:similar_to).never
|
|
SiteSetting.stubs(:min_title_similar_length).returns(100)
|
|
xhr :get, :index, title: title, raw: raw
|
|
json = ::JSON.parse(response.body)
|
|
expect(json["similar_topics"].size).to eq(0)
|
|
end
|
|
|
|
it "returns no results if the body length is below the minimum" do
|
|
Topic.expects(:similar_to).never
|
|
SiteSetting.stubs(:min_body_similar_length).returns(100)
|
|
xhr :get, :index, title: title, raw: raw
|
|
json = ::JSON.parse(response.body)
|
|
expect(json["similar_topics"].size).to eq(0)
|
|
end
|
|
|
|
describe "minimum_topics_similar" do
|
|
|
|
before do
|
|
SiteSetting.stubs(:minimum_topics_similar).returns(30)
|
|
end
|
|
|
|
after do
|
|
xhr :get, :index, title: title, raw: raw
|
|
end
|
|
|
|
describe "With enough topics" do
|
|
before do
|
|
Topic.stubs(:count).returns(50)
|
|
end
|
|
|
|
it "deletes to Topic.similar_to if there are more topics than `minimum_topics_similar`" do
|
|
Topic.expects(:similar_to).with(title, raw, nil).returns([Fabricate(:topic)])
|
|
end
|
|
|
|
describe "with a logged in user" do
|
|
let(:user) { log_in }
|
|
|
|
it "passes a user through if logged in" do
|
|
Topic.expects(:similar_to).with(title, raw, user).returns([Fabricate(:topic)])
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
it "does not call Topic.similar_to if there are fewer topics than `minimum_topics_similar`" do
|
|
Topic.stubs(:count).returns(10)
|
|
Topic.expects(:similar_to).never
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|