Andrei Prigorshnev 932a2fe419 FIX: PG::StringDataRightTruncation when linking posts (#13134) ... Users who use encoded slugs on their sites sometimes run into 500 error when pasting a link to another topic in a post. The problem happens when generating a backward "reflection" link that would appear in a linked topic. Link URL restricted on the database level to 500 chars in length. At first glance, it should work since we have a restriction on topic title length. But it doesn't work when a site uses encoded slugs, like here (take a look at the URL). The link to a topic, in this case, can be much longer than 500 characters. By the way, an error happens only when generating a "reflection" link and doesn't happen with a direct link, we truncate that link. It works because, in this case, the original long link is still present in the post body and can be used for navigation. But we can't do the same for backward "reflection" links (without rewriting their implementation), the whole link must be saved to the database. The simplest and cleanest solution will be just to remove the restriction on the database level. Abuse is impossible here since we are already protected by the restriction on topic title length. There aren’t performance benefits in using length-constrained columns in Postgres, in fact, length-constrained columns need a few extra CPU cycles to check the length when storing data.		2021-06-02 15:27:04 +04:00
..
about_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
admin_dashboard_problem_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
api_key_spec.rb	REFACTOR: Introduce RouteMatcher class	2020-10-19 10:40:55 +01:00
application_request_spec.rb	DEV: Clean up some Redis leaks in test env.	2020-05-18 17:27:37 +08:00
badge_spec.rb	FIX: don't update allow_title column of existing badges in seed. (#13190)	2021-05-28 00:30:57 +05:30
badge_type_spec.rb	DEV: Upgrading Discourse to Zeitwerk (#8098)	2019-10-02 14:01:53 +10:00
bookmark_spec.rb	FIX: When user has already hit bookmark limit, do not error for clear_reminder! or other updates (#12658)	2021-04-09 13:06:35 +10:00
category_featured_topic_spec.rb	FEATURE: remove support for 'suppress_from_latest' category setting. (#8308)	2019-11-18 12:28:35 +05:30
category_group_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
category_list_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
category_spec.rb	No need to disable rate limiter after running tests (#13093)	2021-05-19 16:04:35 +04:00
category_user_spec.rb	FIX: Wrong scope used for notification levels user serializer (#13039)	2021-05-14 09:45:14 +10:00
child_theme_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
color_scheme_color_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
color_scheme_spec.rb	FEATURE: WCAG compliant color schemes (#10882)	2020-10-15 14:05:48 -04:00
developer_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
digest_email_site_setting_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
directory_item_spec.rb	DEV: improve flaky spec	2019-10-04 11:11:03 +10:00
discourse_single_sign_on_spec.rb	FEATURE: Flag to disable DiscourseConnect CSRF protection (#12356)	2021-03-11 10:38:34 +00:00
do_not_disturb_timing_spec.rb	FEATURE: Do not disturb (#11484)	2020-12-18 09:03:51 -06:00
draft_sequence_spec.rb	FIX: Always return 0 for non-human user current DraftSequence.	2020-05-15 10:40:36 +08:00
draft_spec.rb	FEATURE: composer option to reload page and force save draft (#10773)	2020-09-29 22:29:03 +05:30
email_change_request_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
email_log_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
email_token_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
embeddable_host_spec.rb	FIX: use allowlist and blocklist terminology (#10209)	2020-07-27 10:23:54 +10:00
emoji_spec.rb	FIX: allows replacement of digits and symbols emojis (#7978)	2019-08-07 11:38:58 +02:00
given_daily_like_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
global_setting_spec.rb	FIX: use Redis replica host and port (#11566)	2020-12-23 13:14:19 +11:00
group_history_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
group_spec.rb	DEV: calls user_added_to_group on group/TL enforcement (#13222)	2021-06-01 10:34:41 +02:00
group_user_spec.rb	FIX: Wrong scope used for notification levels user serializer (#13039)	2021-05-14 09:45:14 +10:00
incoming_link_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
incoming_links_report_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
invite_redeemer_spec.rb	FEATURE: Auto-activate users invited by email (#12675)	2021-04-14 12:15:56 +03:00
invite_spec.rb	FIX: Improve error messages for invites (#12714)	2021-04-15 14:46:32 +03:00
javascript_cache_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
locale_site_setting_spec.rb	FEATURE: Add English (UK) as locale (#11768)	2021-01-20 21:32:22 +01:00
mailing_list_mode_site_setting_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
notification_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
optimized_image_spec.rb	DEV: Clean up S3 specs, stubs, and helpers	2020-09-28 12:02:25 +01:00
permalink_spec.rb	DEV: Deprecate Category#url_with_id in favor of Category#url (#9972)	2020-06-18 11:32:14 +03:00
plugin_store_spec.rb	DEV: Upgrading Discourse to Zeitwerk (#8098)	2019-10-02 14:01:53 +10:00
post_action_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
post_action_type_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
post_analyzer_spec.rb	FIX: Improve anchor links (#12683)	2021-04-14 10:27:07 +03:00
post_detail_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
post_mover_spec.rb	FIX: Moderator actions and small actions shouldn't prevent fully merged topics from closing (#13200)	2021-06-02 13:42:03 +04:00
post_reply_key_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
post_reply_spec.rb	DEV: update dependencies and add notes about exceptions	2019-12-06 13:00:28 +11:00
post_spec.rb	DEV: Fix a flaky spec (#13234)	2021-06-01 20:30:47 +02:00
post_timing_spec.rb	FIX: Don't update posts_read_count when the post is from a PM. (#12131)	2021-02-23 11:36:00 -03:00
post_upload_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
published_page_spec.rb	FEATURE: Support for publishing topics as pages (#9364)	2020-04-08 12:52:36 -04:00
quoted_post_spec.rb	DEV: Improve flaky time-sensitive specs (#9141)	2020-03-10 22:13:17 +01:00
remote_theme_spec.rb	FEATURE: Introduce theme/component QUnit tests (take 2) (#12661)	2021-04-12 15:02:58 +03:00
report_spec.rb	DEV: Remove unused comments from tests. (#13241)	2021-06-02 15:33:15 +10:00
reviewable_claimed_topic_spec.rb	FIX: Don't log a claimed topic database error during tests	2020-01-09 12:32:05 -05:00
reviewable_flagged_post_spec.rb	FIX: Recalculate scores only when approving or transitioning to pending. (#13009)	2021-05-10 14:09:04 -03:00
reviewable_history_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
reviewable_post_spec.rb	FEATURE: Review every post using the review queue. (#12734)	2021-04-21 08:41:36 -03:00
reviewable_queued_post_spec.rb	FEATURE: Navigate to an approved queued topic from the review queue. (#12841)	2021-05-26 15:43:18 -03:00
reviewable_score_spec.rb	FIX: Recalculate scores only when approving or transitioning to pending. (#13009)	2021-05-10 14:09:04 -03:00
reviewable_spec.rb	FEATURE: Show stale reviewable to other clients (#13114)	2021-05-26 09:47:35 +10:00
reviewable_user_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
s3_region_site_setting_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
screened_email_spec.rb	FEATURE: when blocking emails prefer blocking canonical	2020-04-24 14:09:51 +10:00
screened_ip_address_spec.rb	FIX: use allowlist and blocklist terminology (#10209)	2020-07-27 10:23:54 +10:00
screened_url_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
search_log_spec.rb	DEV: s/\$redis/Discourse\.redis (#8431)	2019-12-03 10:05:53 +01:00
site_setting_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
site_spec.rb	UX: Improve color scheme choices in user prefs (#11656)	2021-01-07 11:15:38 -05:00
skipped_email_log_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
stylesheet_cache_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
tag_group_spec.rb	FIX: remove parent tag from tag group	2020-03-13 12:25:58 -04:00
tag_spec.rb	FIX: URL encode tag name (#11393)	2020-12-02 12:36:41 +05:30
tag_user_spec.rb	FIX: Wrong scope used for notification levels user serializer (#13039)	2021-05-14 09:45:14 +10:00
theme_field_spec.rb	FEATURE: Introduce theme/component QUnit tests (take 2) (#12661)	2021-04-12 15:02:58 +03:00
theme_modifier_set_spec.rb	DEV: Allow plugins to add theme modifiers via db migrations (#9192)	2020-03-12 16:35:28 +00:00
theme_spec.rb	FEATURE: Allow theme tests to be run in production (take 2) (#12845)	2021-04-28 23:12:08 +03:00
top_menu_item_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
top_topic_spec.rb	DEV: correct spec failures in PG 12	2019-11-26 16:39:14 +11:00
topic_allowed_user_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
topic_converter_spec.rb	FIX: Limit personal message participants when converting from topic (#9343)	2020-04-03 16:42:01 +01:00
topic_embed_spec.rb	FIX: prevents malformed href to crash TopicEmbed (#12910)	2021-04-30 11:10:19 +02:00
topic_featured_users_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
topic_group_spec.rb	FIX: Constraint error when inserting the same topic group twice	2019-12-12 13:10:46 -05:00
topic_invite_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
topic_link_click_spec.rb	DEV: Clean up S3 specs, stubs, and helpers	2020-09-28 12:02:25 +01:00
topic_link_spec.rb	FIX: PG::StringDataRightTruncation when linking posts (#13134)	2021-06-02 15:27:04 +04:00
topic_list_spec.rb	FIX: new-topic route with sub-category and tags were broken (#12503)	2021-03-24 19:54:29 +05:30
topic_participants_summary_spec.rb	DEV: Better topic participants summary spec	2019-11-18 09:43:14 -05:00
topic_posters_summary_spec.rb	Fix i18n issues reported on Crowdin (#11747)	2021-02-02 10:50:04 +01:00
topic_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
topic_tag_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
topic_thumbnail_spec.rb	PERF: we don't need to use a huge image to test thumbnails (#11025)	2020-10-27 12:39:52 +11:00
topic_timer_spec.rb	FIX: Bump max topic timer duration to 20 years (#12107)	2021-02-18 11:52:30 +10:00
topic_tracking_state_spec.rb	FEATURE: Always show tag dropdown when tagging is enabled (#12209)	2021-03-10 21:13:15 -05:00
topic_user_spec.rb	PERF: Async notify users after inviting group (#12697)	2021-04-14 19:30:51 +03:00
topic_view_item_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
translation_override_spec.rb	FIX: error overriding user notification string with valid keys (#12510)	2021-03-24 15:58:24 -04:00
trust_level3_requirements_spec.rb	DEV: Update tl3 spec to remove hard-coded primary keys	2020-04-17 17:24:14 +01:00
trust_level_and_staff_setting_spec.rb	FIX: Don't store translated trust level names in anonymous cache (#13224)	2021-06-01 22:11:48 +02:00
trust_level_setting_spec.rb	FIX: Don't store translated trust level names in anonymous cache (#13224)	2021-06-01 22:11:48 +02:00
unsubscribe_key_spec.rb	DEV: Upgrading Discourse to Zeitwerk (#8098)	2019-10-02 14:01:53 +10:00
upload_spec.rb	FEATURE: Use path from existing URL of uploads and optimized images (#13177)	2021-05-27 17:42:25 +02:00
user_action_spec.rb	FIX: Correctly publish messages unconditionally to admins (#13053)	2021-05-20 16:58:27 +10:00
user_api_key_spec.rb	REFACTOR: Introduce RouteMatcher class	2020-10-19 10:40:55 +01:00
user_archived_message_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
user_auth_token_spec.rb	DEV: Improve flaky time-sensitive specs (#9141)	2020-03-10 22:13:17 +01:00
user_avatar_spec.rb	FIX: reset gravatar cache by adding random param to URL (#9370)	2020-04-08 07:35:42 +10:00
user_badge_spec.rb	PERF: Cache ranks for featured badges, to simplify user serialization (#8698)	2020-01-14 14:26:49 +00:00
user_bookmark_list_spec.rb	FIX: Add bookmark limits (#11725)	2021-01-19 08:53:49 +10:00
user_email_spec.rb	FIX: : trigger user_updated event only if email changed after user creation.	2020-07-16 18:21:30 +05:30
user_export_spec.rb	REVERT: DEV: should ignore missing post uploads when a user export destroyed	2019-07-25 19:41:25 +05:30
user_field_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
user_history_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
user_notification_schedule_spec.rb	DEV: Upgrade Rails to 6.1.3.1 (#12688)	2021-04-21 12:36:32 +03:00
user_option_spec.rb	FEATURE: add new user option skip_new_user_tips. (#10437)	2020-08-14 19:10:56 +05:30
user_profile_spec.rb	FIX: Make sure rel attributes are correctly set. (#10645)	2020-09-10 12:59:51 -03:00
user_profile_view_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
user_search_spec.rb	FIX: only de-prioritise exact matches in mentions (#11843)	2021-01-25 21:27:15 +01:00
user_second_factor_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
user_spec.rb	DEV: Fix flaky specs (#13226)	2021-06-01 14:38:55 +02:00
user_stat_spec.rb	PERF: Keep track of first unread PM and first unread group PM for user.	2020-09-09 14:05:41 +08:00
user_summary_spec.rb	FIX: Ensure the top 6 categories are shown in the user summary (#12691)	2021-04-15 11:05:03 +01:00
user_visit_spec.rb	DEV: Prefabrication (test optimization) (#7414)	2019-05-07 13:12:20 +10:00
username_validator_spec.rb	DEV: Correct typos and spelling mistakes (#12812)	2021-05-21 11:43:47 +10:00
watched_word_spec.rb	DEV: Improve flaky time-sensitive specs (#9141)	2020-03-10 22:13:17 +01:00
web_crawler_request_spec.rb	DEV: s/\$redis/Discourse\.redis (#8431)	2019-12-03 10:05:53 +01:00
web_hook_event_spec.rb	DEV: use #frozen_string_literal: true on all spec	2019-04-30 10:27:42 +10:00
web_hook_spec.rb	FIX: Do not call :post_edited webhook twice when editing OP (#13112)	2021-05-24 09:10:22 +10:00