mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 13:09:33 -06:00
3b6d4c830f
We were adding the custom scheme as a symbol, but trying to delete the string. Which would result in the symbol to not be removed. This was causing errors in others test: ``` Error encountered while proccessing /admin/color_schemes.json I18n::MissingTranslationData: Translation missing: en.color_schemes.baseschemewithnohighlightcolor ``` Reproducible with (probably possible to have a simpler repro): ``` bundle exec rspec --order random:27167 spec/integration/invalid_request_spec.rb spec/integration/spam_rules_spec.rb spec/jobs/bulk_invite_spec.rb spec/jobs/change_display_name_spec.rb spec/jobs/cleanup_imap_sync_log_spec.rb spec/jobs/download_backup_email_spec.rb spec/jobs/fix_primary_emails_for_staged_users_spec.rb spec/jobs/fix_s3_etags_spec.rb spec/jobs/pending_users_reminder_spec.rb spec/jobs/periodical_updates_spec.rb spec/jobs/pull_hotlinked_images_spec.rb spec/jobs/regular/group_smtp_email_spec.rb spec/jobs/reindex_search_spec.rb spec/jobs/update_topic_hot_scores_spec.rb spec/jobs/user_email_spec.rb spec/lib/admin_confirmation_spec.rb spec/lib/backup_restore/database_restorer_multisite_spec.rb spec/lib/backup_restore/system_interface_spec.rb spec/lib/bookmark_reminder_notification_handler_spec.rb spec/lib/color_math_spec.rb spec/lib/content_buffer_spec.rb spec/lib/discourse_spec.rb spec/lib/discourse_tagging_spec.rb spec/lib/discourse_webauthn/registration_service_spec.rb spec/lib/email/renderer_spec.rb spec/lib/email_updater_spec.rb spec/lib/ember_cli_spec.rb spec/lib/feed_element_installer_spec.rb spec/lib/file_helper_spec.rb spec/lib/final_destination/resolver_spec.rb spec/lib/freedom_patches/schema_migration_details_spec.rb spec/lib/guardian/post_guardian_spec.rb spec/lib/guardian/topic_guardian_spec.rb spec/lib/message_id_service_spec.rb spec/lib/onebox/domain_checker_spec.rb spec/lib/onebox/engine/google_maps_onebox_spec.rb spec/lib/onebox/engine/google_play_app_onebox_spec.rb spec/lib/onebox/engine/json_spec.rb spec/lib/onebox/engine/reddit_media_onebox_spec.rb spec/lib/onebox/engine/video_onebox_spec.rb spec/lib/onebox/engine/wikipedia_onebox_spec.rb spec/lib/onebox/engine/wistia_onebox_spec.rb spec/lib/post_destroyer_spec.rb spec/lib/post_locker_spec.rb spec/lib/s3_helper_spec.rb spec/lib/s3_inventory_spec.rb spec/lib/scss_checker_spec.rb spec/lib/site_icon_manager_spec.rb spec/lib/site_setting_extension_multisite_spec.rb spec/lib/summarization/base_spec.rb spec/lib/trashable_spec.rb spec/lib/validators/category_search_priority_weights_validator_spec.rb spec/lib/validators/max_username_length_validator_spec.rb spec/lib/validators/regex_presence_validator_spec.rb spec/lib/validators/regexp_list_validator_spec.rb spec/lib/validators/topic_title_length_validator_spec.rb spec/lib/validators/url_validator_spec.rb spec/lib/work_queue_spec.rb spec/mailers/test_mailer_spec.rb spec/mailers/version_mailer_spec.rb spec/models/badge_grouping_spec.rb spec/models/category_featured_topic_spec.rb spec/models/color_scheme_spec.rb spec/models/flag_spec.rb spec/models/given_daily_like_spec.rb spec/models/plugin_store_spec.rb spec/models/screened_url_spec.rb spec/models/site_setting_spec.rb spec/models/tag_spec.rb spec/models/theme_svg_sprite_spec.rb spec/models/top_menu_item_spec.rb spec/models/topic_allowed_user_spec.rb spec/models/topic_converter_spec.rb spec/models/topic_timer_spec.rb spec/models/translation_override_spec.rb spec/models/user_archived_message_spec.rb spec/models/user_email_spec.rb spec/models/user_search_spec.rb spec/models/user_status_spec.rb spec/models/web_hook_event_spec.rb spec/multisite/pausable_multisite_spec.rb spec/multisite/pausable_spec.rb spec/requests/about_controller_spec.rb spec/requests/admin/backups_controller_spec.rb spec/requests/admin/color_schemes_controller_spec.rb spec/requests/admin/email_templates_controller_spec.rb spec/requests/admin/form_templates_controller_spec.rb spec/requests/admin/screened_ip_addresses_controller_spec.rb spec/requests/admin/site_texts_controller_spec.rb spec/requests/api/categories_spec.rb spec/requests/api/site_spec.rb spec/requests/api/tags_spec.rb spec/requests/api/uploads_spec.rb spec/requests/api/users_spec.rb spec/requests/associate_accounts_controller_spec.rb spec/requests/badges_controller_spec.rb spec/requests/csp_reports_controller_spec.rb spec/requests/edit_directory_columns_controller_spec.rb spec/requests/slugs_controller_spec.rb spec/requests/steps_controller_spec.rb spec/requests/stylesheets_controller_spec.rb spec/requests/topic_view_stats_controller_spec.rb spec/requests/user_avatars_controller_spec.rb spec/requests/users_controller_spec.rb spec/script/import_scripts/vanilla_body_parser_spec.rb spec/serializers/basic_reviewable_queued_post_serializer_spec.rb spec/serializers/found_user_serializer_spec.rb spec/serializers/reviewable_flagged_post_serializer_spec.rb spec/serializers/reviewable_queued_post_serializer_spec.rb spec/serializers/reviewable_user_serializer_spec.rb spec/serializers/theme_objects_setting_metadata_serializer_spec.rb spec/serializers/topic_tracking_state_item_serializer_spec.rb spec/serializers/user_summary_serializer_spec.rb spec/serializers/user_with_custom_fields_serializer_spec.rb spec/services/color_scheme_revisor_spec.rb spec/services/email_settings_exception_handler_spec.rb spec/services/notification_emailer_spec.rb spec/services/problem_check/email_polling_errored_recently_spec.rb spec/services/problem_check/missing_mailgun_api_key_spec.rb spec/services/problem_check/unreachable_themes_spec.rb spec/services/site_settings_spec.rb spec/services/topic_timestamp_changer_spec.rb spec/services/username_changer_spec.rb ``` |
||
|---|---|---|
| .. | ||
| about_spec.rb | ||
| admin_dashboard_data_spec.rb | ||
| admin_notice_spec.rb | ||
| api_key_scope_spec.rb | ||
| api_key_spec.rb | ||
| application_request_spec.rb | ||
| associated_group_spec.rb | ||
| badge_grouping_spec.rb | ||
| badge_spec.rb | ||
| badge_type_spec.rb | ||
| bookmark_spec.rb | ||
| category_featured_topic_spec.rb | ||
| category_group_spec.rb | ||
| category_list_spec.rb | ||
| category_setting_spec.rb | ||
| category_spec.rb | ||
| category_tag_stat_spec.rb | ||
| category_user_spec.rb | ||
| child_theme_spec.rb | ||
| color_scheme_color_spec.rb | ||
| color_scheme_spec.rb | ||
| developer_spec.rb | ||
| digest_email_site_setting_spec.rb | ||
| directory_item_spec.rb | ||
| discourse_connect_spec.rb | ||
| do_not_disturb_timing_spec.rb | ||
| draft_sequence_spec.rb | ||
| draft_spec.rb | ||
| email_change_request_spec.rb | ||
| email_log_spec.rb | ||
| email_token_spec.rb | ||
| embeddable_host_spec.rb | ||
| embeddable_host_tag_spec.rb | ||
| emoji_spec.rb | ||
| flag_spec.rb | ||
| form_template_spec.rb | ||
| given_daily_like_spec.rb | ||
| global_setting_spec.rb | ||
| group_archived_message_spec.rb | ||
| group_associated_group_spec.rb | ||
| group_history_spec.rb | ||
| group_request_spec.rb | ||
| group_spec.rb | ||
| group_user_spec.rb | ||
| incoming_link_spec.rb | ||
| incoming_links_report_spec.rb | ||
| invite_redeemer_spec.rb | ||
| invite_spec.rb | ||
| javascript_cache_spec.rb | ||
| locale_site_setting_spec.rb | ||
| mailing_list_mode_site_setting_spec.rb | ||
| notification_spec.rb | ||
| optimized_image_spec.rb | ||
| permalink_spec.rb | ||
| plugin_store_spec.rb | ||
| post_action_spec.rb | ||
| post_action_type_spec.rb | ||
| post_analyzer_spec.rb | ||
| post_detail_spec.rb | ||
| post_mover_spec.rb | ||
| post_reply_key_spec.rb | ||
| post_reply_spec.rb | ||
| post_revision_spec.rb | ||
| post_spec.rb | ||
| post_stripper_spec.rb | ||
| post_timing_spec.rb | ||
| private_message_topic_tracking_state_spec.rb | ||
| problem_check_tracker_spec.rb | ||
| published_page_spec.rb | ||
| quoted_post_spec.rb | ||
| remote_theme_spec.rb | ||
| report_spec.rb | ||
| reviewable_claimed_topic_spec.rb | ||
| reviewable_flagged_post_spec.rb | ||
| reviewable_history_spec.rb | ||
| reviewable_post_spec.rb | ||
| reviewable_queued_post_spec.rb | ||
| reviewable_score_spec.rb | ||
| reviewable_spec.rb | ||
| reviewable_user_spec.rb | ||
| s3_region_site_setting_spec.rb | ||
| screened_email_spec.rb | ||
| screened_ip_address_spec.rb | ||
| screened_url_spec.rb | ||
| search_log_spec.rb | ||
| sidebar_section_link_spec.rb | ||
| sidebar_section_spec.rb | ||
| sidebar_url_spec.rb | ||
| site_setting_spec.rb | ||
| site_spec.rb | ||
| sitemap_spec.rb | ||
| skipped_email_log_spec.rb | ||
| stylesheet_cache_spec.rb | ||
| tag_group_spec.rb | ||
| tag_spec.rb | ||
| tag_user_spec.rb | ||
| theme_field_spec.rb | ||
| theme_modifier_set_spec.rb | ||
| theme_setting_spec.rb | ||
| theme_settings_migration_spec.rb | ||
| theme_spec.rb | ||
| theme_svg_sprite_spec.rb | ||
| top_menu_item_spec.rb | ||
| top_topic_spec.rb | ||
| topic_allowed_user_spec.rb | ||
| topic_converter_spec.rb | ||
| topic_embed_spec.rb | ||
| topic_featured_users_spec.rb | ||
| topic_group_spec.rb | ||
| topic_hot_scores_spec.rb | ||
| topic_invite_spec.rb | ||
| topic_link_click_spec.rb | ||
| topic_link_spec.rb | ||
| topic_list_spec.rb | ||
| topic_participant_groups_summary_spec.rb | ||
| topic_participants_summary_spec.rb | ||
| topic_posters_summary_spec.rb | ||
| topic_spec.rb | ||
| topic_tag_spec.rb | ||
| topic_thumbnail_spec.rb | ||
| topic_timer_spec.rb | ||
| topic_tracking_state_spec.rb | ||
| topic_user_spec.rb | ||
| topic_view_item_spec.rb | ||
| translation_override_spec.rb | ||
| trust_level3_requirements_spec.rb | ||
| trust_level_and_staff_setting_spec.rb | ||
| trust_level_setting_spec.rb | ||
| unsubscribe_key_spec.rb | ||
| upload_reference_spec.rb | ||
| upload_spec.rb | ||
| user_action_spec.rb | ||
| user_api_key_spec.rb | ||
| user_archived_message_spec.rb | ||
| user_associated_group_spec.rb | ||
| user_auth_token_spec.rb | ||
| user_avatar_spec.rb | ||
| user_badge_spec.rb | ||
| user_bookmark_list_spec.rb | ||
| user_email_spec.rb | ||
| user_export_spec.rb | ||
| user_field_spec.rb | ||
| user_history_spec.rb | ||
| user_notification_schedule_spec.rb | ||
| user_option_spec.rb | ||
| user_profile_spec.rb | ||
| user_profile_view_spec.rb | ||
| user_search_spec.rb | ||
| user_second_factor_spec.rb | ||
| user_security_key_spec.rb | ||
| user_spec.rb | ||
| user_stat_spec.rb | ||
| user_status_spec.rb | ||
| user_summary_spec.rb | ||
| user_visit_spec.rb | ||
| username_validator_spec.rb | ||
| watched_word_group_spec.rb | ||
| watched_word_spec.rb | ||
| web_crawler_request_spec.rb | ||
| web_hook_event_spec.rb | ||
| web_hook_event_type_spec.rb | ||
| web_hook_spec.rb | ||