mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 02:40:53 -06:00
7ff889574d
This adds rubocop-rspec, and enables some cops that were either already passing or are passing now, after fixing them in this commit. Some new cops are disabled for now, with annotation: "TODO" or "To be decided". Those either need to be discussed first, or require manual changes, or the number of found and fixed offenses is too large to bundle them up in a single PR. Includes: * DEV: Update rubocop's `TargetRubyVersion` to 2.6 * DEV: Enable RSpec/VoidExpect * DEV: Enable RSpec/SharedContext * DEV: Enable RSpec/EmptyExampleGroup (Removed an obsolete empty spec file) * DEV: Enable RSpec/ItBehavesLike * DEV: Remove RSpec/ScatteredLet (It's too strict, as it doesn't recognize fab! as a let-like) * DEV: Remove RSpec/MultipleExpectations
175 lines
5.8 KiB
Ruby
175 lines
5.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'seed_data/categories'
|
|
|
|
describe SeedData::Categories do
|
|
subject { SeedData::Categories.with_default_locale }
|
|
|
|
def create_category(name = "staff_category_id")
|
|
subject.create(site_setting_names: [name])
|
|
end
|
|
|
|
def description_post(category)
|
|
Post.find_by(topic_id: category.topic_id)
|
|
end
|
|
|
|
describe "#create" do
|
|
def permissions(group, type)
|
|
{
|
|
group_id: Group::AUTO_GROUPS[group],
|
|
permission_type: CategoryGroup.permission_types[type]
|
|
}
|
|
end
|
|
|
|
it "creates a missing category" do
|
|
expect { create_category }
|
|
.to change { Category.count }.by(1)
|
|
.and change { Topic.count }.by(1)
|
|
|
|
category = Category.last
|
|
expect(category.name).to eq(I18n.t("staff_category_name"))
|
|
expect(category.topic_id).to be_present
|
|
expect(category.user_id).to eq(Discourse::SYSTEM_USER_ID)
|
|
expect(category.category_groups.count).to eq(1)
|
|
expect(category.category_groups.first).to have_attributes(permissions(:staff, :full))
|
|
expect(Topic.exists?(category.topic_id)).to eq(true)
|
|
expect(description_post(category).raw).to eq(I18n.t("staff_category_description"))
|
|
expect(SiteSetting.staff_category_id).to eq(category.id)
|
|
end
|
|
|
|
context "with existing category" do
|
|
before { create_category }
|
|
|
|
it "does not create another category" do
|
|
expect { create_category }
|
|
.to change { Category.count }.by(0)
|
|
.and change { Topic.count }.by(0)
|
|
end
|
|
|
|
it "creates a missing 'About Category' topic" do
|
|
category = Category.last
|
|
Topic.delete(category.topic_id)
|
|
|
|
expect { create_category }
|
|
.to change { Category.count }.by(0)
|
|
.and change { Topic.count }.by(1)
|
|
|
|
category.reload
|
|
expect(description_post(category).raw).to eq(I18n.t("staff_category_description"))
|
|
end
|
|
|
|
it "overwrites permissions when permissions are forced" do
|
|
category = Category.last
|
|
category.set_permissions(everyone: :full)
|
|
category.save!
|
|
|
|
expect(category.category_groups.count).to eq(0)
|
|
|
|
expect { create_category }
|
|
.to change { CategoryGroup.count }.by(1)
|
|
|
|
category.reload
|
|
expect(category.category_groups.count).to eq(1)
|
|
expect(category.category_groups.first).to have_attributes(permissions(:staff, :full))
|
|
end
|
|
|
|
it "overwrites permissions even when subcategory has less restrictive permissions" do
|
|
category = Category.last
|
|
category.set_permissions(everyone: :full)
|
|
category.save!
|
|
|
|
group = Fabricate(:group)
|
|
|
|
subcategory = Fabricate(:category, name: "child", parent_category_id: category.id)
|
|
subcategory.set_permissions(group => :full)
|
|
subcategory.save!
|
|
|
|
expect { create_category }
|
|
.to change { CategoryGroup.count }.by(1)
|
|
|
|
category.reload
|
|
expect(category.category_groups.count).to eq(1)
|
|
expect(category.category_groups.first).to have_attributes(permissions(:staff, :full))
|
|
end
|
|
end
|
|
|
|
it "does not override permissions of existing category when not forced" do
|
|
create_category("lounge_category_id")
|
|
|
|
category = Category.last
|
|
category.set_permissions(trust_level_2: :full)
|
|
category.save!
|
|
|
|
expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full))
|
|
|
|
expect { create_category("lounge_category_id") }
|
|
.to change { CategoryGroup.count }.by(0)
|
|
|
|
category.reload
|
|
expect(category.category_groups.first).to have_attributes(permissions(:trust_level_2, :full))
|
|
end
|
|
end
|
|
|
|
describe "#update" do
|
|
def update_category(name = "staff_category_id", skip_changed: false)
|
|
subject.update(site_setting_names: [name], skip_changed: skip_changed)
|
|
end
|
|
|
|
before do
|
|
create_category
|
|
Category.last.update!(name: "Foo", slug: "foo")
|
|
end
|
|
|
|
it "updates an existing category" do
|
|
category = Category.last
|
|
description_post(category).revise(Discourse.system_user, raw: "Description for Foo category.")
|
|
|
|
update_category
|
|
|
|
category.reload
|
|
expect(category.name).to eq(I18n.t("staff_category_name"))
|
|
expect(category.slug).to eq(Slug.for(I18n.t("staff_category_name")))
|
|
expect(description_post(category).raw).to eq(I18n.t("staff_category_description"))
|
|
end
|
|
|
|
it "skips category when `skip_changed` is true and description was changed" do
|
|
category = Category.last
|
|
description_post(category).revise(Fabricate(:admin), raw: "Description for Foo category.")
|
|
|
|
update_category(skip_changed: true)
|
|
|
|
category.reload
|
|
expect(category.name).to eq("Foo")
|
|
expect(category.slug).to eq("foo")
|
|
expect(description_post(category).raw).to eq("Description for Foo category.")
|
|
end
|
|
|
|
it "works when the category name is already used by another category" do
|
|
Fabricate(:category, name: I18n.t("staff_category_name"))
|
|
|
|
update_category
|
|
|
|
category = Category.find(SiteSetting.staff_category_id)
|
|
expect(category.name).to_not eq(I18n.t("staff_category_name"))
|
|
expect(category.name).to start_with(I18n.t("staff_category_name"))
|
|
end
|
|
end
|
|
|
|
describe "#reseed_options" do
|
|
it "returns only existing categories as options" do
|
|
create_category("meta_category_id")
|
|
create_category("lounge_category_id")
|
|
Post.last.revise(Fabricate(:admin), raw: "Hello world")
|
|
|
|
expected_options = [
|
|
{ id: "uncategorized_category_id", name: I18n.t("uncategorized_category_name"), selected: true },
|
|
{ id: "meta_category_id", name: I18n.t("meta_category_name"), selected: true },
|
|
{ id: "lounge_category_id", name: I18n.t("vip_category_name"), selected: false }
|
|
]
|
|
|
|
expect(subject.reseed_options).to eq(expected_options)
|
|
end
|
|
end
|
|
end
|