mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 13:09:33 -06:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
77 lines
2.0 KiB
Ruby
77 lines
2.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe Jobs::PendingReviewablesReminder do
|
|
let(:job) { described_class.new }
|
|
|
|
def create_flag(created_at)
|
|
PostActionCreator.create(Fabricate(:user), Fabricate(:post), :spam, created_at: created_at).reviewable
|
|
end
|
|
|
|
def execute
|
|
job.tap { job.execute({}) }
|
|
end
|
|
|
|
it "doesn't notify when there are no flags" do
|
|
expect(execute.sent_reminder).to eq(false)
|
|
end
|
|
|
|
context "notify_about_flags_after is 0" do
|
|
before { SiteSetting.notify_about_flags_after = 0 }
|
|
|
|
it "never notifies" do
|
|
create_flag(50.hours.ago)
|
|
expect(execute.sent_reminder).to eq(false)
|
|
end
|
|
end
|
|
|
|
context "notify_about_flags_after is 48" do
|
|
before do
|
|
SiteSetting.notify_about_flags_after = 48
|
|
described_class.clear_key
|
|
end
|
|
|
|
after do
|
|
described_class.clear_key
|
|
end
|
|
|
|
it "doesn't send message when flags are less than 48 hours old" do
|
|
create_flag(47.hours.ago)
|
|
expect(execute.sent_reminder).to eq(false)
|
|
end
|
|
|
|
it "doesn't send a message if there are no new flags older than 48 hours old" do
|
|
old_reviewable = create_flag(50.hours.ago)
|
|
create_flag(47.hours.ago)
|
|
|
|
described_class.last_notified_id = old_reviewable.id
|
|
execute
|
|
expect(job.sent_reminder).to eq(false)
|
|
expect(described_class.last_notified_id).to eq(old_reviewable.id)
|
|
end
|
|
|
|
it "sends message when there is a flag older than 48 hours" do
|
|
create_flag(49.hours.ago)
|
|
expect(execute.sent_reminder).to eq(true)
|
|
end
|
|
|
|
context "min_score_default_visibility" do
|
|
before do
|
|
create_flag(49.hours.ago)
|
|
create_flag(51.hours.ago)
|
|
end
|
|
|
|
it "doesn't send a message when min_score_default_visibility is not met" do
|
|
SiteSetting.min_score_default_visibility = 3.0
|
|
expect(execute.sent_reminder).to eq(false)
|
|
end
|
|
|
|
it "sends a message when min_score_default_visibility is met" do
|
|
SiteSetting.min_score_default_visibility = 2.0
|
|
expect(execute.sent_reminder).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
end
|