discourse/lib
Martin Brennan 5dc45b5dcf
FIX: Secure upload post processing race condition (#23968)
* FIX: Secure upload post processing race condition

This commit fixes a couple of issues.

A little background -- when uploads are created in the composer
for posts, regardless of whether the upload will eventually be
marked secure or not, if secure_uploads is enabled we always mark
the upload secure at first. This is so the upload is by default
protected, regardless of post type (regular or PM) or category.

This was causing issues in some rare occasions though because
of the order of operations of our post creation and processing
pipeline. When creating a post, we enqueue a sidekiq job to
post-process the post which does various things including
converting images to lightboxes. We were also enqueuing a job
to update the secure status for all uploads in that post.

Sometimes the secure status job would run before the post process
job, marking uploads as _not secure_ in the background and changing
their ACL before the post processor ran, which meant the users
would see a broken image in their posts. This commit fixes that issue
by always running the upload security changes inline _within_ the
cooked_post_processor job.

The other issue was that the lightbox wrapper link for images in
the post would end up with a URL like this:

```
href="/secure-uploads/original/2X/4/4e1f00a40b6c952198bbdacae383ba77932fc542.jpeg"
```

Since we weren't actually using the `upload.url` to pass to
`UrlHelper.cook_url` here, we weren't converting this href to the CDN
URL if the post was not in a secure context (the UrlHelper does not
know how to convert a secure-uploads URL to a CDN one). Now we
always end up with the correct lightbox href. This was less of an issue
than the other one, since the secure-uploads URL works even when the
upload has become non-secure, but it was a good inconsistency to fix
anyway.
2023-10-18 23:48:01 +00:00
..
action_dispatch/session DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
auth DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
autospec DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
backup_restore FEATURE: allow S3 ACLs to be disabled (#21769) 2023-06-06 15:47:40 +10:00
common_passwords DEV: Upgrade to Rails 7 2022-04-28 11:51:03 +02:00
compression DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
content_security_policy SECURITY: Don't reuse CSP nonce between anonymous requests 2023-07-28 12:53:44 +01:00
demon DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
discourse_dev DEV: Don't run dev-only code in specs (#23427) 2023-09-06 02:14:57 +02:00
discourse_webauthn DEV: Add routes and controller actions for passkeys (2/3) (#23587) 2023-10-11 14:36:54 -04:00
email FIX: Properly attach secure images to email for non-secure uploads (#23865) 2023-10-17 14:08:21 +10:00
email_controller_helper FIX: Unsubscribing via key associated with deleted topic (#20275) 2023-02-16 10:47:01 +00:00
emoji DEV: Update javascript:update_constants rake task following template colocation (#20365) 2023-02-20 06:20:47 +03:00
faker DEV: Don't run dev-only code in specs (#23427) 2023-09-06 02:14:57 +02:00
file_store DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
final_destination DEV: Handle SSL errors in push notification pusher (#22771) 2023-07-25 15:01:02 +08:00
freedom_patches UX: Add show more button to long post queued reviewables (#23075) 2023-08-14 10:11:30 -07:00
generators/rails DEV: removes plugin generator (#14101) 2021-08-20 11:29:06 +02:00
guardian SECURITY: Hide user profiles from public 2023-10-16 10:34:32 -04:00
i18n DEV: i18n:check rake task was broken on Ruby 3.1 (#20103) 2023-01-31 16:53:24 +01:00
imap DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
import DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
import_export DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
javascripts DEV: Remove vendored copy of messageformat (#21658) 2023-05-19 10:59:04 +01:00
middleware DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921) 2023-08-02 10:46:37 +08:00
migration DEV: Correct ambiguous name (#21189) 2023-04-20 11:28:08 -05:00
onebox DEV: Replace custom Onebox symbolize_keys implementation with ActiveSupport (#23828) 2023-10-09 09:32:09 +02:00
plugin SECURITY: Prevent arbitrary topic custom fields from being set 2023-10-16 10:34:35 -04:00
pretty_text DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
rate_limiter DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
reviewable FIX: Don't mix up action labels between different reviewables (#23365) 2023-09-06 10:57:30 +08:00
scheduler SECURITY: Don't allow a particular site to monopolize the defer queue 2023-07-28 12:53:51 +01:00
search DEV: Make search results blurb non-pg headlines setting dependent (#20939) 2023-04-03 11:09:36 -03:00
second_factor FEATURE: Add prompt=none functionality to SSO Provider protocol (#22393) 2023-09-28 12:53:28 +01:00
seed_data FIX: Use category hashtag instead of link in discourse_welcome_topic.body (#22875) 2023-08-01 13:53:23 +02:00
sidekiq DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
site_settings FEATURE: Add new site setting type for tag-group lists (#21993) 2023-06-09 11:02:55 -04:00
stylesheet FEATURE: Serve RTL versions of admin and plugins CSS bundles for RTL locales (#21876) 2023-06-01 05:27:11 +03:00
summarization FEATURE: Stream topic summaries. (#23065) 2023-08-11 15:08:49 -03:00
tasks DEV: Precompile the transpiler before themes:update (#23997) 2023-10-19 01:00:23 +02:00
theme_store DEV: Filter files included by theme DirectoryImporter (#23842) 2023-10-09 12:03:02 +01:00
topic_query FEATURE: new watched_precedence_over_muted setting (#22252) 2023-06-27 14:49:34 +10:00
turbo_tests DEV: Add process pid to bin/turbo_tests --format documentation output (#22429) 2023-07-05 11:47:35 +08:00
validators FEATURE: support a description attribute on form template fields (#23744) 2023-10-04 17:51:53 -03:00
wizard DEV: Cleanup unused wizard illustrations (#23659) 2023-09-26 10:34:38 +08:00
admin_confirmation.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
admin_constraint.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
admin_user_index_query.rb DEV: Remove deprecated ascending param from AdminUserIndexQuery (#22741) 2023-07-24 09:37:18 +08:00
age_words.rb DEV: Move distance_of_time_in_words/time_ago_in_words (#21745) 2023-05-25 14:53:59 +02:00
archetype.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
auth.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
backup_restore.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
badge_posts_view_manager.rb DEV: stop freezing frozen strings 2020-04-30 16:48:53 +10:00
badge_queries.rb FIX: Fixed getting badges from inviting youself (#19778) 2023-01-27 12:28:47 +08:00
base62.rb DEV: Correct typos and spelling mistakes (#12812) 2021-05-21 11:43:47 +10:00
bookmark_manager.rb FIX: Bookmark auto delete preference usage and default value (#19707) 2023-01-05 08:43:58 +10:00
bookmark_query.rb SECURITY: Impose a upper bound on limit params in various controllers 2023-07-28 12:53:46 +01:00
bookmark_reminder_notification_handler.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
browser_detection.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
cache.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
canonical_url.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
category_badge.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
chrome_installed_checker.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
color_math.rb UX: Calculate missing hover/selected colors from existing colors (#20105) 2023-02-01 09:55:21 +00:00
comment_migration.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
common_passwords.rb DEV: Fix redis.sadd warnings (#23244) 2023-08-28 12:58:47 +08:00
composer_messages_finder.rb DEV: Ensure don't feed the trolls feature considers active flags only (#22774) 2023-07-25 15:12:22 +08:00
configurable_urls.rb PERF: Cache ToS and Privacy Policy paths (#21860) 2023-06-07 21:31:20 +03:00
content_buffer.rb DEV: Enable unless cops 2023-02-21 10:30:48 +01:00
content_security_policy.rb SECURITY: Don't reuse CSP nonce between anonymous requests 2023-07-28 12:53:44 +01:00
cooked_post_processor.rb FIX: Secure upload post processing race condition (#23968) 2023-10-18 23:48:01 +00:00
cooked_processor_mixin.rb SECURITY: Add FinalDestination::FastImage that's SSRF safe 2023-03-16 15:27:09 -06:00
crawler_detection.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
csrf_token_verifier.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
current_user.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
custom_renderer.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
db_helper.rb FIX: Make DBHelper.find build valid query (#19408) 2023-01-10 22:38:52 +02:00
directory_helper.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
discourse_connect_base.rb FEATURE: Add prompt=none functionality to SSO Provider protocol (#22393) 2023-09-28 12:53:28 +01:00
discourse_connect_provider.rb FEATURE: Add prompt=none functionality to SSO Provider protocol (#22393) 2023-09-28 12:53:28 +01:00
discourse_dev.rb DEV: move discourse_dev gem to the core. (#13360) 2021-06-14 20:34:44 +05:30
discourse_diff.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
discourse_event.rb DEV: Add :push_notification event and deprecate :post_notification_alert (#22917) 2023-08-02 18:44:19 -03:00
discourse_hub.rb FEATURE: Detect current git "branch" even when a tag is checked out 2023-04-19 15:30:12 +02:00
discourse_ip_info.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
discourse_js_processor.rb DEV: Build theme transpiler in custom envs (#23785) 2023-10-05 02:06:58 +02:00
discourse_logstash_logger.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
discourse_plugin_registry.rb SECURITY: Prevent arbitrary topic custom fields from being set 2023-10-16 10:34:35 -04:00
discourse_redis.rb DEV: Remove Discourse.redis.delete_prefixed (#22103) 2023-06-16 12:44:35 +10:00
discourse_sourcemapping_url_processor.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
discourse_tagging.rb FIX: List parent/child tags correctly for categories restricted to tag groups (#23708) 2023-10-10 17:30:24 +00:00
discourse_updates.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
discourse_webauthn.rb DEV: Refactor webauthn to support passkeys (1/3) (#23586) 2023-10-03 14:59:28 -04:00
discourse.rb SECURITY: Add limits for themes and theme assets 2023-09-12 15:31:31 -03:00
disk_space.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
distributed_cache.rb Revert "Revert "PERF: Cache each theme field value once (#23192)" (#23354)" (#23356) 2023-08-31 14:12:03 -05:00
distributed_memoizer.rb DEV: Make DistributedMemoizer use DistributedMutex (#16229) 2022-04-05 19:29:58 +02:00
distributed_mutex.rb DEV: reduce amount of errors logged when notifying on flags (#20472) 2023-03-01 08:58:32 +11:00
edit_rate_limiter.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
email_backup_token.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
email_cook.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
email_updater.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
email.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
ember_cli.rb DEV: Correct sourceMappingURL regex (#23504) 2023-09-11 11:39:55 +01:00
encodings.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
enum_site_setting.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
enum.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
excerpt_parser.rb DEV: Update code comment wording (#22861) 2023-07-28 11:47:22 -06:00
external_upload_helpers.rb DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
feed_element_installer.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
feed_item_accessor.rb FIX: Select best link from Atom feed (#15663) 2022-01-21 17:54:18 +02:00
file_helper.rb DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
filter_best_posts.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
final_destination.rb DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
flag_query.rb DEV: Remove deprecated methods (#14885) 2021-11-11 12:21:25 -06:00
flag_settings.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
gaps.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
gc_stat_instrumenter.rb DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921) 2023-08-02 10:46:37 +08:00
git_repo.rb FEATURE: display commit hash for each plugin on /admin/plugins page. (#22176) 2023-06-26 10:09:57 +05:30
git_url.rb SECURITY: Prevent ReDOS by making the SSH url regex unambiguous (#20000) 2023-01-25 18:55:01 +02:00
global_path.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
group_email_credentials_check.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
group_lookup.rb FEATURE: display PM participant group names in the topics list. (#21677) 2023-05-31 19:32:06 +05:30
guardian.rb DEV: Remove unused topic_create_allowed_category_ids (#23463) 2023-09-08 12:03:22 +03:00
has_errors.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
highlight_js.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
hijack.rb SECURITY: Don't allow a particular site to monopolize the defer queue 2023-07-28 12:53:51 +01:00
homepage_constraint.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
html_prettify.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
html_to_markdown.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
http_language_parser.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
image_sizer.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
import_export.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
inline_oneboxer.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
job_time_spacer.rb FEATURE: Auto-remove users without permission from channel (#20344) 2023-03-22 10:19:59 +10:00
js_locale_helper.rb DEV: convert I18n pseudo package into real package (discourse-i18n) (#23867) 2023-10-12 14:44:01 +01:00
json_error.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
letter_avatar.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
markdown_linker.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
mem_info.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
message_bus_diags.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
method_profiler.rb DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921) 2023-08-02 10:46:37 +08:00
mini_sql_multisite_connection.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
mobile_detection.rb SECURITY: Prevent ReDoS in user agent parsing (#20002) 2023-01-25 18:55:33 +02:00
new_post_manager.rb FIX: Keep ReviewableQueuedPosts even with user delete reviewable actions (#22501) 2023-07-18 11:50:31 +00:00
new_post_result.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
notification_levels.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
onebox.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
oneboxer.rb FIX: Do not follow redirects for twitter oneboxes (#22362) 2023-06-30 11:30:03 +01:00
onpdiff.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
password_hasher.rb FEATURE: Persist password hashing algorithm/params in database (#20980) 2023-04-11 10:16:28 +01:00
pbkdf2.rb PERF: Use OpenSSL::KDF for Pbkdf2 implementation (#20982) 2023-04-05 17:00:05 +01:00
permalink_constraint.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
pinned_check.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
plain_text_to_markdown.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
plugin_gem.rb FEATURE: Try to load plugin gems platform variants (#21643) 2023-06-26 15:11:35 -03:00
plugin.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
post_action_creator.rb DEV: Add hooks to allow overriding notify_user behavior (#23850) 2023-10-10 12:21:57 -05:00
post_action_destroyer.rb DEV: Enhance post action handler events (#23027) 2023-08-09 13:55:00 -04:00
post_action_result.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
post_creator.rb FIX: Secure upload post processing race condition (#23968) 2023-10-18 23:48:01 +00:00
post_destroyer.rb FEATURE: granular webhooks (#23070) 2023-10-09 03:35:31 +00:00
post_jobs_enqueuer.rb DEV: Enable unless cops 2023-02-21 10:30:48 +01:00
post_locker.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
post_merger.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
post_revisor.rb FIX: Secure upload post processing race condition (#23968) 2023-10-18 23:48:01 +00:00
presence_channel.rb FIX: Ensure PresenceChannel does not raise error during readonly (#22899) 2023-08-01 09:34:57 +01:00
pretty_text.rb DEV: Prevent videos from preloading metadata (#23807) 2023-10-12 13:47:48 -06:00
promotion.rb FIX: Do not validate email in TL promotion (#20892) 2023-03-30 13:52:10 +10:00
quote_comparer.rb DEV: Correct Style/RedundantReturn rubocop issues (#23052) 2023-08-10 02:03:38 +02:00
quote_rewriter.rb DEV: Update display name in new quote format - Part 2 (#22104) 2023-06-26 11:01:59 +08:00
rake_helpers.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
rate_limiter.rb DEV: Remove Discourse.redis.delete_prefixed (#22103) 2023-06-16 12:44:35 +10:00
read_only_mixin.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
redis_snapshot.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
require_dependency_backward_compatibility.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
retrieve_title.rb DEV: Gracefully handle user avatar download SSRF errors (#21523) 2023-05-12 15:32:02 +08:00
route_format.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
route_matcher.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
rtl.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
s3_cors_rulesets.rb FIX: Update DIRECT_UPLOAD CORS ruleset to include new Amazon signing headers (#23379) 2023-09-04 16:09:52 +10:00
s3_helper.rb DEV: Add S3 upload system specs using minio (#22975) 2023-08-23 11:18:33 +10:00
s3_inventory.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
score_calculator.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
screening_model.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
search.rb FEATURE: allow consumers to parse a search string (#23528) 2023-09-12 16:21:01 +10:00
secure_session.rb DEV: s/\$redis/Discourse\.redis (#8431) 2019-12-03 10:05:53 +01:00
shrink_uploaded_image.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00
sidekiq_logster_reporter.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
site_icon_manager.rb DEV: Move Bookmark modal/component to use d-modal (#22532) 2023-07-17 10:14:17 +10:00
site_setting_extension.rb DEV: Add auto _map extensions for list site settings with no type (#23331) 2023-08-30 16:14:06 +10:00
slug.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
socket_server.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
spam_handler.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
staff_constraint.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
staff_message_format.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
suggested_topics_builder.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
svg_sprite.rb DEV: Bump max theme sprite size to 1MB (#23556) 2023-09-13 15:00:26 +10:00
system_message.rb FIX: Send TL2 promotion message to correct user (#21978) 2023-06-07 22:51:24 +03:00
temporary_db.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
temporary_redis.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
text_cleaner.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
text_sentinel.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
theme_javascript_compiler.rb DEV: Add gjs support for themes (#23473) 2023-10-02 12:36:06 +02:00
theme_modifier_helper.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
theme_settings_manager.rb FIX: Use the default value correctly for theme settings of type uploads (#20541) 2023-03-06 11:41:47 +03:00
theme_settings_parser.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
theme_translation_manager.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
theme_translation_parser.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
timeline_lookup.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
tiny_japanese_segmenter.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
topic_creator.rb SECURITY: Prevent arbitrary topic custom fields from being set 2023-10-16 10:34:35 -04:00
topic_list_responder.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
topic_publisher.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
topic_query_params.rb UX: Various improvements to welcome topic CTA (#21010) 2023-05-12 17:09:40 +03:00
topic_query.rb DEV: Validate before and bumped_before options in TopicQuery (#23451) 2023-09-07 14:38:03 +10:00
topic_retriever.rb FIX: #present -> #presence typo in TopicRetriever (#20509) 2023-03-02 13:05:45 -03:00
topic_subtype.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
topic_upload_security_manager.rb FEATURE: Secure uploads in PMs only (#23398) 2023-09-06 09:39:09 +10:00
topic_view.rb FIX: Missing pending queued posts from topic view (#22838) 2023-07-28 16:16:23 +00:00
topics_bulk_action.rb FIX: Dismissing unread posts did not publish changes to other clients (#22584) 2023-07-13 18:05:56 +08:00
topics_filter.rb DEV: Add order:title filter to experimental /filter route (#22293) 2023-06-28 06:21:56 +08:00
truncate_logs_formatter.rb SECURITY: Add a default limit as to when logs should be truncated 2023-10-16 10:34:38 -04:00
trust_level.rb FIX: recalculating trust levels was not working (#20492) 2023-03-01 15:35:21 +11:00
turbo_tests.rb DEV: Restore the documentation format in system tests (#21471) 2023-05-12 11:13:52 +02:00
twitter_api.rb FIX: Minor Twitter onebox improvements (#22387) 2023-07-03 19:53:12 -03:00
unicorn_logstash_patch.rb DEV: Fix lint. 2020-07-21 15:55:03 +08:00
unread.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
upload_creator.rb DEV: Remove old deprecation warnings where constants already removed (#22140) 2023-06-16 11:26:26 +08:00
upload_fixer.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
upload_markdown.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
upload_recovery.rb FEATURE: allow S3 ACLs to be disabled (#21769) 2023-06-06 15:47:40 +10:00
upload_security.rb FEATURE: Secure uploads in PMs only (#23398) 2023-09-06 09:39:09 +10:00
url_helper.rb SECURITY: Limit URL length for theme remote (#20787) 2023-03-23 12:01:04 +00:00
user_comm_screener.rb DEV: Refactor DM channel creation into new service pattern (#22144) 2023-07-03 10:18:37 +10:00
user_lookup.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
user_name_suggester.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
vary_header.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
version.rb Bump version to v3.2.0.beta3-dev 2023-10-16 11:20:22 -04:00
wizard.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
work_queue.rb SECURITY: Don't allow a particular site to monopolize the defer queue 2023-07-28 12:53:51 +01:00