mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 20:24:05 -06:00
30990006a9
This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging
60 lines
1.6 KiB
Ruby
60 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Admin::UserFieldsController < Admin::AdminController
|
|
|
|
def self.columns
|
|
[:name, :field_type, :editable, :description, :required, :show_on_profile, :show_on_user_card, :position]
|
|
end
|
|
|
|
def create
|
|
field = UserField.new(params.require(:user_field).permit(*Admin::UserFieldsController.columns))
|
|
|
|
field.position = (UserField.maximum(:position) || 0) + 1
|
|
field.required = params[:user_field][:required] == "true"
|
|
update_options(field)
|
|
|
|
json_result(field, serializer: UserFieldSerializer) do
|
|
field.save
|
|
end
|
|
end
|
|
|
|
def index
|
|
user_fields = UserField.all.includes(:user_field_options).order(:position)
|
|
render_serialized(user_fields, UserFieldSerializer, root: 'user_fields')
|
|
end
|
|
|
|
def update
|
|
field_params = params[:user_field]
|
|
field = UserField.where(id: params.require(:id)).first
|
|
|
|
Admin::UserFieldsController.columns.each do |col|
|
|
unless field_params[col].nil?
|
|
field.public_send("#{col}=", field_params[col])
|
|
end
|
|
end
|
|
update_options(field)
|
|
|
|
if field.save
|
|
render_serialized(field, UserFieldSerializer, root: 'user_field')
|
|
else
|
|
render_json_error(field)
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
field = UserField.where(id: params.require(:id)).first
|
|
field.destroy if field.present?
|
|
render json: success_json
|
|
end
|
|
|
|
protected
|
|
|
|
def update_options(field)
|
|
options = params[:user_field][:options]
|
|
if options.present?
|
|
UserFieldOption.where(user_field_id: field.id).delete_all
|
|
field.user_field_options_attributes = options.map { |o| { value: o } }.uniq
|
|
end
|
|
end
|
|
end
|