mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
65cf3230ee
This change fixes an issue with the user group chooser of a tag group's settings. It was impossible to clear any selected groups through the UI. The `setPermissionsGroups` function determines which groups appear selected in the group-chooser based on the passed-in `groupIds` array. It starts with `updatedPermissions` being set to the group permissions as they were prior to the action that called the function. From there, we were correctly adding a group permission to `updatedPermissions` whenever a group appeared in `groupIds`. This addressed newly added groups and also maintained any group permissions that had been set before. The problem was that there was no logic to remove a group permission when the associated group no longer appeared in `groupIds`. If a group isn't included in `groupIds`, we can simply attempt to delete an associated group permission if it exists. |
||
|---|---|---|
| .. | ||
| assets | ||
| controllers | ||
| helpers | ||
| jobs | ||
| mailers | ||
| models | ||
| serializers | ||
| services | ||
| views | ||