mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 10:20:58 -06:00
8e3691d537
Before this change, calling `StyleSheet::Manager.stylesheet_details` for the first time resulted in multiple queries to the database. This is because the code was modelled in a way where each `Theme` was loaded from the database one at a time. This PR restructures the code such that it allows us to load all the theme records in a single query. It also allows us to eager load the required associations upfront. In order to achieve this, I removed the support of loading multiple themes per request. It was initially added to support user selectable theme components but the feature was never completed and abandoned because it wasn't a feature that we thought was worth building.
18 lines
589 B
Ruby
18 lines
589 B
Ruby
# frozen_string_literal: true
|
|
require 'rails_helper'
|
|
|
|
describe ThemeModifierHelper do
|
|
fab!(:theme) { Fabricate(:theme).tap { |t| t.theme_modifier_set.update!(serialize_topic_excerpts: true) } }
|
|
|
|
it "defines a getter for modifiers" do
|
|
tmh = ThemeModifierHelper.new(theme_ids: [theme.id])
|
|
expect(tmh.serialize_topic_excerpts).to eq(true)
|
|
end
|
|
|
|
it "can extract theme ids from a request object" do
|
|
request = Rack::Request.new({ resolved_theme_id: theme.id })
|
|
tmh = ThemeModifierHelper.new(request: request)
|
|
expect(tmh.serialize_topic_excerpts).to eq(true)
|
|
end
|
|
end
|