mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 01:16:38 -06:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
108 lines
3.0 KiB
Ruby
108 lines
3.0 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe SearchController do
|
|
|
|
context "integration" do
|
|
|
|
before do
|
|
ActiveRecord::Base.observers.enable :search_observer
|
|
end
|
|
|
|
it "can search correctly" do
|
|
my_post = Fabricate(:post, raw: 'this is my really awesome post')
|
|
xhr :get, :query, term: 'awesome', include_blurb: true
|
|
|
|
expect(response).to be_success
|
|
data = JSON.parse(response.body)
|
|
expect(data['posts'][0]['id']).to eq(my_post.id)
|
|
expect(data['posts'][0]['blurb']).to eq('this is my really awesome post')
|
|
expect(data['topics'][0]['id']).to eq(my_post.topic_id)
|
|
end
|
|
end
|
|
|
|
|
|
let(:search_context) { {type: 'user', id: 'eviltrout'} }
|
|
|
|
context "basics" do
|
|
let(:guardian) { Guardian.new }
|
|
let(:search) { mock() }
|
|
|
|
before do
|
|
Guardian.stubs(:new).returns(guardian)
|
|
end
|
|
|
|
it 'performs the query' do
|
|
Search.expects(:new).with('test', guardian: guardian).returns(search)
|
|
search.expects(:execute)
|
|
|
|
xhr :get, :query, term: 'test'
|
|
end
|
|
|
|
it 'performs the query with a filter' do
|
|
Search.expects(:new).with('test', guardian: guardian, type_filter: 'topic').returns(search)
|
|
search.expects(:execute)
|
|
|
|
xhr :get, :query, term: 'test', type_filter: 'topic'
|
|
end
|
|
|
|
it "performs the query and returns results including blurbs" do
|
|
Search.expects(:new).with('test', guardian: guardian, include_blurbs: true).returns(search)
|
|
search.expects(:execute)
|
|
|
|
xhr :get, :query, term: 'test', include_blurbs: 'true'
|
|
end
|
|
|
|
it 'performs the query with a filter and passes through search_for_id' do
|
|
Search.expects(:new).with('test', guardian: guardian, search_for_id: true, type_filter: 'topic').returns(search)
|
|
search.expects(:execute)
|
|
|
|
xhr :get, :query, term: 'test', type_filter: 'topic', search_for_id: true
|
|
end
|
|
end
|
|
|
|
|
|
context "search context" do
|
|
|
|
it "raises an error with an invalid context type" do
|
|
expect {
|
|
xhr :get, :query, term: 'test', search_context: {type: 'security', id: 'hole'}
|
|
}.to raise_error(Discourse::InvalidParameters)
|
|
end
|
|
|
|
it "raises an error with a missing id" do
|
|
expect {
|
|
xhr :get, :query, term: 'test', search_context: {type: 'user'}
|
|
}.to raise_error(Discourse::InvalidParameters)
|
|
end
|
|
|
|
context "with a user" do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
it "raises an error if the user can't see the context" do
|
|
Guardian.any_instance.expects(:can_see?).with(user).returns(false)
|
|
xhr :get, :query, term: 'test', search_context: {type: 'user', id: user.username}
|
|
expect(response).not_to be_success
|
|
end
|
|
|
|
|
|
it 'performs the query with a search context' do
|
|
guardian = Guardian.new
|
|
Guardian.stubs(:new).returns(guardian)
|
|
|
|
search = mock()
|
|
Search.expects(:new).with('test', guardian: guardian, search_context: user).returns(search)
|
|
search.expects(:execute)
|
|
|
|
xhr :get, :query, term: 'test', search_context: {type: 'user', id: user.username}
|
|
end
|
|
|
|
end
|
|
|
|
|
|
end
|
|
|
|
|
|
|
|
end
|