discourse

mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00

Files

Martin Brennan 788bcb7736 DEV: Fix hashtag system spec flakys (#19574 )

Honestly seems like it's being in some weird loop for
discourse/hashtag_autocomplete_spec.rb for this:

```ruby
  within topic_page.post_by_number(2) do
      cooked_hashtags = page.all(".hashtag-cooked", count: 2)

      expect(cooked_hashtags[0]["outerHTML"]).to eq(<<~HTML.chomp)
      <a class=\"hashtag-cooked\" href=\"#{category.url}\" data-type=\"category\" data-slug=\"cool-cat\"><svg class=\"fa d-icon d-icon-folder svg-icon svg-node\"><use href=\"#folder\"></use></svg><span>Cool Category</span></a>
      HTML
      expect(cooked_hashtags[1]["outerHTML"]).to eq(<<~HTML.chomp)
      <a class=\"hashtag-cooked\" href=\"#{tag.url}\" data-type=\"tag\" data-slug=\"cooltag\"><svg class=\"fa d-icon d-icon-tag svg-icon svg-node\"><use href=\"#tag\"></use></svg><span>cooltag</span></a>
      HTML
    end
```

I see this many times in the full logs with `SELENIUM_VERBOSE_DRIVER_LOGS=1`:

```
COMMAND FindElements {
   "using": "css selector",
   "value": "#post_2"
}

Followed by:

COMMAND FindChildElements {
   "id": "26dfe542-659b-46cc-ac8c-a6c2d9cbdf0a",
   "using": "css selector",
   "value": ".hashtag-cooked"
}
```

Over and over and over, there are 58 such occurrences. I am beginning to
think `within` is just poison that should be avoided.

2022-12-23 09:23:29 +10:00

page_objects

DEV: Fix hashtag system spec flakys (#19574 )

2022-12-23 09:23:29 +10:00

user_page

FIX: Invalid route path for staff info warnings link (#19461 )

2022-12-14 07:14:01 +08:00

admin_customize_themes_spec.rb

DEV: Add system test for updating color scheme of a theme (#19370 )

2022-12-08 08:38:36 +08:00

bookmarks_spec.rb

DEV: Minimal first pass of rails system test setup (#16311 )