mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 20:24:05 -06:00
7aab65887f
Why this change? The tags modal loads more tags via infinite loading based on when the last tag in the given page appears in the viewport for the user. When it comes in to view, a request is then triggered to fetch additional tags. To ensure that we are only loading a single page of tags each time the modal is opened, we previously set a max height on the modal's body to ensure that the last tag which appears in the modal will be outside of the view port in the initial load. However, this has regressed recently due to unknown reasons and resulted in multiple pages of tags being loaded immediately from the server as the modal's height was not restricted. This regression was caught by an existing test but was unfortunately determined as flaky. What does this change do? This change restores the max height on the edit navigation menu tags modal on dekstop. |
||
|---|---|---|
| .. | ||
| images | ||
| javascripts | ||
| stylesheets | ||