IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity
7c32411881
discourse/spec/jobs
History
Martin Brennan 7c32411881
FEATURE: Secure media allowing duplicated uploads with category-level privacy and post-based access rules () 
### General Changes and Duplication

* We now consider a post `with_secure_media?` if it is in a read-restricted category.
* When uploading we now set an upload's secure status straight away.
* When uploading if `SiteSetting.secure_media` is enabled, we do not check to see if the upload already exists using the `sha1` digest of the upload. The `sha1` column of the upload is filled with a `SecureRandom.hex(20)` value which is the same length as `Upload::SHA1_LENGTH`. The `original_sha1` column is filled with the _real_ sha1 digest of the file. 
* Whether an upload `should_be_secure?` is now determined by whether the `access_control_post` is `with_secure_media?` (if there is no access control post then we leave the secure status as is).
* When serializing the upload, we now cook the URL if the upload is secure. This is so it shows up correctly in the composer preview, because we set secure status on upload.

### Viewing Secure Media

* The secure-media-upload URL will take the post that the upload is attached to into account via `Guardian.can_see?` for access permissions
* If there is no `access_control_post` then we just deliver the media. This should be a rare occurrance and shouldn't cause issues as the `access_control_post` is set when `link_post_uploads` is called via `CookedPostProcessor`

### Removed

We no longer do any of these because we do not reuse uploads by sha1 if secure media is enabled.

* We no longer have a way to prevent cross-posting of a secure upload from a private context to a public context.
* We no longer have to set `secure: false` for uploads when uploading for a theme component.
2020-01-16 13:50:27 +10:00
..
regular FIX: Allow secure uploads if global s3 setting active and enable_s3_uploads validations () 2019-11-20 07:46:44 +10:00
about_stats_spec.rb DEV: s/\$redis/Discourse\.redis () 2019-12-03 10:05:53 +01:00
activation_reminder_emails_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
auto_expire_user_api_keys_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
auto_queue_handler_spec.rb FIX: Don't send replies to flags that are ignored by expiry 2019-05-27 17:24:36 -04:00
automatic_group_membership_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
bulk_grant_trust_level_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
bulk_invite_spec.rb FEATURE: allow sending bulk invites to staged users 2019-10-30 11:40:03 +05:30
bump_topic_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
clean_up_associated_accounts_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
clean_up_crawler_stats_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
clean_up_deprecated_url_site_settings_spec.rb DEV: introduce new API to look up dynamic site setting 2019-05-07 11:00:30 +10:00
clean_up_email_logs_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
clean_up_inactive_users_spec.rb FIX: Don’t try to delete inactive moderators 2019-05-13 21:44:03 +02:00
clean_up_post_reply_keys_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
clean_up_unused_staged_users_spec.rb FIX: Don't try to delete staged, unused admins and mods 2019-08-21 15:29:51 +02:00
clean_up_uploads_spec.rb FEATURE: Secure media allowing duplicated uploads with category-level privacy and post-based access rules () 2020-01-16 13:50:27 +10:00
clean_up_user_export_topics_spec.rb FIX: delete system generated message when user_export record is deleted () 2019-05-28 16:38:41 +05:30
correct_missing_dualstack_urls_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
crawl_topic_link_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
create_missing_avatars_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
create_user_reviewable_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
delete_topic_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
disable_bootstrap_mode_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
download_avatar_from_url_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
download_backup_email_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
download_profile_background_from_url_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
emit_web_hook_event_spec.rb SPEC: Update webhook event attributes even when an error raised 2019-06-21 00:45:35 +05:30
enable_bootstrap_mode_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
enqueue_digest_emails_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
export_csv_file_spec.rb FIX: include default label when exporting reports 2019-07-26 12:57:13 +05:30
feature_topic_users_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
fix_out_of_sync_user_uploaded_avatar_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
fix_primary_emails_for_staged_users_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
fix_s3_etags_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
fix_user_usernames_and_groups_names_clash_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
grant_anniversary_badges_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
grant_new_user_of_the_month_badges_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
heartbeat_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
ignored_users_summary_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
invalidate_inactive_admins_spec.rb FIX: Do not deactivate admin accounts with recent posts or api keys () 2019-11-12 16:56:01 +00:00
invite_email_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
jobs_base_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
jobs_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
mass_award_badge_spec.rb FIX: Update featured badge ranking when mass-awarding badges 2020-01-14 14:39:20 +00:00
migrate_url_site_settings_spec.rb DEV: introduce new API to look up dynamic site setting 2019-05-07 11:00:30 +10:00
notify_mailing_list_subscribers_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
notify_moved_posts_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
notify_reviewable_spec.rb FEATURE: Hide Reviewable scores, change score filter to Priority 2019-05-07 14:05:23 -04:00
notify_tag_change_spec.rb FIX: tag and category watchers regression () 2019-11-12 16:44:46 +11:00
pending_queued_posts_reminder_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
pending_reviewables_reminder_spec.rb FEATURE: Hide Reviewable scores, change score filter to Priority 2019-05-07 14:05:23 -04:00
pending_users_reminder_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
periodical_updates_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
poll_mailbox_spec.rb DEV: s/\$redis/Discourse\.redis () 2019-12-03 10:05:53 +01:00
post_uploads_recovery_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
process_bulk_invite_emails_spec.rb FEATURE: send max 200 emails every minute for bulk invites () 2019-07-19 11:29:12 +05:30
process_email_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
process_post_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
publish_topic_to_category_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
pull_hotlinked_images_spec.rb FIX: parallel spec system needs a dedicated upload folder for each worker. () 2019-12-18 11:21:57 +05:30
purge_expired_ignored_users_spec.rb DEV: Upgrading Discourse to Zeitwerk () 2019-10-02 14:01:53 +10:00
rebake_custom_emoji_posts_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
reindex_search_spec.rb FIX: drop deleted posts from search index 2019-06-04 17:19:59 +10:00
reviewable_priorities_spec.rb Tweak calculation for reviewable sensitivities/priorities 2019-09-19 14:07:56 -04:00
send_system_message_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
suspicious_login_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
tl3_promotions_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
toggle_topic_closed_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
topic_reminder_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
truncate_user_flag_stats_spec.rb DEV: Prefabrication (test optimization) () 2019-05-07 13:12:20 +10:00
unsilence_users_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
update_gravatar_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
update_s3_inventory_spec.rb DEV: use #frozen_string_literal: true on all spec 2019-04-30 10:27:42 +10:00
user_email_spec.rb DEV: Fix heisentest (ensure that user ID really does not exist). 2019-10-14 12:25:43 +03:00