mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 18:30:26 -06:00
fc1fd1b416
In order to include the new/unread count in the browse more message under suggested topics, a couple of technical changes have to be made. 1. `PrivateMessageTopicTrackingState` is now auto-injected which is similar to how it is done for `TopicTrackingState`. This is done so we don't have to attempt to pass the `PrivateMessageTopicTrackingState` object multiple levels down into the suggested-topics component. While the object is auto-injected, we only fetch the initial state and start tracking when the relevant private messages routes has been hit and only when a private message's suggested topics is loaded. This is done as we do not want to add the extra overhead of fetching the inital state to all page loads but instead wait till the private messages routes are hit. 2. Previously, we would stop tracking once the `user-private-messages` route has been deactivated. However, that is not ideal since navigating out of the route and back means we send an API call to the server each time. Since `PrivateMessageTopicTrackingState` is kept in sync cheaply via messageBus, we can just continue to track the state even if the user has navigated away from the relevant stages.
192 lines
5.6 KiB
Ruby
192 lines
5.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe CurrentUserSerializer do
|
|
context "when SSO is not enabled" do
|
|
fab!(:user) { Fabricate(:user) }
|
|
let :serializer do
|
|
CurrentUserSerializer.new(user, scope: Guardian.new, root: false)
|
|
end
|
|
|
|
it "should not include the external_id field" do
|
|
payload = serializer.as_json
|
|
expect(payload).not_to have_key(:external_id)
|
|
end
|
|
end
|
|
|
|
context "when SSO is enabled" do
|
|
let :user do
|
|
user = Fabricate(:user)
|
|
SingleSignOnRecord.create!(user_id: user.id, external_id: '12345', last_payload: '')
|
|
user
|
|
end
|
|
|
|
let :serializer do
|
|
CurrentUserSerializer.new(user, scope: Guardian.new, root: false)
|
|
end
|
|
|
|
it "should include the external_id" do
|
|
SiteSetting.discourse_connect_url = "http://example.com/discourse_sso"
|
|
SiteSetting.discourse_connect_secret = "12345678910"
|
|
SiteSetting.enable_discourse_connect = true
|
|
payload = serializer.as_json
|
|
expect(payload[:external_id]).to eq("12345")
|
|
end
|
|
end
|
|
|
|
context "#top_category_ids" do
|
|
fab!(:user) { Fabricate(:user) }
|
|
fab!(:category1) { Fabricate(:category) }
|
|
fab!(:category2) { Fabricate(:category) }
|
|
fab!(:category3) { Fabricate(:category) }
|
|
let :serializer do
|
|
CurrentUserSerializer.new(user, scope: Guardian.new, root: false)
|
|
end
|
|
|
|
it "should include empty top_category_ids array" do
|
|
payload = serializer.as_json
|
|
expect(payload[:top_category_ids]).to eq([])
|
|
end
|
|
|
|
it "should include correct id in top_category_ids array" do
|
|
_category = Category.first
|
|
CategoryUser.create!(user_id: user.id,
|
|
category_id: category1.id,
|
|
notification_level: CategoryUser.notification_levels[:tracking])
|
|
|
|
CategoryUser.create!(user_id: user.id,
|
|
category_id: category2.id,
|
|
notification_level: CategoryUser.notification_levels[:watching])
|
|
|
|
CategoryUser.create!(user_id: user.id,
|
|
category_id: category3.id,
|
|
notification_level: CategoryUser.notification_levels[:regular])
|
|
|
|
payload = serializer.as_json
|
|
expect(payload[:top_category_ids]).to eq([category2.id, category1.id])
|
|
end
|
|
end
|
|
|
|
context "#muted_tag_ids" do
|
|
fab!(:user) { Fabricate(:user) }
|
|
fab!(:tag) { Fabricate(:tag) }
|
|
let!(:tag_user) do
|
|
TagUser.create!(user_id: user.id,
|
|
notification_level: TagUser.notification_levels[:muted],
|
|
tag_id: tag.id
|
|
)
|
|
end
|
|
let :serializer do
|
|
CurrentUserSerializer.new(user, scope: Guardian.new, root: false)
|
|
end
|
|
|
|
it 'include muted tag ids' do
|
|
payload = serializer.as_json
|
|
expect(payload[:muted_tag_ids]).to eq([tag.id])
|
|
end
|
|
end
|
|
|
|
context "#second_factor_enabled" do
|
|
fab!(:user) { Fabricate(:user) }
|
|
let :serializer do
|
|
CurrentUserSerializer.new(user, scope: Guardian.new(user), root: false)
|
|
end
|
|
let(:json) { serializer.as_json }
|
|
|
|
it "is false by default" do
|
|
expect(json[:second_factor_enabled]).to eq(false)
|
|
end
|
|
|
|
context "when totp enabled" do
|
|
before do
|
|
User.any_instance.stubs(:totp_enabled?).returns(true)
|
|
end
|
|
|
|
it "is true" do
|
|
expect(json[:second_factor_enabled]).to eq(true)
|
|
end
|
|
end
|
|
|
|
context "when security_keys enabled" do
|
|
before do
|
|
User.any_instance.stubs(:security_keys_enabled?).returns(true)
|
|
end
|
|
|
|
it "is true" do
|
|
expect(json[:second_factor_enabled]).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "#groups" do
|
|
fab!(:member) { Fabricate(:user) }
|
|
let :serializer do
|
|
CurrentUserSerializer.new(member, scope: Guardian.new, root: false)
|
|
end
|
|
|
|
it "should only show visible groups" do
|
|
Fabricate.build(:group, visibility_level: Group.visibility_levels[:public])
|
|
hidden_group = Fabricate.build(:group, visibility_level: Group.visibility_levels[:owners])
|
|
public_group = Fabricate.build(:group, visibility_level: Group.visibility_levels[:public], name: "UppercaseGroupName")
|
|
hidden_group.add(member)
|
|
hidden_group.save!
|
|
public_group.add(member)
|
|
public_group.save!
|
|
payload = serializer.as_json
|
|
|
|
expect(payload[:groups]).to contain_exactly(
|
|
{ id: public_group.id, name: public_group.name, has_messages: false }
|
|
)
|
|
end
|
|
end
|
|
|
|
context "#has_topic_draft" do
|
|
fab!(:user) { Fabricate(:user) }
|
|
let :serializer do
|
|
CurrentUserSerializer.new(user, scope: Guardian.new, root: false)
|
|
end
|
|
|
|
it "is not included by default" do
|
|
payload = serializer.as_json
|
|
expect(payload).not_to have_key(:has_topic_draft)
|
|
end
|
|
|
|
it "returns true when user has a draft" do
|
|
Draft.set(user, Draft::NEW_TOPIC, 0, "test1")
|
|
|
|
payload = serializer.as_json
|
|
expect(payload[:has_topic_draft]).to eq(true)
|
|
end
|
|
|
|
it "clearing a draft removes has_topic_draft from payload" do
|
|
sequence = Draft.set(user, Draft::NEW_TOPIC, 0, "test1")
|
|
Draft.clear(user, Draft::NEW_TOPIC, sequence)
|
|
|
|
payload = serializer.as_json
|
|
expect(payload).not_to have_key(:has_topic_draft)
|
|
end
|
|
|
|
end
|
|
|
|
context '#can_review' do
|
|
it 'return false for regular users' do
|
|
serializer = serializer(Fabricate(:user))
|
|
payload = serializer.as_json
|
|
|
|
expect(payload[:can_review]).to eq(false)
|
|
end
|
|
|
|
it 'returns trus for staff' do
|
|
serializer = serializer(Fabricate(:admin))
|
|
payload = serializer.as_json
|
|
|
|
expect(payload[:can_review]).to eq(true)
|
|
end
|
|
|
|
def serializer(user)
|
|
CurrentUserSerializer.new(user, scope: Guardian.new(user), root: false)
|
|
end
|
|
end
|
|
end
|