mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 10:50:26 -06:00
932a2fe419
Users who use encoded slugs on their sites sometimes run into 500 error when pasting a link to another topic in a post. The problem happens when generating a backward "reflection" link that would appear in a linked topic. Link URL restricted on the database level to 500 chars in length. At first glance, it should work since we have a restriction on topic title length. But it doesn't work when a site uses encoded slugs, like here (take a look at the URL). The link to a topic, in this case, can be much longer than 500 characters. By the way, an error happens only when generating a "reflection" link and doesn't happen with a direct link, we truncate that link. It works because, in this case, the original long link is still present in the post body and can be used for navigation. But we can't do the same for backward "reflection" links (without rewriting their implementation), the whole link must be saved to the database. The simplest and cleanest solution will be just to remove the restriction on the database level. Abuse is impossible here since we are already protected by the restriction on topic title length. There aren’t performance benefits in using length-constrained columns in Postgres, in fact, length-constrained columns need a few extra CPU cycles to check the length when storing data. |
||
|---|---|---|
| .. | ||
| 20180917024729_remove_superfluous_columns.rb | ||
| 20180917034056_remove_superfluous_tables.rb | ||
| 20181012123001_drop_group_locked_trust_level_from_user.rb | ||
| 20181112013117_migrate_url_site_settings.rb | ||
| 20190103065652_remove_uploaded_meta_id_from_category.rb | ||
| 20190121203023_drop_queued_post_id_from_user_actions.rb | ||
| 20190123171817_drop_queued_posts.rb | ||
| 20190205104116_drop_unused_auth_tables.rb | ||
| 20190208144706_drop_unused_auth_tables_again.rb | ||
| 20190312194528_drop_email_user_options_columns.rb | ||
| 20190508141824_drop_claimed_by_id.rb | ||
| 20190716124050_remove_via_email_from_invite.rb | ||
| 20191107032231_change_notification_level.rb | ||
| 20191107190330_remove_suppress_from_latest_from_category.rb | ||
| 20191129144706_drop_unused_google_instagram_auth_tables.rb | ||
| 20191219112000_remove_key_from_api_keys.rb | ||
| 20200117174646_make_post_reply_id_column_read_only.rb | ||
| 20200120131338_drop_unused_columns.rb | ||
| 20200330233427_drop_old_unread_pm_notification_indices.rb | ||
| 20200408121312_remove_key_from_user_api_key.rb | ||
| 20200415140830_drop_automatic_membership_retroactive_from_group.rb | ||
| 20200424032633_remove_canonical_email_from_user_emails.rb | ||
| 20200430010528_remove_avg_time_from_topics_posts.rb | ||
| 20200508141209_allow_null_old_email_on_email_change_requests.rb | ||
| 20200513185052_drop_topic_reply_count.rb | ||
| 20200520001619_remove_fks_from_bookmarks.rb | ||
| 20200522004855_remove_access_control_post_fk.rb | ||
| 20200601111500_remove_image_url_from_post_and_topic.rb | ||
| 20200610150900_correct_posts_schema.rb | ||
| 20200715045152_remove_bookmarks_delete_when_reminder_sent.rb | ||
| 20200724060632_remove_deprecated_allowlist_settings.rb | ||
| 20200728004302_drop_path_whitelist_from_embeddable_hosts.rb | ||
| 20200818084329_update_private_message_on_post_search_data.rb | ||
| 20200903045539_add_index_topics_on_timestamps_private.rb | ||
| 20201110110952_drop_github_user_infos.rb | ||
| 20210125100452_migrate_search_data_after_default_locale_rename.rb | ||
| 20210127140730_undo_add_processed_to_notifications.rb | ||
| 20210207232853_fix_topic_timer_duration_minutes.rb | ||
| 20210215231312_fix_group_flair_avatar_upload_security_and_acls.rb | ||
| 20210218022739_move_new_since_to_new_table_again.rb | ||
| 20210219171329_drop_old_sso_site_settings.rb | ||
| 20210302164429_drop_flash_onebox_site_setting.rb | ||
| 20210324043327_delete_orphan_post_revisions.rb | ||
| 20210328233843_fix_bookmarks_with_incorrect_topic_id.rb | ||
| 20210513125608_remove_length_constrain_from_topic_excerpt.rb | ||
| 20210525112226_remove_length_constrain_from_topic_link_url.rb | ||
| 20210528003603_fix_badge_image_avatar_upload_security_and_acls.rb | ||