mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 10:20:58 -06:00
9667485951
Until now, we have allowed testing themes in production environments via `/theme-qunit`. This was made possible by hacking the ember-cli build so that it would create the `tests.js` bundle in production. However, this is fundamentally problematic because a number of test-specific things are still optimized out of the Ember build in production mode. It also makes asset compilation significantly slower, and makes it more difficult for us to update our build pipeline (e.g. to introduce Embroider). This commit removes the ability to run qunit tests in production builds of the JS app when the Embdroider flag is enabled. If a production instance of Discourse exists exclusively for the development of themes (e.g. discourse.theme-creator.io) then they can add `EMBER_ENV: development` to their `app.yml` file. This will build the entire app in development mode, and has a significant performance impact. This must not be used for real production sites. This commit also refactors many of the request specs into system specs. This means that the tests are guaranteed to have Ember assets built, and is also a better end-to-end test than simply checking for the presence of certain `<script>` tags in the HTML. |
||
|---|---|---|
| .. | ||
| composer | ||
| emojis | ||
| helpers | ||
| page_objects | ||
| user_page | ||
| admin_customize_form_templates_spec.rb | ||
| admin_customize_themes_spec.rb | ||
| bookmarks_spec.rb | ||
| category_edit_spec.rb | ||
| category_topics_spec.rb | ||
| composer_uploads_spec.rb | ||
| csv_exports_spec.rb | ||
| custom_sidebar_sections_spec.rb | ||
| discovery_breadcrumb_navigation_spec.rb | ||
| dismissing_new_spec.rb | ||
| editing_sidebar_categories_navigation_spec.rb | ||
| editing_sidebar_community_section_spec.rb | ||
| editing_sidebar_tags_navigation_spec.rb | ||
| ember_deprecation_test.rb | ||
| fast_edit_spec.rb | ||
| filtering_topics_spec.rb | ||
| grant_badge_spec.rb | ||
| group_card_spec.rb | ||
| hashtag_autocomplete_spec.rb | ||
| keyboard_shortcuts_spec.rb | ||
| network_disconnected_spec.rb | ||
| new_topic_list_spec.rb | ||
| reviewables_spec.rb | ||
| s3_secure_uploads_spec.rb | ||
| s3_uploads_spec.rb | ||
| scroll_manager_service_spec.rb | ||
| search_spec.rb | ||
| tag_notification_level_spec.rb | ||
| tag_synonyms_spec.rb | ||
| theme_qunit_spec.rb | ||
| topic_list_focus_spec.rb | ||
| topic_page_spec.rb | ||
| user_selector_spec.rb | ||
| viewing_category_spec.rb | ||
| viewing_group_members_spec.rb | ||
| viewing_navigation_menu_preferences_spec.rb | ||
| viewing_sidebar_as_anonymous_user_spec.rb | ||
| viewing_sidebar_mobile_spec.rb | ||
| viewing_sidebar_spec.rb | ||
| viewing_user_menu_spec.rb | ||
| viewing_user_private_messages_spec.rb | ||