mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 18:30:26 -06:00
0a5a6dfded
We had quite a few cases in core where inputs are being mutated as a side effect of calling a method. This handles all the cases where specs caught this. Mutating inputs makes code harder to reason about. Eg: ``` frog = "frog" jump(frog) puts frog "fly" # ????? ``` This commit is part of a followup commit that adds # frozen_string_literal to all our specs.
27 lines
571 B
Ruby
27 lines
571 B
Ruby
# frozen_string_literal: true
|
|
|
|
class ReplyByEmailAddressValidator
|
|
def initialize(opts = {})
|
|
@opts = opts
|
|
end
|
|
|
|
def valid_value?(val)
|
|
return true if val.blank?
|
|
return false if !val.include?("@")
|
|
|
|
value = val.dup
|
|
value.strip!
|
|
|
|
if SiteSetting.find_related_post_with_key
|
|
return false if !value.include?("%{reply_key}")
|
|
value.sub!(/\+?%{reply_key}/, "")
|
|
end
|
|
|
|
value != SiteSetting.notification_email && !value.include?(" ")
|
|
end
|
|
|
|
def error_message
|
|
I18n.t('site_settings.errors.invalid_reply_by_email_address')
|
|
end
|
|
end
|