mirror of
https://github.com/discourse/discourse.git
synced 2024-12-02 05:29:17 -06:00
a5b810fe18
## Problem History modal is flashing when changing revision versions ## Context This was introduced in https://github.com/discourse/discourse/pull/22666 We need to have a conditional loading spinner for the initial paint of the history modal as we don't have the revision yet loaded, so this can cause some odd rendering issues. At the same time we don't want to display the loading spinner each time we toggle between the revision versions, because the loading spinner replaces the revision body causing the modal sizes to be drastically different resulting in _jumping_ or _flashing_. ## Fix Render the loading spinner only on the first paint of the modal. https://github.com/discourse/discourse/assets/50783505/8d19275e-86a5-4132-8a1f-af4b4f5301a6 |
||
|---|---|---|
| .. | ||
| assets | ||
| controllers | ||
| helpers | ||
| jobs | ||
| mailers | ||
| models | ||
| serializers | ||
| services | ||
| views | ||