mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 18:30:26 -06:00
fb184fed06
This should make it easier to track down how the incoming email was created, which is one of four locations: The POP3 poller (which picks up reply via email replies) The admin email controller #handle_mail (which is where hosted mail is sent) The IMAP sync tool The group SMTP mailer, which sends emails when replying to IMAP topics, pre-emptively creating IncomingEmail records to avoid double syncing
67 lines
2.6 KiB
Ruby
67 lines
2.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Jobs::GroupSmtpEmail do
|
|
fab!(:post) do
|
|
topic = Fabricate(:topic)
|
|
Fabricate(:post, topic: topic)
|
|
Fabricate(:post, topic: topic)
|
|
end
|
|
fab!(:group) { Fabricate(:imap_group) }
|
|
fab!(:recipient_user) { Fabricate(:user, email: "test@test.com") }
|
|
let(:post_id) { post.id }
|
|
let(:args) do
|
|
{
|
|
group_id: group.id,
|
|
post_id: post_id,
|
|
email: "test@test.com"
|
|
}
|
|
end
|
|
|
|
before do
|
|
SiteSetting.reply_by_email_address = "test+%{reply_key}@incoming.com"
|
|
SiteSetting.manual_polling_enabled = true
|
|
SiteSetting.reply_by_email_enabled = true
|
|
SiteSetting.enable_smtp = true
|
|
end
|
|
|
|
it "sends an email using the GroupSmtpMailer and Email::Sender" do
|
|
message = Mail::Message.new(body: "hello", to: "myemail@example.invalid")
|
|
GroupSmtpMailer.expects(:send_mail).with(group, "test@test.com", post).returns(message)
|
|
Email::Sender.expects(:new).with(message, :group_smtp, recipient_user).returns(stub(send: nil))
|
|
subject.execute(args)
|
|
end
|
|
|
|
it "creates an IncomingEmail record to avoid double processing via IMAP" do
|
|
subject.execute(args)
|
|
incoming = IncomingEmail.find_by(post_id: post.id, user_id: post.user_id, topic_id: post.topic_id)
|
|
expect(incoming).not_to eq(nil)
|
|
expect(incoming.message_id).to eq("topic/#{post.topic_id}/#{post.id}@test.localhost")
|
|
expect(incoming.created_via).to eq(IncomingEmail.created_via_types[:group_smtp])
|
|
end
|
|
|
|
it "creates a PostReplyKey and correctly uses it for the email reply_key substitution" do
|
|
subject.execute(args)
|
|
incoming = IncomingEmail.find_by(post_id: post.id, user_id: post.user_id, topic_id: post.topic_id)
|
|
post_reply_key = PostReplyKey.where(user_id: recipient_user, post_id: post.id).first
|
|
expect(post_reply_key).not_to eq(nil)
|
|
expect(incoming.raw).to include("Reply-To: Discourse <test+#{post_reply_key.reply_key}@incoming.com>")
|
|
end
|
|
|
|
it "has the from_address and the to_addresses and subject filled in correctly" do
|
|
subject.execute(args)
|
|
incoming = IncomingEmail.find_by(post_id: post.id, user_id: post.user_id, topic_id: post.topic_id)
|
|
expect(incoming.to_addresses).to eq("test@test.com")
|
|
expect(incoming.subject).to include("Re: This is a test topic")
|
|
expect(incoming.from_address).to eq("discourseteam@ponyexpress.com")
|
|
end
|
|
|
|
context "when the post in the argument is the OP" do
|
|
let(:post_id) { post.topic.posts.first.id }
|
|
it "aborts and does not send a group SMTP email; the OP is the one that sent the email in the first place" do
|
|
expect { subject.execute(args) }.not_to(change { IncomingEmail.count })
|
|
end
|
|
end
|
|
end
|