IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-29 04:03:57 -06:00
Code Issues Packages Projects Releases Wiki Activity
b2acc416e7
discourse/spec/services
History
Martin Brennan b2acc416e7
FIX: Server-side hashtag lookups of secure categories for a user (#19377) 
* FIX: Use Category.secured(guardian) for hashtag datasource

Follow up to comments in #19219, changing the category
hashtag datasource to use Category.secured(guardian) instead
of Site.new(guardian).categories here since the latter does
more work for not much benefit, and the query time is the
same. Also eliminates some Hash -> Model back and forth
busywork. Add some more specs too.

* FIX: Server-side hashtag lookup cooking user loading

When we were using the PrettyText.options.currentUser
and parsing back and forth with JSON for the hashtag
lookups server-side, we had a bug where the user's
secure categories were not loaded since we never actually
loaded a User model from the database, only parsed it
from JSON.

This commit fixes the issue by instead using the
PretyText.options.userId and looking up the user directly
from the database when calling hashtag_lookup via the
PrettyText::Helpers code when cooking server-side. Added
the missing spec to check for this as well.
2022-12-09 10:34:25 +10:00
..
notifications Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
anonymous_shadow_creator_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
auto_silence_spec.rb DEV: Use AR enums in reviewables related code 2022-09-22 14:44:27 +02:00
badge_granter_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
base_bookmarkable_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
category_hashtag_data_source_spec.rb FIX: Server-side hashtag lookups of secure categories for a user (#19377) 2022-12-09 10:34:25 +10:00
color_scheme_revisor_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
destroy_task_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
email_settings_exception_handler_spec.rb DEV: Upgrade to Rails 7 2022-04-28 11:51:03 +02:00
email_settings_validator_spec.rb DEV: Upgrade to Rails 7 2022-04-28 11:51:03 +02:00
email_style_updater_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
external_upload_manager_spec.rb DEV: Run some specs with fake S3 implementation instead of stubs 2022-06-28 21:27:52 +02:00
flag_sockpuppets_spec.rb DEV: Use AR enums in reviewables related code 2022-09-22 14:44:27 +02:00
group_action_logger_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
group_mentions_updater_spec.rb DEV: Automatically require 'rails_helper' in all specs (#16077) 2022-03-01 17:50:50 +00:00
group_message_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
hashtag_autocomplete_service_spec.rb FIX: Server-side hashtag lookups of secure categories for a user (#19377) 2022-12-09 10:34:25 +10:00
heat_settings_updater_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
inline_uploads_multisite_spec.rb FIX: Maintain HTML <img when downloading remote images (#16278) 2022-03-29 10:55:10 +01:00
inline_uploads_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
notification_emailer_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
post_action_notifier_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
post_alerter_spec.rb FIX: Don't notify topic author about small action posts (#18789) 2022-10-31 06:26:20 +08:00
post_bookmarkable_spec.rb DEV: Guardians aren't active record objects, so shouldn't use fab! (#17789) 2022-08-03 19:17:40 -05:00
post_owner_changer_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
push_notification_pusher_spec.rb FIX: fallback to default push notification icon if none exists (#16961) 2022-06-01 12:00:05 +10:00
random_topic_selector_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
search_indexer_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
sidebar_site_settings_backfiller_spec.rb FIX: Ignore unique conflicts when backfilling sidebar defaults (#18785) 2022-10-28 07:47:41 +08:00
site_settings_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
staff_action_logger_spec.rb FIX: Restore trust level when leaving group (#17954) 2022-08-29 13:00:48 +03:00
tag_hashtag_data_source_spec.rb FEATURE: Allow showing hashtag autocomplete results without term (#19219) 2022-12-08 13:47:59 +10:00
themes_spec.rb SECURITY: Expand and improve SSRF Protections (#18815) 2022-11-01 16:33:17 +00:00
topic_bookmarkable_spec.rb DEV: Guardians aren't active record objects, so shouldn't use fab! (#17789) 2022-08-03 19:17:40 -05:00
topic_status_updater_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
topic_timestamp_changer_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
trust_level_granter_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_activator_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_anonymizer_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
user_authenticator_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_destroyer_spec.rb DEV: Use AR enums in reviewables related code 2022-09-22 14:44:27 +02:00
user_merger_spec.rb DEV: Fix mocha deprecations (#18828) 2022-11-02 10:47:59 +01:00
user_notification_schedule_processor_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_silencer_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_stat_count_updater_spec.rb Add RSpec 4 compatibility (#17652) 2022-07-28 10:27:38 +08:00
user_updater_spec.rb FIX: Do not reset seen popups when skip_new_user_tips is false (#19345) 2022-12-07 18:27:10 +02:00
username_changer_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
username_checker_service_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
wildcard_domain_checker_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
wildcard_url_checker_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00
word_watcher_spec.rb DEV: Use proper wording for contexts in specs 2022-08-04 11:05:02 +02:00