mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 20:24:05 -06:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
56 lines
1.5 KiB
Ruby
56 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
require 'has_errors'
|
|
|
|
describe HasErrors do
|
|
|
|
class ErrorTestClass
|
|
include HasErrors
|
|
end
|
|
|
|
let(:error_test) { ErrorTestClass.new }
|
|
let(:title_error) { "Title can't be blank" }
|
|
|
|
# No title is invalid
|
|
let(:invalid_topic) { Fabricate.build(:topic, title: '') }
|
|
|
|
it "has no errors by default" do
|
|
expect(error_test.errors).to be_blank
|
|
end
|
|
|
|
context "validate_child" do
|
|
it "adds the errors from invalid AR objects" do
|
|
expect(error_test.validate_child(invalid_topic)).to eq(false)
|
|
expect(error_test.errors).to be_present
|
|
expect(error_test.errors[:base]).to include(title_error)
|
|
end
|
|
|
|
it "doesn't add the errors from valid AR objects" do
|
|
topic = Fabricate.build(:topic)
|
|
expect(error_test.validate_child(topic)).to eq(true)
|
|
expect(error_test.errors).to be_blank
|
|
end
|
|
end
|
|
|
|
context "rollback_from_errors!" do
|
|
it "triggers a rollback" do
|
|
invalid_topic.valid?
|
|
|
|
expect(-> { error_test.rollback_from_errors!(invalid_topic) }).to raise_error(ActiveRecord::Rollback)
|
|
expect(error_test.errors).to be_present
|
|
expect(error_test.errors[:base]).to include(title_error)
|
|
end
|
|
end
|
|
|
|
context "rollback_with_error!" do
|
|
it "triggers a rollback" do
|
|
|
|
expect(-> {
|
|
error_test.rollback_with!(invalid_topic, :custom_error)
|
|
}).to raise_error(ActiveRecord::Rollback)
|
|
expect(error_test.errors).to be_present
|
|
expect(error_test.errors[:base]).to include(:custom_error)
|
|
end
|
|
end
|
|
|
|
end
|