mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 10:20:58 -06:00
a442eeb0f4
Currently redirecting to an external URL through a permalink doesn’t work because Rails raises a `ActionController::Redirecting::UnsafeRedirectError` error. This wasn’t the case before we upgraded to Rails 7.0. This patch fixes the issue by using `allow_other_host: true` on the redirect.
58 lines
1.6 KiB
Ruby
58 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe PermalinksController do
|
|
fab!(:topic)
|
|
fab!(:permalink) { Fabricate(:permalink, url: "deadroute/topic/546") }
|
|
|
|
describe "show" do
|
|
it "should redirect to a permalink's target_url with status 301" do
|
|
permalink.update!(topic_id: topic.id)
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should work for subfolder installs too" do
|
|
permalink.update!(topic_id: topic.id)
|
|
set_subfolder "/forum"
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should apply normalizations" do
|
|
permalink.update!(external_url: "/topic/100")
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response).to redirect_to("/topic/100")
|
|
expect(response.status).to eq(301)
|
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1X"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it "return 404 if permalink record does not exist" do
|
|
get "/not/a/valid/url"
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
context "when permalink's target_url is an external URL" do
|
|
before { permalink.update!(external_url: "https://github.com/discourse/discourse") }
|
|
|
|
it "redirects to it properly" do
|
|
get "/#{permalink.url}"
|
|
expect(response).to redirect_to(permalink.external_url)
|
|
end
|
|
end
|
|
end
|
|
end
|