mirror of
https://github.com/discourse/discourse.git
synced 2024-11-25 18:30:26 -06:00
b93b6c4299
This is a fix to address blurry onebox favicon images if the site you are linking to happens to have a favicon.ico file that contains multiple images. This fix detects of we are trying to create an upload for a favicon.ico file. We then convert it to a png and not a jpeg like we were doing. We want a png because it will preserve transparency, otherwise if we convert it to a jpeg we lose that and it looks bad on dark themed sites. This fix also addresses the fact that .ico files can include multiple images. The blurry images we were producing was caused by the ImageMagick `-flatten` option when the .ico file had multiple images which then squishes them all together. So for .ico files we are no longer flattening them and instead we are grabbing the last image in the .ico bundle and converting that single image to a png. |
||
|---|---|---|
| .. | ||
| backup_restore | ||
| compression | ||
| content_security_policy | ||
| i18n | ||
| imap/providers | ||
| onebox | ||
| seed_data | ||
| site_settings | ||
| topic_query | ||
| validators | ||
| webauthn | ||
| bookmark_manager_spec.rb | ||
| bookmark_query_spec.rb | ||
| bookmark_reminder_notification_handler_spec.rb | ||
| browser_detection_spec.rb | ||
| content_security_policy_spec.rb | ||
| db_helper_spec.rb | ||
| discourse_js_processor_spec.rb | ||
| encodings_spec.rb | ||
| introduction_updater_spec.rb | ||
| message_id_service_spec.rb | ||
| mini_sql_multisite_connection_spec.rb | ||
| onebox_spec.rb | ||
| post_jobs_enqueuer_spec.rb | ||
| s3_cors_rulesets_spec.rb | ||
| search_spec.rb | ||
| shrink_uploaded_image_spec.rb | ||
| theme_flag_modifier_spec.rb | ||
| theme_javascript_compiler_spec.rb | ||
| topic_upload_security_manager_spec.rb | ||
| upload_creator_spec.rb | ||
| upload_recovery_spec.rb | ||
| upload_security_spec.rb | ||