mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 10:50:26 -06:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
68 lines
2.1 KiB
Ruby
68 lines
2.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe ClicksController do
|
|
|
|
context 'create' do
|
|
|
|
context 'missing params' do
|
|
it 'raises a 404 without the url param' do
|
|
xhr :get, :track, post_id: 123
|
|
expect(response).to be_not_found
|
|
end
|
|
|
|
it "redirects to the url even without the topic_id or post_id params" do
|
|
xhr :get, :track, url: 'http://google.com'
|
|
expect(response).not_to be_redirect
|
|
end
|
|
end
|
|
|
|
context 'correct params' do
|
|
let(:url) { "http://discourse.org" }
|
|
|
|
before { request.stubs(:remote_ip).returns('192.168.0.1') }
|
|
|
|
context "with a made up url" do
|
|
it "doesn't redirect" do
|
|
TopicLinkClick.expects(:create_from).returns(nil)
|
|
xhr :get, :track, url: 'http://discourse.org', post_id: 123
|
|
expect(response).not_to be_redirect
|
|
end
|
|
end
|
|
|
|
context "with a query string" do
|
|
it "redirects" do
|
|
TopicLinkClick.expects(:create_from).with(has_entries('url' => 'http://discourse.org/?hello=123')).returns(url)
|
|
xhr :get, :track, url: 'http://discourse.org/?hello=123', post_id: 123
|
|
expect(response).to redirect_to(url)
|
|
end
|
|
end
|
|
|
|
context 'with a post_id' do
|
|
it 'redirects' do
|
|
TopicLinkClick.expects(:create_from).with('url' => url, 'post_id' => '123', 'ip' => '192.168.0.1').returns(url)
|
|
xhr :get, :track, url: url, post_id: 123
|
|
expect(response).to redirect_to(url)
|
|
end
|
|
|
|
it "doesn't redirect with the redirect=false param" do
|
|
TopicLinkClick.expects(:create_from).with('url' => url, 'post_id' => '123', 'ip' => '192.168.0.1', 'redirect' => 'false').returns(url)
|
|
xhr :get, :track, url: url, post_id: 123, redirect: 'false'
|
|
expect(response).not_to be_redirect
|
|
end
|
|
|
|
end
|
|
|
|
context 'with a topic_id' do
|
|
it 'redirects' do
|
|
TopicLinkClick.expects(:create_from).with('url' => url, 'topic_id' => '789', 'ip' => '192.168.0.1').returns(url)
|
|
xhr :get, :track, url: url, topic_id: 789
|
|
expect(response).to redirect_to(url)
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|