mirror of
https://github.com/discourse/discourse.git
synced 2024-11-22 08:57:10 -06:00
6e8c2bb4ab
Why this change? The two tests being updated in question has been flaky on CI. However, when using `be_forbidden`, the error message does not indicate what the actual response code was making it hard for us to debug. What does this change do? Assert for the exact response status code we are expecting.
142 lines
4.1 KiB
Ruby
142 lines
4.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe FinishInstallationController do
|
|
describe "#index" do
|
|
context "when has_login_hint is false" do
|
|
before { SiteSetting.has_login_hint = false }
|
|
|
|
it "doesn't allow access" do
|
|
get "/finish-installation"
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
|
|
context "when has_login_hint is true" do
|
|
before { SiteSetting.has_login_hint = true }
|
|
|
|
it "allows access" do
|
|
get "/finish-installation"
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#register" do
|
|
context "when has_login_hint is false" do
|
|
before { SiteSetting.has_login_hint = false }
|
|
|
|
it "doesn't allow access" do
|
|
get "/finish-installation/register"
|
|
expect(response.status).to eq(403)
|
|
end
|
|
end
|
|
|
|
context "when has_login_hint is true" do
|
|
before do
|
|
SiteSetting.has_login_hint = true
|
|
GlobalSetting.stubs(:developer_emails).returns("robin@example.com")
|
|
end
|
|
|
|
it "allows access" do
|
|
get "/finish-installation/register"
|
|
expect(response.status).to eq(200)
|
|
end
|
|
|
|
it "raises an error when the email is not in the allowed list" do
|
|
post "/finish-installation/register.json",
|
|
params: {
|
|
email: "notrobin@example.com",
|
|
username: "eviltrout",
|
|
password: "disismypasswordokay",
|
|
}
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "doesn't redirect when fields are wrong" do
|
|
post "/finish-installation/register",
|
|
params: {
|
|
email: "robin@example.com",
|
|
username: "",
|
|
password: "disismypasswordokay",
|
|
}
|
|
|
|
expect(response).not_to be_redirect
|
|
end
|
|
|
|
context "with working params" do
|
|
let(:params) do
|
|
{ email: "robin@example.com", username: "eviltrout", password: "disismypasswordokay" }
|
|
end
|
|
|
|
it "registers the admin when the email is in the list" do
|
|
expect do post "/finish-installation/register.json", params: params end.to change {
|
|
Jobs::CriticalUserEmail.jobs.size
|
|
}.by(1)
|
|
|
|
expect(response).to be_redirect
|
|
expect(User.where(username: "eviltrout").exists?).to eq(true)
|
|
end
|
|
|
|
it "automatically resends the signup email when the user already exists" do
|
|
expect do post "/finish-installation/register.json", params: params end.to change {
|
|
Jobs::CriticalUserEmail.jobs.size
|
|
}.by(1)
|
|
|
|
expect(User.where(username: "eviltrout").exists?).to eq(true)
|
|
|
|
expect do post "/finish-installation/register.json", params: params end.to change {
|
|
Jobs::CriticalUserEmail.jobs.size
|
|
}.by(1)
|
|
|
|
expect(response).to be_redirect
|
|
expect(User.where(username: "eviltrout").exists?).to eq(true)
|
|
end
|
|
end
|
|
|
|
it "sets the admins trust level" do
|
|
post "/finish-installation/register.json",
|
|
params: {
|
|
email: "robin@example.com",
|
|
username: "eviltrout",
|
|
password: "disismypasswordokay",
|
|
}
|
|
|
|
expect(User.find_by(username: "eviltrout").trust_level).to eq 1
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#confirm_email" do
|
|
context "when has_login_hint is false" do
|
|
before { SiteSetting.has_login_hint = false }
|
|
|
|
it "shows the page" do
|
|
get "/finish-installation/confirm-email"
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#resend_email" do
|
|
before do
|
|
SiteSetting.has_login_hint = true
|
|
GlobalSetting.stubs(:developer_emails).returns("robin@example.com")
|
|
|
|
post "/finish-installation/register",
|
|
params: {
|
|
email: "robin@example.com",
|
|
username: "eviltrout",
|
|
password: "disismypasswordokay",
|
|
}
|
|
end
|
|
|
|
it "resends the email" do
|
|
expect do put "/finish-installation/resend-email" end.to change {
|
|
Jobs::CriticalUserEmail.jobs.size
|
|
}.by(1)
|
|
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
end
|