mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 02:40:53 -06:00
d208396c5c
PERF: improve touch, swipe, panning performance on mobile menus --- * stop event propagation on swipe events: other touch events were stealing a huge amount of time here. Stop event propagation when handling pan events. * animate with [web animations api](https://developer.mozilla.org/en-US/docs/Web/API/Web_Animations_API/Using_the_Web_Animations_API) * prefer translate3d to hint for gpu rendering. * query document for elements only on start move event, not on subsequent move events * remove unused calculations for directioned velocity and distance: all swipe/pan elements function in x/y direction only. * re-implement scroll locking behavior. re-implemented scroll lock behavior --- With stop event propagation, we need to re-implement scroll locking on menu swipes. Previously, this was using onTouchMove which was costly. We may now use styling with overflow-y:hidden to lock scroll behavior. overflow:hidden on html/body elements is now supported by iOS as of 2022 https://bugs.webkit.org/show_bug.cgi?id=153852 https://bugs.webkit.org/show_bug.cgi?id=220908 UX: improve swipe --- Some improvements to get gestures and swipes feeling a little more polished. This focuses on end gesture, and how we transfer it to a css animation to complete a menu open/close action. Multitouch: events may pan, scroll, and zoom - especially on iOS safari. Cancelling the swipe event allows for a more pleasant zooming experience. * ease-out on menus opening, linear on close * calculate animation duration for opening and closing, attempt to better transfer user swipe velocity to css animation. * more timely close/open and cleanup from calculated animation timing. * add animation to closing menus on cloak tap * correctly animate menus with ease-in and ease-out * add swipe cancel event on multitouch event DEV --- * lean on promises js animations api gives us promises to listen to. Update test waiters to use waitForPromise from @ember/test-waiters instead of reigster/unregister. * convert swipe mixin to its own class. Convert swipe callbacks to custom events on the element. Move shared functions for max animation time and close logic to new shared class. swipe-events lib uses custom events to trigger callbacks, rather than assuming implemented hard coded function from the mixin's base class. Custom events are triggered from the bound element as swipestart, swipeend, swipe Add shared convenience functions for swipe events so they can be more easily shared. A client receives an initial swipe event and can check some state to see if it wants to handle the swipe event and if it doesn't, calling `event.preventDefault();` will prevent `swipe` and `swipeend` events from firing until another distinct swipestart event is fired. Swipe events will auto-cancel on multitouch. The scroll lock has also exposed as its own utility class. |
||
|---|---|---|
| .. | ||
| composer | ||
| emojis | ||
| groups | ||
| helpers | ||
| page_objects | ||
| user_page | ||
| admin_customize_form_templates_spec.rb | ||
| admin_customize_themes_spec.rb | ||
| bookmarks_spec.rb | ||
| category_edit_spec.rb | ||
| category_topics_spec.rb | ||
| change_owner_spec.rb | ||
| composer_uploads_spec.rb | ||
| csv_exports_spec.rb | ||
| custom_sidebar_sections_spec.rb | ||
| discovery_breadcrumb_navigation_spec.rb | ||
| dismissing_new_spec.rb | ||
| editing_sidebar_categories_navigation_spec.rb | ||
| editing_sidebar_community_section_spec.rb | ||
| editing_sidebar_tags_navigation_spec.rb | ||
| ember_deprecation_test.rb | ||
| fast_edit_spec.rb | ||
| filtering_topics_spec.rb | ||
| grant_badge_spec.rb | ||
| group_card_spec.rb | ||
| hashtag_autocomplete_spec.rb | ||
| keyboard_shortcuts_spec.rb | ||
| network_disconnected_spec.rb | ||
| new_topic_list_spec.rb | ||
| reviewables_spec.rb | ||
| s3_secure_uploads_spec.rb | ||
| s3_uploads_spec.rb | ||
| scroll_manager_service_spec.rb | ||
| search_spec.rb | ||
| tag_notification_level_spec.rb | ||
| tag_synonyms_spec.rb | ||
| tags_intersection_spec.rb | ||
| theme_qunit_spec.rb | ||
| topic_list_focus_spec.rb | ||
| topic_page_spec.rb | ||
| user_activation_spec.rb | ||
| user_selector_spec.rb | ||
| viewing_category_spec.rb | ||
| viewing_group_members_spec.rb | ||
| viewing_navigation_menu_preferences_spec.rb | ||
| viewing_sidebar_as_anonymous_user_spec.rb | ||
| viewing_sidebar_mobile_spec.rb | ||
| viewing_sidebar_spec.rb | ||
| viewing_user_menu_spec.rb | ||
| viewing_user_private_messages_spec.rb | ||