mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
8ebd5edd1e
This commit renames all secure_media related settings to secure_uploads_* along with the associated functionality. This is being done because "media" does not really cover it, we aren't just doing this for images and videos etc. but for all uploads in the site. Additionally, in future we want to secure more types of uploads, and enable a kind of "mixed mode" where some uploads are secure and some are not, so keeping media in the name is just confusing. This also keeps compatibility with the `secure-media-uploads` path, and changes new secure URLs to be `secure-uploads`. Deprecated settings: * secure_media -> secure_uploads * secure_media_allow_embed_images_in_emails -> secure_uploads_allow_embed_images_in_emails * secure_media_max_email_embed_image_size_kb -> secure_uploads_max_email_embed_image_size_kb
38 lines
1.1 KiB
Ruby
38 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe Jobs::UpdatePostUploadsSecureStatus do
|
|
fab!(:post) { Fabricate(:post) }
|
|
|
|
before do
|
|
UploadReference.create!(target: post, upload: Fabricate(:upload))
|
|
UploadReference.create!(target: post, upload: Fabricate(:upload))
|
|
end
|
|
|
|
context "when secure uploads is enabled" do
|
|
before do
|
|
setup_s3
|
|
stub_s3_store
|
|
SiteSetting.secure_uploads = true
|
|
end
|
|
|
|
context "when login_required" do
|
|
before { SiteSetting.login_required = true }
|
|
|
|
it "updates all the uploads to secure" do
|
|
described_class.new.execute(post_id: post.id)
|
|
post.reload
|
|
expect(post.upload_references.map(&:upload).map(&:secure).all?(true)).to eq(true)
|
|
end
|
|
|
|
it "updates all the uploads to secure even if their extension is not authorized" do
|
|
SiteSetting.authorized_extensions = ""
|
|
described_class.new.execute(post_id: post.id)
|
|
post.reload
|
|
expect(post.upload_references.map(&:upload).map(&:secure).all?(true)).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
end
|