discourse/plugins
Joffrey JAFFEUX dcaa719363
FIX: correctly handle subscriptions (#24270)
Subscriptions manager have been a pain since the beginning, one of the problem is that thread and channels behave mostly the same but with various small difference which I expect to increase over time.

Trying to use subclasses for this case has proven to be a mistake, this commit now uses a class for each case (channel, thread) which for now contains a lot of duplication, which might be reduced in the future but has the merit to make reasoning about each case very simple.

This refactor is fixing a bug introduced in 90efdd7f9d which was causing the wrong channel to be unsubscribed, this shouldn't be possible anymore. We had tests for this which were disabled due to flakeyness, I will consider re-enabling them in the future.

Other notes:
- notices had been added to the subscriptions manager service, they have been moved into their own dedicated service: `ChatChannelNoticesManager`
- the `(each model)` trick used in `<ChatChannel />` since 90efdd7f9d to ensure atomicity has been applied to `<ChatThread />` too
2023-11-07 16:37:42 +01:00
..
chat FIX: correctly handle subscriptions (#24270) 2023-11-07 16:37:42 +01:00
checklist DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
discourse-details DEV: remove markdown-it-bundle and custom build code (#23859) 2023-11-06 16:59:49 +00:00
discourse-lazy-videos FIX: Add rel=0 to youtube lazy videos url (#24173) 2023-10-31 08:04:23 -03:00
discourse-local-dates DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
discourse-narrative-bot DEV: Change anonymous_posting_min_trust_level to a group-based setting (#24072) 2023-10-25 11:45:10 +10:00
discourse-presence DEV: Sort imports 2023-10-10 21:46:54 +01:00
footnote DEV: Remove deprecated queue_jobs site setting (#24127) 2023-10-27 11:05:02 +08:00
poll DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
spoiler-alert Update translations (#24078) 2023-10-24 15:53:34 +02:00
styleguide FIX: Correct import path in styleguide (#24092) 2023-10-25 12:13:38 +01:00