A platform for community discussion. Free, open, simple.
Go to file
Martin Brennan dede942007
FEATURE: Allow email image embed with secure media (#10563)
This PR introduces a few important changes to secure media redaction in emails. First of all, two new site settings have been introduced:

* `secure_media_allow_embed_images_in_emails`: If enabled we will embed secure images in emails instead of redacting them.
* `secure_media_max_email_embed_image_size_kb`: The cap to the size of the secure image we will embed, defaulting to 1mb, so the email does not become too big. Max is 10mb. Works in tandem with `email_total_attachment_size_limit_kb`.

`Email::Sender` will now attach images to the email based on these settings. The sender will also call `inline_secure_images` in `Email::Styles` after secure media is redacted and attachments are added to replace redaction messages with attached images. I went with attachment and `cid` URLs because base64 image support is _still_ flaky in email clients.

All redaction of secure media is now handled in `Email::Styles` and calls out to `PrettyText.strip_secure_media` to do the actual stripping and replacing with placeholders. `app/mailers/group_smtp_mailer.rb` and `app/mailers/user_notifications.rb` no longer do any stripping because they are earlier in the pipeline than `Email::Styles`.

Finally the redaction notice has been restyled and includes a link to the media that the user can click, which will show it to them if they have the necessary permissions.

![image](https://user-images.githubusercontent.com/920448/92341012-b9a2c380-f0ff-11ea-860e-b376b4528357.png)
2020-09-10 09:50:16 +10:00
.github DEV: fixes eslint/prettier on github actions (#10601) 2020-09-04 20:01:14 +02:00
app FEATURE: Allow email image embed with secure media (#10563) 2020-09-10 09:50:16 +10:00
bin DEV: Add docker cleanup script to d/ folder 2020-03-01 12:09:07 -08:00
config FEATURE: Allow email image embed with secure media (#10563) 2020-09-10 09:50:16 +10:00
db PERF: Keep track of first unread PM and first unread group PM for user. 2020-09-09 14:05:41 +08:00
docs FIX: use allowlist and blocklist terminology (#10209) 2020-07-27 10:23:54 +10:00
images fix image location 2014-09-11 17:56:29 +10:00
lib FEATURE: Allow email image embed with secure media (#10563) 2020-09-10 09:50:16 +10:00
log Initial release of Discourse 2013-02-05 14:16:51 -05:00
plugins Update translations 2020-09-09 14:59:40 +00:00
public Update translations 2020-09-09 14:59:40 +00:00
script FIX: improve Vanilla importing (#10478) 2020-08-24 16:19:57 -04:00
spec FEATURE: Allow email image embed with secure media (#10563) 2020-09-10 09:50:16 +10:00
test DEV: apply new coding standards (#10592) 2020-09-04 13:42:47 +02:00
vendor FIX: highlightjs 10 requires some languages to be loaded before others (#10584) 2020-09-02 21:32:57 +02:00
.editorconfig Set trim_trailing_whitespace false for markdown 2016-06-25 22:29:01 +04:30
.eslintignore DEV: Don't lint core files when target == plugins (#10259) 2020-08-25 11:40:40 +02:00
.eslintrc DEV: upgrades dev config (#10588) 2020-09-04 13:33:03 +02:00
.git-blame-ignore-revs DEV: ignore coding standards applied to plugins (#10595) 2020-09-04 13:53:26 +02:00
.gitattributes Use proper encoding for email fixtures. 2018-02-21 17:06:35 +08:00
.gitignore DEV: Use a special import to declare font faces (#10583) 2020-09-04 16:25:50 +03:00
.licensed.yml DEV: Add a basic licensed config (#10128) 2020-06-25 18:01:36 -03:00
.prettierignore DEV: Don't lint core files when target == plugins (#10259) 2020-08-25 11:40:40 +02:00
.prettierrc DEV: upgrades dev config (#10588) 2020-09-04 13:33:03 +02:00
.rspec DEV: Use --profile and --fail-fast in CI only 2019-03-11 22:04:47 -04:00
.rspec_parallel DEV: Introduce parallel rspec testing 2019-04-01 11:06:47 -04:00
.rubocop.yml Revert "Bump rubocop-discourse to 2.3.0." 2020-07-24 13:18:49 +08:00
.ruby-gemset.sample rvm has offically depreicated .rvmrc and recommends using .ruby-version and .ruby-gemset instead. 2013-05-23 09:16:11 -07:00
.ruby-version.sample Make version the same as install docs (#8713) 2020-01-14 12:33:37 +11:00
.template-lintrc.js DEV: fixes eslint/prettier on github actions (#10601) 2020-09-04 20:01:14 +02:00
adminjs Initial release of Discourse 2013-02-05 14:16:51 -05:00
Brewfile DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
config.ru DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
CONTRIBUTING.md Proper long form for CLA 2015-09-10 20:49:03 +02:00
COPYRIGHT.txt DOCS: remove thin from copyright 2020-06-23 15:43:58 +10:00
d add wrappers for mailcatcher and sidekiq 2016-12-13 09:05:45 +11:00
Dangerfile DEV: Remove mention of Transifex from locale files 2020-08-06 13:34:00 +02:00
discourse.sublime-project DEV: Exclude i18n .yml files from Sublime Text project. (#6473) 2018-10-10 20:21:24 +08:00
Gemfile DEV: Switch over to a fork of ember-rails 2020-09-04 14:47:56 -06:00
Gemfile.lock Build(deps): Bump onebox from 2.1.1 to 2.1.2 (#10635) 2020-09-09 19:24:23 +05:30
jsapp Initial release of Discourse 2013-02-05 14:16:51 -05:00
lefthook.yml DEV: Ensure prettier uses the same patterns everywhere 2020-08-20 16:27:32 +02:00
LICENSE.txt Initial release of Discourse 2013-02-05 14:16:51 -05:00
package.json DEV: upgrades dev config (#10588) 2020-09-04 13:33:03 +02:00
Rakefile DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
README.md Update README.md 2020-08-11 16:01:35 -04:00
translator.yml DEV: Drop unsupported-browser plugin (#10261) 2020-07-17 15:04:06 +01:00
yarn.lock DEV: upgrades dev config (#10588) 2020-09-04 13:33:03 +02:00

Discourse is the 100% open source discussion platform built for the next decade of the Internet. Use it as a:

  • mailing list
  • discussion forum
  • long-form chat room

To learn more about the philosophy and goals of the project, visit discourse.org.

Screenshots

Boing Boing

Mobile

Browse lots more notable Discourse instances.

Development

To get your environment setup, follow the community setup guide for your operating system.

  1. If you're on macOS, try the macOS development guide.
  2. If you're on Ubuntu, try the Ubuntu development guide.
  3. If you're on Windows, try the Windows 10 development guide.

If you're familiar with how Rails works and are comfortable setting up your own environment, you can also try out the Discourse Advanced Developer Guide, which is aimed primarily at Ubuntu and macOS environments.

Before you get started, ensure you have the following minimum versions: Ruby 2.6+, PostgreSQL 10+, Redis 4.0+. If you're having trouble, please see our TROUBLESHOOTING GUIDE first!

Setting up Discourse

If you want to set up a Discourse forum for production use, see our Discourse Install Guide.

If you're looking for business class hosting, see discourse.org/buy.

Requirements

Discourse is built for the next 10 years of the Internet, so our requirements are high.

Discourse supports the latest, stable releases of all major browsers and platforms:

Browsers Tablets Phones
Apple Safari iPadOS iOS
Google Chrome Android Android
Microsoft Edge
Mozilla Firefox

Built With

  • Ruby on Rails — Our back end API is a Rails app. It responds to requests RESTfully in JSON.
  • Ember.js — Our front end is an Ember.js app that communicates with the Rails API.
  • PostgreSQL — Our main data store is in Postgres.
  • Redis — We use Redis as a cache and for transient data.
  • BrowserStack — We use BrowserStack to test on real devices and browsers.

Plus lots of Ruby Gems, a complete list of which is at /master/Gemfile.

Contributing

Build Status

Discourse is 100% free and open source. We encourage and support an active, healthy community that accepts contributions from the public including you!

Before contributing to Discourse:

  1. Please read the complete mission statements on discourse.org. Yes we actually believe this stuff; you should too.
  2. Read and sign the Electronic Discourse Forums Contribution License Agreement.
  3. Dig into CONTRIBUTING.MD, which covers submitting bugs, requesting new features, preparing your code for a pull request, etc.
  4. Always strive to collaborate with mutual respect.
  5. Not sure what to work on? We've got some ideas.

We look forward to seeing your pull requests!

Security

We take security very seriously at Discourse; all our code is 100% open source and peer reviewed. Please read our security guide for an overview of security measures in Discourse, or if you wish to report a security issue.

The Discourse Team

The original Discourse code contributors can be found in AUTHORS.MD. For a complete list of the many individuals that contributed to the design and implementation of Discourse, please refer to the official Discourse blog and GitHub's list of contributors.

Copyright 2014 - 2020 Civilized Discourse Construction Kit, Inc.

Licensed under the GNU General Public License Version 2.0 (or later); you may not use this work except in compliance with the License. You may obtain a copy of the License in the LICENSE file, or at:

https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt

Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

Discourse logo and “Discourse Forum” ®, Civilized Discourse Construction Kit, Inc.

Dedication

Discourse is built with love, Internet style.