mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 20:24:05 -06:00
30990006a9
This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging
27 lines
1.3 KiB
Ruby
27 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class DenormalizeExpressions < ActiveRecord::Migration[4.2]
|
|
def change
|
|
|
|
# Denormalizing this makes our queries so, so, so much nicer
|
|
|
|
add_column :posts, :expression1_count, :integer, null: false, default: 0
|
|
add_column :posts, :expression2_count, :integer, null: false, default: 0
|
|
add_column :posts, :expression3_count, :integer, null: false, default: 0
|
|
add_column :posts, :expression4_count, :integer, null: false, default: 0
|
|
add_column :posts, :expression5_count, :integer, null: false, default: 0
|
|
|
|
add_column :forum_threads, :expression1_count, :integer, null: false, default: 0
|
|
add_column :forum_threads, :expression2_count, :integer, null: false, default: 0
|
|
add_column :forum_threads, :expression3_count, :integer, null: false, default: 0
|
|
add_column :forum_threads, :expression4_count, :integer, null: false, default: 0
|
|
add_column :forum_threads, :expression5_count, :integer, null: false, default: 0
|
|
|
|
(1..5).each do |i|
|
|
execute "update posts set expression#{i}_count = (select count(*) from expressions where parent_id = posts.id and expression_type_id = #{i})"
|
|
execute "update forum_threads set expression#{i}_count = (select sum(expression#{i}_count) from posts where forum_thread_id = forum_threads.id)"
|
|
end
|
|
end
|
|
|
|
end
|